Attention is currently required from: fixeria, neels, osmith. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 3: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/34975/comment/15b751bd_93e10840 PS3, Line 623: "%s\n", OSMO_LOGCOLOR_END

I think you can even do `OSMO_LOGCOLOR_END "\n"`, since `OSMO_LOGCOLOR_END` is defined as a string l […] Not many, as snprintf will still have to iterate through the string and look for any %-format strings. I do like it better, though, thanks. Changed it.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account@tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 12:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment