November 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline
by osmith 07 Nov '23

07 Nov '23

Attention is currently required from: manawyrm, neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 11:44:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: tarballs: git archive: make proper tar.bz2
by osmith 07 Nov '23

07 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email ) Change subject: tarballs: git archive: make proper tar.bz2 ...................................................................... tarballs: git archive: make proper tar.bz2 Compress the tarball from "git archive" with bzip2 to turn it into a proper .tar.bz2. Previously the archive was named .tar.bz2, but it was just a regular tarball as git archive didn't guess the type from the filename (supposedly this works for .tar.gz and some others) and just defaulted to tar. Move the code that adds build_dep.tar.gz to the archive before the bzip2 call, because tar can't add files to the archive if it is compressed. Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 27 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/78/34978/1 diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 05d9f30..46a2e17 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -260,14 +260,16 @@ esac su build -c \"make dist-bzip2\" else - su build -c \"git archive --prefix=$prefix/ -o $tarball_name $tag\" - fi + su build -c \"git archive --prefix=$prefix/ -o $prefix.tar $tag\" - # Erlang projects: add build depends to release tarball - if [ -e build_dep.tar.gz ]; then - su build -c \"mkdir $prefix\" - su build -c \"mv build_dep.tar.gz $prefix\" - su build -c \"tar -rf $tarball_name $prefix/build_dep.tar.gz\" + # Erlang projects: add build depends to release tarball + if [ -e build_dep.tar.gz ]; then + su build -c \"mkdir $prefix\" + su build -c \"mv build_dep.tar.gz $prefix\" + su build -c \"tar -rf $prefix.tar $prefix/build_dep.tar.gz\" + fi + + su build -c \"bzip2 -9 $prefix.tar\" fi "; then echo "$LOG_PREFIX Building tarball failed!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5830f9123150540a6467c19c64461d2fa1972a52 Gerrit-Change-Number: 34978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: tarballs: add osmo_dia2gsup
by osmith 07 Nov '23

07 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email ) Change subject: tarballs: add osmo_dia2gsup ...................................................................... tarballs: add osmo_dia2gsup Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 --- M scripts/common.sh M scripts/tarballs/publish-tarballs-for-tags.sh 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/34976/1 diff --git a/scripts/common.sh b/scripts/common.sh index ea106e2..1081859 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -142,6 +142,9 @@ osmo-isdntap) echo "$OSMO_GIT_URL_GITEA"/retronetworking/"$1" ;; + osmo_dia2gsup) + echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" + ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" ;; diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index c185c21..4ef3b5f 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -42,6 +42,7 @@ osmo-sysmon osmo-trx osmo-uecups + osmo_dia2gsup osmocom-bb rtl-sdr simtrace2 @@ -240,6 +241,11 @@ cd /src/$project_path + # Erlang projects: download build depends + if [ -e contrib/generate_build_dep.sh ]; then + su build -c \"HOME=/build contrib/generate_build_dep.sh\" + fi + if /tarballs/prefer-configure.sh \"$repo\" \"$tag\"; then su build -c \"autoreconf -fi\" case \"$repo\" in @@ -255,6 +261,11 @@ else su build -c \"git archive -o $tarball_name $tag\" fi + + # Erlang projects: add build depends to release tarball + if [ -e build_dep.tar.gz ]; then + su build -c \"tar -rf $tarball_name build_dep.tar.gz\" + fi "; then echo "$LOG_PREFIX Building tarball failed!" exit 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9cbd3d3ce27a4b4c9c8e19b2876386d170d4f0a6 Gerrit-Change-Number: 34976 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: tarballs: git archive: put files in directory
by osmith 07 Nov '23

07 Nov '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email ) Change subject: tarballs: git archive: put files in directory ...................................................................... tarballs: git archive: put files in directory Make the releases created from the "git archive" code path more similar to the autotools releases, by having all files in a subdirectory with the project name and tag name instead of having them directly in the root of the tarball. $ tree osmo_dia2gsup-0.1.1 | head osmo_dia2gsup-0.1.1 ├── build_dep.tar.gz ├── contrib │ ├── generate_build_dep.sh │ ├── jenkins.sh │ └── systemd │ └── osmo_dia2gsup.service ├── debian │ ├── changelog │ ├── compat Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 31 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/34977/1 diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index 4ef3b5f..05d9f30 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -220,6 +220,7 @@ local project_path="$2" local tag="$3" local tarball_name="$(get_tarball_name "$project_path" "$tag")" + local prefix="$(echo "$tarball_name" | sed s/\.tar\.bz2//)" local uid_user="$(id -u)" echo "$LOG_PREFIX Building release tarball: $tarball_name" @@ -259,12 +260,14 @@ esac su build -c \"make dist-bzip2\" else - su build -c \"git archive -o $tarball_name $tag\" + su build -c \"git archive --prefix=$prefix/ -o $tarball_name $tag\" fi # Erlang projects: add build depends to release tarball if [ -e build_dep.tar.gz ]; then - su build -c \"tar -rf $tarball_name build_dep.tar.gz\" + su build -c \"mkdir $prefix\" + su build -c \"mv build_dep.tar.gz $prefix\" + su build -c \"tar -rf $tarball_name $prefix/build_dep.tar.gz\" fi "; then echo "$LOG_PREFIX Building tarball failed!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If37dcdc04278de0d4479cf72e0ca33c90b7deea8 Gerrit-Change-Number: 34977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: add HNBGW_Tests.TC_second_rab_assignment
by laforge 07 Nov '23

07 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34973?usp=email ) Change subject: add HNBGW_Tests.TC_second_rab_assignment ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadaba0e5e82ad6d163ad509904ede213e2462d5c Gerrit-Change-Number: 34973 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 11:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by laforge 07 Nov '23

07 Nov '23

Attention is currently required from: Hoernchen, arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email ) Change subject: logging: add log level cache ...................................................................... Patch Set 12: (1 comment) Patchset: PS9: > If it's about not introducing a new define... […] UINT8_MAX would be fine with me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 12 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: arehbein <arehbein(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 11:18:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline
by manawyrm 07 Nov '23

07 Nov '23

Attention is currently required from: neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... logging: ensure ANSI color escape is sent in same line/before newline This fixes multi-line color clobbering in logging daemons like systemd-journald, which work with single-lines only. Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 --- M src/core/logging.c M tests/loggingrb/logging_test.err 2 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/34975/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline
by manawyrm 07 Nov '23

07 Nov '23

Attention is currently required from: neels. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email ) Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: See https://osmocom.org/issues/6249 for example screenshots -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 11:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging: ensure ANSI color escape is sent in same line/before newline
by manawyrm 07 Nov '23

07 Nov '23

Attention is currently required from: manawyrm, neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: logging: ensure ANSI color escape is sent in same line/before newline ...................................................................... logging: ensure ANSI color escape is sent in same line/before newline This fixes multi-line color clobbering in logging daemons like systemd-journald, which work with single-lines only. Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 --- M src/core/logging.c M tests/loggingrb/logging_test.err 2 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/34975/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7de9d88aa5ac48ec0d5c1a931a89d21c02c5433 Gerrit-Change-Number: 34975 Gerrit-PatchSet: 2 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: allow (second) CS RAB Assignment Request without RTP info
by laforge 07 Nov '23

07 Nov '23

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34974?usp=email ) Change subject: allow (second) CS RAB Assignment Request without RTP info ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/34974/comment/8a2b43d9_f9a87848 PS4, Line 19: Do not (yet?) supp unrelated to this patch we certainly do need that. Think of a mobile-to-mobile call where the remote end is getting handed over. Or think of a prepaid subscriber whose call is getting redirected to some voice announcement of the blaance running dry during a call. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I25bf19981cd75a87a7ceb3382dae1ec626ae475c Gerrit-Change-Number: 34974 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Nov 2023 11:03:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0