Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email )
Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File library/GTPv2_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/42b32c78_d72a…
PS1, Line 751: 6
> Sorry previous comment want ment for the other discussion. […]
Ack
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/4eb4b232_d699…
PS1, Line 743: ?
> I don't even know why that value was set there tbh, but makes no sense to me.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
Gerrit-Change-Number: 34822
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Oct 2023 15:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email )
Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
......................................................................
Patch Set 1:
(2 comments)
File library/GTPv2_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/bbd82a13_d865…
PS1, Line 751: 6
> I don't even know why that value was set there tbh, but makes no sense to me.
Sorry previous comment want ment for the other discussion.
"why replace it with ?" because the RAT type really changes depending on where you use/expect the message. For instnace I'm expecting 5 (WLAN) in my current tests.
BTW, I believe this tr template was not yet used anywhere because it had some bugs which I'm now fixing with the patchset; a more generic template was being used instead.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/984f96ba_1aa8…
PS1, Line 743: ?
> shouldn't the previous default '012a'O be here?
I don't even know why that value was set there tbh, but makes no sense to me.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
Gerrit-Change-Number: 34822
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Oct 2023 15:03:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email )
Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
......................................................................
Patch Set 1:
(1 comment)
File library/GTPv2_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822/comment/f054892d_fe71…
PS1, Line 751: 6
> why replace it with ?
I don't even know why that value was set there tbh, but makes no sense to me.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
Gerrit-Change-Number: 34822
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Oct 2023 15:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email )
Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Duplicate of https://gerrit.osmocom. […]
I abandoned by duplicate patch. @lynxis@fe80.eu said he wanted to send an email to the ML requesting for comments on which message types to (re)use.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 19 Oct 2023 14:59:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment