October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
by pespin 20 Oct '23

20 Oct '23

Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ...................................................................... GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 --- M library/GTPv2_Templates.ttcn 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/34822/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 Gerrit-Change-Number: 34822 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req ...................................................................... epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4 --- M epdg/EPDG_Tests.ttcn 1 file changed, 84 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/34833/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4 Gerrit-Change-Number: 34833 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: log start of test in SUT
by osmith 20 Oct '23

20 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email ) Change subject: ggsn: log start of test in SUT ...................................................................... ggsn: log start of test in SUT Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/34839/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 6cc9732..5b1f7a1 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -292,6 +292,8 @@ f_init_vty(); f_vty_set_gpdu_txseq(use_gtpu_txseq); f_vty_enable_echo_interval(g_use_echo_intval); + /* Emit a marker to appear in the SUT's own logging output */ + f_logp(GGSNVTY, testcasename() & "() start"); } else if (m_ggsn_impl == GGSN_IMPL_OPEN5GS) { f_init_diameter(testcasename()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa Gerrit-Change-Number: 34839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp
by osmith 20 Oct '23

20 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email ) Change subject: library: deduplicate f_logp ...................................................................... library: deduplicate f_logp Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3 --- M bsc/BSC_Tests.ttcn M hnbgw/HNBGW_Tests.ttcn M hnodeb/HNB_Tests.ttcn M library/Osmocom_VTY_Functions.ttcn M smlc/SMLC_Tests.ttcn M upf/UPF_Tests.ttcn 6 files changed, 19 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/34838/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 426109a..57b44e0 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1129,16 +1129,6 @@ "sccp-timer iar " & int2str(g_bsc_sccp_timer_iar)}); } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - if (pt.checkstate("Mapped")) { - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); - } -} - private function f_sysinfo_seen(integer rsl_idx, RSL_Message rsl) runs on test_CT { if (rsl_idx >= lengthof(g_system_information)) { diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index c3849b8..4afb8dd 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -349,14 +349,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - function f_init_vty(charstring id := "foo") runs on test_CT { if (HNBGWVTY.checkstate("Mapped")) { /* skip initialization if already executed once */ diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 6d1ddc5..df7a04c 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -95,14 +95,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - function f_init_vty(charstring id := "foo") runs on test_CT { if (HNBVTY.checkstate("Mapped")) { /* skip initialization if already executed once */ diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index a448b8b..3dd0429 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -363,4 +363,14 @@ mtc.stop; } +public function f_logp(TELNETasp_PT pt, charstring log_msg) +{ + // log on TTCN3 log output + log(log_msg); + // log in stderr log + if (pt.checkstate("Mapped")) { + f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); + } +} + } diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn index 5324d1c..2a50666 100644 --- a/smlc/SMLC_Tests.ttcn +++ b/smlc/SMLC_Tests.ttcn @@ -156,14 +156,6 @@ } } -private function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - /* global initialization function * \param nr_bts Number of BTSs we should start/bring up * \param handler_mode Start an RSL_Emulation_CT component (true) or not (false). diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 7dc01bb..140e81b 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -68,14 +68,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - private function f_get_name_val(out charstring val, charstring str, charstring name, charstring sep := ":", charstring delim := " ") return boolean { var charstring labl := name & sep; var integer namepos := f_strstr(str, labl); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3 Gerrit-Change-Number: 34838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email ) Change subject: Introduce EPDG_Tests testsuite ...................................................................... Patch Set 6: (2 comments) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/13abdc4f_cb40… PS6, Line 231: /* TODO: maybe use, set to true */ > kept intentionally? the comment? yes, it's for next stages. File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/ce02fb50_9b7f… PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */ > do you want to keep the // lines in addition to the TODO comment below? I think it's fine for now, it helps people find the related templates/types. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Oct 2023 12:15:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat
by fixeria 20 Oct '23

20 Oct '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d Gerrit-Change-Number: 34837 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 10:36:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat
by osmith 20 Oct '23

20 Oct '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email to look at the new patch set (#2). Change subject: scripts/repo-install-test: fix sftp compat ...................................................................... scripts/repo-install-test: fix sftp compat When running scp, Debian 12 uses the SFTP protocol by default instead of the legacy SCP protocol. For some reason, this means it doesn't create the /repo-install-test directory inside QEMU: + … scp … -r scripts/repo-install-test root@127.0.0.1:/repo-install-test Warning: Permanently added '[127.0.0.1]:22793' (ED25519) to the list of known hosts. scp: realpath /repo-install-test: No such file scp: upload "/repo-install-test": path canonicalization failed scp: failed to upload directory scripts/repo-install-test to /repo-install-test Changing to the legacy protocol with "scp -O" would make it work again, but instead of doing that add the mkdir so it works with the new protocol too. Related: OS#6186 Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d --- M scripts/repo-install-test.sh 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/34837/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d Gerrit-Change-Number: 34837 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat
by osmith 20 Oct '23

20 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat ...................................................................... scripts/repo-install-test: fix sftp compat When running scp, Debian 12 uses the SFTP protocol by default instead of the legacy SCP protocol. For some reason, this means it doesn't create the /repo-install-test directory inside QEMU: + … scp … -r scripts/repo-install-test root@127.0.0.1:/repo-install-test Warning: Permanently added '[127.0.0.1]:22793' (ED25519) to the list of known hosts. scp: realpath /repo-install-test: No such file scp: upload "/repo-install-test": path canonicalization failed scp: failed to upload directory scripts/repo-install-test to /repo-install-test Changing to the legacy protocol with "scp -O" would make it work again, but instead of doing that add the mkdir so it works with the new protocol too. Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d --- M scripts/repo-install-test.sh 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/34837/1 diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 246d5e5..98f0176 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -153,6 +153,7 @@ EOF qemu_ssh rm -rf /repo-install-test/ + qemu_ssh mkdir /repo-install-test qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test" TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d Gerrit-Change-Number: 34837 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: scripts/tarballs: create release dir if missing
by osmith 20 Oct '23

20 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email ) Change subject: scripts/tarballs: create release dir if missing ...................................................................... scripts/tarballs: create release dir if missing Fix for: rsync: [Receiver] change_dir#3 "/downloads/home/releases/web-files/gapk" failed: No such file or directory (2) Change-Id: I46310d633302028d486dd356147c9c4f35b24940 --- M scripts/tarballs/publish-tarballs-for-tags.sh 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh b/scripts/tarballs/publish-tarballs-for-tags.sh index e3dbf5b..c185c21 100755 --- a/scripts/tarballs/publish-tarballs-for-tags.sh +++ b/scripts/tarballs/publish-tarballs-for-tags.sh @@ -290,6 +290,7 @@ return fi + $SSH_COMMAND releases(a)ftp.osmocom.org -- mkdir -p "$WEB_PATH/$repo" rsync -vz -e "$SSH_COMMAND" "$tarball_path" $tarball_path_remote } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I46310d633302028d486dd356147c9c4f35b24940 Gerrit-Change-Number: 34819 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: scripts/tarballs: create release dir if missing
by fixeria 20 Oct '23

20 Oct '23

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email ) Change subject: scripts/tarballs: create release dir if missing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I46310d633302028d486dd356147c9c4f35b24940 Gerrit-Change-Number: 34819 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 20 Oct 2023 10:02:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0