October 2023 - gerrit-log - lists.osmocom.org

[S] Change in libgtpnl[master]: README, debian/control: update URLs
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email ) Change subject: README, debian/control: update URLs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0 Gerrit-Change-Number: 34825 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: Use keyword argument for file description argument
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34814?usp=email ) Change subject: Use keyword argument for file description argument ...................................................................... Use keyword argument for file description argument While our base classes (TransparentEF / LinFixedEF) always have the dsecription as 4th argument after "fid, sfid, name", most of the derived file-specific classes do not share that same argument order. As seen in the bug fixed by previous Change-Id I7f32c9fd01094620b68b0e54536ecc6cdbe67903 this can have serious consequences. Let's avoid using unnamed (positional) arguments for the description text altogether. Change-Id: Icfb3fd1bae038c54fa14a91aa9f75219d839968c --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 73 insertions(+), 57 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 5afa2ef..54ff4c8 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1382,47 +1382,46 @@ EF_Keys('6f09', 0x09, 'EF.KeysPS', desc='Ciphering and Integrity Keys for PS domain'), EF_xPLMNwAcT('6f60', 0x0a, 'EF.PLMNwAcT', - 'User controlled PLMN Selector with Access Technology', service=20), + desc='User controlled PLMN Selector with Access Technology', service=20), EF_HPPLMN(), EF_ACMmax(service=13), EF_UST(), CyclicEF('6f39', None, 'EF.ACM', - 'Accumulated call meter', rec_len=(3, 3), service=13), - TransparentEF('6f3e', None, 'EF.GID1', 'Group Identifier Level 1', service=17), - TransparentEF('6f3f', None, 'EF.GID2', 'Group Identifier Level 2', service=18), + desc='Accumulated call meter', rec_len=(3, 3), service=13), + TransparentEF('6f3e', None, 'EF.GID1', desc='Group Identifier Level 1', service=17), + TransparentEF('6f3f', None, 'EF.GID2', desc='Group Identifier Level 2', service=18), EF_SPN(service=19), TransparentEF('6f41', None, 'EF.PUCT', - 'Price per unit and currency table', size=(5, 5), service=13), + desc='Price per unit and currency table', size=(5, 5), service=13), EF_CBMI(service=15), EF_ACC(sfid=0x06), - EF_PLMNsel('6f7b', 0x0d, 'EF.FPLMN', - 'Forbidden PLMNs', size=(12, None)), + EF_PLMNsel('6f7b', 0x0d, 'EF.FPLMN', desc='Forbidden PLMNs', size=(12, None)), EF_LOCI(), EF_AD(), EF_CBMID(sfid=0x0e, service=29), EF_ECC(), EF_CBMIR(service=16), EF_PSLOCI(), - EF_ADN('6f3b', None, 'EF.FDN', 'Fixed Dialling Numbers', service=[2, 89], ext=2), + EF_ADN('6f3b', None, 'EF.FDN', desc='Fixed Dialling Numbers', service=[2, 89], ext=2), EF_SMS('6f3c', None, service=10), EF_MSISDN(service=21), EF_SMSP(service=12), EF_SMSS(service=10), - EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', service=[4, 89], ext=3), - EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN)', service=3), - EF_EXT('6f4c', None, 'EF.EXT3', 'Extension2 (SDN)', service=5), + EF_ADN('6f49', None, 'EF.SDN', desc='Service Dialling Numbers', service=[4, 89], ext=3), + EF_EXT('6f4b', None, 'EF.EXT2', desc='Extension2 (FDN)', service=3), + EF_EXT('6f4c', None, 'EF.EXT3', desc='Extension2 (SDN)', service=5), EF_SMSR(service=11), EF_ICI(service=9), EF_OCI(service=8), EF_ICT(service=9), - EF_ICT('6f83', None, 'EF.OCT', 'Outgoing Call Timer', service=8), - EF_EXT('6f4e', None, 'EF.EXT5', 'Extension5 (ICI/OCI/MSISDN)', service=44), + EF_ICT('6f83', None, 'EF.OCT', desc='Outgoing Call Timer', service=8), + EF_EXT('6f4e', None, 'EF.EXT5', desc='Extension5 (ICI/OCI/MSISDN)', service=44), EF_CCP2(service=14), EF_eMLPP(service=24), EF_AAeM(service=25), # EF_Hiddenkey - EF_ADN('6f4d', None, 'EF.BDN', 'Barred Dialling Numbers', service=6, ext=4), - EF_EXT('6f55', None, 'EF.EXT4', 'Extension4 (BDN/SSC)', service=7), + EF_ADN('6f4d', None, 'EF.BDN', desc='Barred Dialling Numbers', service=6, ext=4), + EF_EXT('6f55', None, 'EF.EXT4', desc='Extension4 (BDN/SSC)', service=7), EF_CMI(service=6), EF_EST(service=[2, 6, 34, 35]), EF_ACL(service=35), @@ -1430,52 +1429,52 @@ EF_CNL(service=37), EF_START_HFN(), EF_THRESHOLD(), - EF_xPLMNwAcT('6f61', 0x11, 'EF.OPLMNwAcT', 'User controlled PLMN Selector with Access Technology', service=42), - EF_xPLMNwAcT('6f62', 0x13, 'EF.HPLMNwAcT', 'HPLMN Selector with Access Technology', service=43), + EF_xPLMNwAcT('6f61', 0x11, 'EF.OPLMNwAcT', desc='User controlled PLMN Selector with Access Technology', service=42), + EF_xPLMNwAcT('6f62', 0x13, 'EF.HPLMNwAcT', desc='HPLMN Selector with Access Technology', service=43), EF_ARR('6f06', 0x17), EF_RPLMNAcT(), - TransparentEF('6fc4', None, 'EF.NETPAR', 'Network Parameters'), + TransparentEF('6fc4', None, 'EF.NETPAR', desc='Network Parameters'), EF_PNN('6fc5', 0x19, service=45), EF_OPL(service=46), - EF_ADN('6fc7', None, 'EF.MBDN', 'Mailbox Dialling Numbers', service=47, ext=6), - EF_EXT('6fc8', None, 'EF.EXT6', 'Extension6 (MBDN)'), + EF_ADN('6fc7', None, 'EF.MBDN', desc='Mailbox Dialling Numbers', service=47, ext=6), + EF_EXT('6fc8', None, 'EF.EXT6', desc='Extension6 (MBDN)'), EF_MBI(service=47), EF_MWIS(service=48), - EF_ADN('6fcb', None, 'EF.CFIS', 'Call Forwarding Indication Status', service=49, ext=7), - EF_EXT('6fcc', None, 'EF.EXT7', 'Extension7 (CFIS)'), - TransparentEF('6fcd', None, 'EF.SPDI', 'Service Provider Display Information', service=51), + EF_ADN('6fcb', None, 'EF.CFIS', desc='Call Forwarding Indication Status', service=49, ext=7), + EF_EXT('6fcc', None, 'EF.EXT7', desc='Extension7 (CFIS)'), + TransparentEF('6fcd', None, 'EF.SPDI', desc='Service Provider Display Information', service=51), EF_MMSN(service=52), - EF_EXT('6fcf', None, 'EF.EXT8', 'Extension8 (MMSN)', service=53), + EF_EXT('6fcf', None, 'EF.EXT8', desc='Extension8 (MMSN)', service=53), EF_MMSICP(service=52), EF_MMSUP(service=52), EF_MMSUCP(service=(52, 55)), EF_NIA(service=56, fid='6fd3'), EF_VGCS(service=57), EF_VGCSS(service=57), - EF_VGCS('6fb3', None, 'EF.VBS', 'Voice Broadcast Service', service=58), - EF_VGCSS('6fb4', None, 'EF.VBSS', 'Voice Broadcast Service Status', service=58), + EF_VGCS('6fb3', None, 'EF.VBS', desc='Voice Broadcast Service', service=58), + EF_VGCSS('6fb4', None, 'EF.VBSS', desc='Voice Broadcast Service Status', service=58), EF_VGCSCA(service=64), - EF_VGCSCA('6fd5', None, 'EF.VBCSCA', 'Voice Broadcast Service Ciphering Algorithm', service=65), + EF_VGCSCA('6fd5', None, 'EF.VBCSCA', desc='Voice Broadcast Service Ciphering Algorithm', service=65), EF_GBABP(service=68), EF_MSK(service=69), EF_MUK(service=69), EF_GBANL(service=68), - EF_PLMNsel('6fd9', 0x1d, 'EF.EHPLMN', 'Equivalent HPLMN', size=(12, None), service=71), + EF_PLMNsel('6fd9', 0x1d, 'EF.EHPLMN', desc='Equivalent HPLMN', size=(12, None), service=71), EF_EHPLMNPI(service=(71, 73)), # EF_LRPLMNSI ('6fdc', service=74) EF_NAFKCA(service=(68, 76)), - TransparentEF('6fde', None, 'EF.SPNI', 'Service Provider Name Icon', service=78), - LinFixedEF('6fdf', None, 'EF.PNNI', 'PLMN Network Name Icon', service=79), + TransparentEF('6fde', None, 'EF.SPNI', desc='Service Provider Name Icon', service=78), + LinFixedEF('6fdf', None, 'EF.PNNI', desc='PLMN Network Name Icon', service=79), EF_NCP_IP(service=80), - EF_EPSLOCI('6fe3', 0x1e, 'EF.EPSLOCI', 'EPS location information', service=85), + EF_EPSLOCI('6fe3', 0x1e, 'EF.EPSLOCI', desc='EPS location information', service=85), EF_EPSNSC(service=85), - TransparentEF('6fe6', None, 'EF.UFC', 'USAT Facility Control', size=(1, 16)), - TransparentEF('6fe8', None, 'EF.NASCONFIG', 'Non Access Stratum Configuration', service=96), + TransparentEF('6fe6', None, 'EF.UFC', desc='USAT Facility Control', size=(1, 16)), + TransparentEF('6fe8', None, 'EF.NASCONFIG', desc='Non Access Stratum Configuration', service=96), # UICC IARI (only in cards that have no ISIM) service=95 EF_PWS(service=97), - LinFixedEF('6fed', None, 'EF.FDNURI', 'Fixed Dialling Numbers URI', service=(2, 99)), - LinFixedEF('6fee', None, 'EF.BDNURI', 'Barred Dialling Numbers URI', service=(6, 99)), - LinFixedEF('6fef', None, 'EF.SDNURI', 'Service Dialling Numbers URI', service=(4, 99)), + LinFixedEF('6fed', None, 'EF.FDNURI', desc='Fixed Dialling Numbers URI', service=(2, 99)), + LinFixedEF('6fee', None, 'EF.BDNURI', desc='Barred Dialling Numbers URI', service=(6, 99)), + LinFixedEF('6fef', None, 'EF.SDNURI', desc='Service Dialling Numbers URI', service=(4, 99)), # EF_IWL (IMEI(SV) White List) EF_IPS(), EF_ePDGId(service=(106, 107)), diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index d8cbabd..14db686 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -927,32 +927,32 @@ EF_Kc(), EF_PLMNsel(), TransparentEF('6f31', None, 'EF.HPPLMN', - 'Higher Priority PLMN search period'), + desc='Higher Priority PLMN search period'), EF_ACMmax(), EF_ServiceTable('6f38', None, 'EF.SST', - 'SIM service table', table=EF_SST_map, size=(2, 16)), + desc='SIM service table', table=EF_SST_map, size=(2, 16)), CyclicEF('6f39', None, 'EF.ACM', - 'Accumulated call meter', rec_len=(3, 3)), - TransparentEF('6f3e', None, 'EF.GID1', 'Group Identifier Level 1'), - TransparentEF('6f3f', None, 'EF.GID2', 'Group Identifier Level 2'), + desc='Accumulated call meter', rec_len=(3, 3)), + TransparentEF('6f3e', None, 'EF.GID1', desc='Group Identifier Level 1'), + TransparentEF('6f3f', None, 'EF.GID2', desc='Group Identifier Level 2'), EF_SPN(), TransparentEF('6f41', None, 'EF.PUCT', - 'Price per unit and currency table', size=(5, 5)), + desc='Price per unit and currency table', size=(5, 5)), EF_CBMI(), TransparentEF('6f74', None, 'EF.BCCH', - 'Broadcast control channels', size=(16, 16)), + desc='Broadcast control channels', size=(16, 16)), EF_ACC(), EF_PLMNsel('6f7b', None, 'EF.FPLMN', - 'Forbidden PLMNs', size=(12, 12)), + desc='Forbidden PLMNs', size=(12, 12)), EF_LOCI(), EF_AD(), TransparentEF('6fae', None, 'EF.Phase', - 'Phase identification', size=(1, 1)), + desc='Phase identification', size=(1, 1)), EF_VGCS(), EF_VGCSS(), - EF_VGCS('6fb3', None, 'EF.VBS', 'Voice Broadcast Service'), + EF_VGCS('6fb3', None, 'EF.VBS', desc='Voice Broadcast Service'), EF_VGCSS('6fb4', None, 'EF.VBSS', - 'Voice Broadcast Service Status'), + desc='Voice Broadcast Service Status'), EF_eMLPP(), EF_AAeM(), EF_CBMID(), @@ -961,29 +961,29 @@ EF_DCK(), EF_CNL(), EF_NIA(), - EF_Kc('6f52', None, 'EF.KcGPRS', 'GPRS Ciphering key KcGPRS'), + EF_Kc('6f52', None, 'EF.KcGPRS', desc='GPRS Ciphering key KcGPRS'), EF_LOCIGPRS(), - TransparentEF('6f54', None, 'EF.SUME', 'SetUpMenu Elements'), + TransparentEF('6f54', None, 'EF.SUME', desc='SetUpMenu Elements'), EF_xPLMNwAcT('6f60', None, 'EF.PLMNwAcT', - 'User controlled PLMN Selector with Access Technology'), + desc='User controlled PLMN Selector with Access Technology'), EF_xPLMNwAcT('6f61', None, 'EF.OPLMNwAcT', - 'Operator controlled PLMN Selector with Access Technology'), + desc='Operator controlled PLMN Selector with Access Technology'), EF_xPLMNwAcT('6f62', None, 'EF.HPLMNwAcT', - 'HPLMN Selector with Access Technology'), + desc='HPLMN Selector with Access Technology'), EF_CPBCCH(), EF_InvScan(), EF_PNN(), EF_OPL(), - EF_ADN('6fc7', None, 'EF.MBDN', 'Mailbox Dialling Numbers'), + EF_ADN('6fc7', None, 'EF.MBDN', desc='Mailbox Dialling Numbers'), EF_MBI(), EF_MWIS(), EF_ADN('6fcb', None, 'EF.CFIS', - 'Call Forwarding Indication Status'), - EF_EXT('6fc8', None, 'EF.EXT6', 'Externsion6 (MBDN)'), - EF_EXT('6fcc', None, 'EF.EXT7', 'Externsion7 (CFIS)'), + desc='Call Forwarding Indication Status'), + EF_EXT('6fc8', None, 'EF.EXT6', desc='Externsion6 (MBDN)'), + EF_EXT('6fcc', None, 'EF.EXT7', desc='Externsion7 (CFIS)'), EF_SPDI(), EF_MMSN(), - EF_EXT('6fcf', None, 'EF.EXT8', 'Extension8 (MMSN)'), + EF_EXT('6fcf', None, 'EF.EXT8', desc='Extension8 (MMSN)'), EF_MMSICP(), EF_MMSUP(), EF_MMSUCP(), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfb3fd1bae038c54fa14a91aa9f75219d839968c Gerrit-Change-Number: 34814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: ts_31_102: Fix initialization of file size
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34813?usp=email ) Change subject: ts_31_102: Fix initialization of file size ...................................................................... ts_31_102: Fix initialization of file size We were using positional arguments when instantiating instances of classes like EF_5GS3GPPLOCI with non-default names/fids/... However, we got the argument order wrong and were passing the description string in the position of the file size, which causes exceptions like the following from pySim-trace: Traceback (most recent call last): File "/home/laforge/projects/git/pysim/./pySim-trace.py", line 198, in <module> tracer.main() File "/home/laforge/projects/git/pysim/./pySim-trace.py", line 125, in main inst.process(self.rs) File "/home/laforge/projects/git/pysim/pySim/apdu/__init__.py", line 259, in process self.processed = method(self.lchan) File "/home/laforge/projects/git/pysim/pySim/apdu/ts_102_221.py", line 152, in process_on_lchan if self.cmd_dict['offset'] != 0 or self.lr < self.file.size[0]: TypeError: '<' not supported between instances of 'int' and 'str' Let's use named initializers for any arguments after the usual "fid, sfid, name" initial arguments. Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903 --- M pySim/ts_31_102.py 1 file changed, 33 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index c7a58f1..5afa2ef 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1331,10 +1331,10 @@ # I'm looking at 31.102 R16.6 EF_5GS3GPPLOCI(service=122), EF_5GS3GPPLOCI('4f02', 0x02, 'EF.5GSN3GPPLOCI', - '5GS non-3GPP location information', service=122), + desc='5GS non-3GPP location information', service=122), EF_5GS3GPPNSC(service=122), EF_5GS3GPPNSC('4f04', 0x04, 'EF.5GSN3GPPNSC', - '5GS non-3GPP Access NAS Security Context', service=122), + desc='5GS non-3GPP Access NAS Security Context', service=122), EF_5GAUTHKEYS(service=123), EF_UAC_AIC(service=126), EF_SUCI_Calc_Info(service=124), @@ -1342,7 +1342,7 @@ EF_SUPI_NAI(service=130), EF_Routing_Indicator(service=124), TransparentEF('4F0B', 0x0b, 'EF.URSP', - 'UE Route Selector Policies per PLMN', service=132), + desc='UE Route Selector Policies per PLMN', service=132), EF_TN3GPPSNN(service=133), # Rel-17 additions below EF_CAG(service=137), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903 Gerrit-Change-Number: 34813 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: ts_31_102: Fix initialization of file size
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34813?usp=email ) Change subject: ts_31_102: Fix initialization of file size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903 Gerrit-Change-Number: 34813 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: Use keyword argument for file description argument
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34814?usp=email ) Change subject: Use keyword argument for file description argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfb3fd1bae038c54fa14a91aa9f75219d839968c Gerrit-Change-Number: 34814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:47:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
by daniel 20 Oct '23

20 Oct '23

Attention is currently required from: arehbein, laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 5: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/d4de8de3_f6d6e4ca PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); This will leak iofds returned by osmo_iofd_setup(). Also having a read_cb() will cause (de-)allocations for each message, which will impact performance. Maybe the sink should stay a struct osmo_fd? The alternative would be to simply never read from that fd and just keep it open there so no ICMP errors are sent. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix whitespace
by pespin 20 Oct '23

20 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email ) Change subject: diameter_3gpp_ts29_273_swx.dia: Fix whitespace ...................................................................... diameter_3gpp_ts29_273_swx.dia: Fix whitespace Change-Id: I2966070ee1bd7709565ab7b568ae6f23a3b6954f --- M dia/diameter_3gpp_ts29_273_swx.dia 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/42/34842/1 diff --git a/dia/diameter_3gpp_ts29_273_swx.dia b/dia/diameter_3gpp_ts29_273_swx.dia index d6f91da..d6d446c 100644 --- a/dia/diameter_3gpp_ts29_273_swx.dia +++ b/dia/diameter_3gpp_ts29_273_swx.dia @@ -33,7 +33,6 @@ @vendor 10415 3GPP @inherits diameter_gen_base_rfc6733 - @inherits diameter_3gpp_base @inherits diameter_3gpp_break_circles @inherits diameter_3gpp_ts29_212 @@ -113,7 +112,7 @@ *[ Supported-Features ] *[ AVP ] -;; 8.2.2.2 Push-Profile-Answer +;; 8.2.2.2 Push-Profile-Answer PPA ::= < Diameter Header: 305, PXY > < Session-Id > { Auth-Session-State } -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2966070ee1bd7709565ab7b568ae6f23a3b6954f Gerrit-Change-Number: 34842 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by pespin 20 Oct '23

20 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email ) Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Makefile: run 'rebar3 clean' upon make clean Otherwise the diameter files generated during compile in include/ and src/ are not removed. Change-Id: I771860f965499bb754c13385819845ef23f33553 --- M Makefile 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/41/34841/1 diff --git a/Makefile b/Makefile index b2fe66f..5ef1f58 100644 --- a/Makefile +++ b/Makefile @@ -14,4 +14,5 @@ rebar3 eunit clean: + rebar3 clean rm -rf _build/ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libgtpnl[master]: include/linux/gtp.h: fix GTPA_MAX
by pablo 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. pablo has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email ) Change subject: include/linux/gtp.h: fix GTPA_MAX ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa Gerrit-Change-Number: 34828 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 16:46:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master b...
by pespin 20 Oct '23

20 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email ) Change subject: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master branch ...................................................................... Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master branch The repository branches were rebased and rearranged, where now its master branch follows upstream, and we keep an osmocom/master branch with our own patches (Osmux, not aimed at upstream) which can then be rebased on top of master. Related: OS#6011 Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94 --- M deps/Makefile 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index bd6ce8a..c6031cb 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -89,7 +89,7 @@ titan.ProtocolEmulations.SCCP_commit= f8a44f2cdef44d0c3adf787ab3184c293a9a58be titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a -titan.ProtocolModules.BSSMAP_commit= 814c5d786ab633bce384eea99685f0e49a386172 +titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 titan.ProtocolModules.GTP_v13.5.0_commit= 54219599037626c675610d3a44433d01af264fbb -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94 Gerrit-Change-Number: 34823 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0