October 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim-shell: do not fail when EF.ICCID does not exist
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34768?usp=email ) Change subject: pySim-shell: do not fail when EF.ICCID does not exist ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8d18c5073946c5a6bb1f93be0ce692a599f46f8c Gerrit-Change-Number: 34768 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgtpnl[master]: Use struct gtp_addr for ms_addr and sgsn_addr
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email ) Change subject: Use struct gtp_addr for ms_addr and sgsn_addr ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e Gerrit-Change-Number: 34734 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:50:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgtpnl[master]: include/linux/gtp.h: sync with kernel header
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email ) Change subject: include/linux/gtp.h: sync with kernel header ...................................................................... include/linux/gtp.h: sync with kernel header Make the file exactly the same as include/uapi/linux/gtp.h in linux.git. GTPA_SGSN_ADDRESS is not used, but we decided to rather add it and not have a diff. Related: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/909c69a6_2fe7781a/ Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594 --- M include/linux/gtp.h 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/linux/gtp.h b/include/linux/gtp.h index 5d37b1c..3dcdb9e 100644 --- a/include/linux/gtp.h +++ b/include/linux/gtp.h @@ -1,10 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ #ifndef _UAPI_LINUX_GTP_H_ -#define _UAPI_LINUX_GTP_H__ +#define _UAPI_LINUX_GTP_H_ + +#define GTP_GENL_MCGRP_NAME "gtp" enum gtp_genl_cmds { GTP_CMD_NEWPDP, GTP_CMD_DELPDP, GTP_CMD_GETPDP, + GTP_CMD_ECHOREQ, GTP_CMD_MAX, }; @@ -19,7 +23,8 @@ GTPA_LINK, GTPA_VERSION, GTPA_TID, /* for GTPv0 only */ - GTPA_PEER_ADDRESS, + GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */ +#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */ GTPA_MS_ADDRESS, GTPA_FLOW, GTPA_NET_NS_FD, -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594 Gerrit-Change-Number: 34829 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libgtpnl[master]: include/linux/gtp.h: fix GTPA_MAX
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email ) Change subject: include/linux/gtp.h: fix GTPA_MAX ...................................................................... include/linux/gtp.h: fix GTPA_MAX Apply same fix as done by Pablo in linux.git: > Subtract one to __GTPA_MAX, otherwise GTPA_MAX is off by 2 Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa --- M include/linux/gtp.h 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve pablo: Looks good to me, approved diff --git a/include/linux/gtp.h b/include/linux/gtp.h index c525cb3..5d37b1c 100644 --- a/include/linux/gtp.h +++ b/include/linux/gtp.h @@ -28,6 +28,6 @@ GTPA_PAD, __GTPA_MAX, }; -#define GTPA_MAX (__GTPA_MAX + 1) +#define GTPA_MAX (__GTPA_MAX - 1) #endif /* _UAPI_LINUX_GTP_H_ */ -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa Gerrit-Change-Number: 34828 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libgtpnl[master]: configure: add --enable-werror
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email ) Change subject: configure: add --enable-werror ...................................................................... configure: add --enable-werror Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a --- M configure.ac 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index e7d9888..a16f40b 100644 --- a/configure.ac +++ b/configure.ac @@ -53,6 +53,25 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + AC_SUBST([CPPFLAGS]) AC_SUBST([CFLAGS]) AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc]) -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a Gerrit-Change-Number: 34827 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libgtpnl[master]: configure: regular_C(PP)FLAGS -> C(PP)FLAGS
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email ) Change subject: configure: regular_C(PP)FLAGS -> C(PP)FLAGS ...................................................................... configure: regular_C(PP)FLAGS -> C(PP)FLAGS Make it consistent with other Osmocom projects by removing special naming for CFLAGS and CPPFLAGS. Otherwise the arguments we typically add, such as --enable-sanitize which is already there, or --enable-werror which I'll add in the next patch, do not work without further changes. Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7 --- M Make_global.am M configure.ac 2 files changed, 24 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/Make_global.am b/Make_global.am index f2cb36c..9a3d5b2 100644 --- a/Make_global.am +++ b/Make_global.am @@ -1,2 +1,2 @@ -AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS} -AM_CFLAGS = ${regular_CFLAGS} ${GCC_FVISIBILITY_HIDDEN} +AM_CPPFLAGS = ${CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS} +AM_CFLAGS = ${CFLAGS} ${GCC_FVISIBILITY_HIDDEN} diff --git a/configure.ac b/configure.ac index eb35f57..e7d9888 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,11 @@ AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([foreign tar-pax no-dist-gzip dist-bzip2 1.6 subdir-objects]) +CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64 -D_REENTRANT" +CFLAGS="$CFLAGS -Wall -Waggregate-return -Wmissing-declarations \ + -Wmissing-prototypes -Wshadow -Wstrict-prototypes \ + -Wformat=2 -pipe" + dnl include release helper RELMAKE='-include osmo-release.mk' AC_SUBST([RELMAKE]) @@ -48,12 +53,8 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi -regular_CPPFLAGS="-D_FILE_OFFSET_BITS=64 -D_REENTRANT" -regular_CFLAGS="-Wall -Waggregate-return -Wmissing-declarations \ - -Wmissing-prototypes -Wshadow -Wstrict-prototypes \ - -Wformat=2 -pipe" -AC_SUBST([regular_CPPFLAGS]) -AC_SUBST([regular_CFLAGS]) +AC_SUBST([CPPFLAGS]) +AC_SUBST([CFLAGS]) AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc]) AC_OUTPUT( contrib/libgtpnl.spec) -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7 Gerrit-Change-Number: 34826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libgtpnl[master]: README, debian/control: update URLs
by laforge 20 Oct '23

20 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email ) Change subject: README, debian/control: update URLs ...................................................................... README, debian/control: update URLs Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0 --- M README.md M debian/control 2 files changed, 14 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/README.md b/README.md index 5d3b5bf..95ad1ac 100644 --- a/README.md +++ b/README.md @@ -20,9 +20,9 @@ You can clone from the official libgtpnl.git repository using - git clone git://git.osmocom.org/libgtpnl.git + git clone https://gitea.osmocom.org/cellular-infrastructure/libgtpnl -There is a cgit interface at <http://git.osmocom.org/libgtpnl/> +Visiting the URL in a browser shows a web interface. Mailing List ------------ diff --git a/debian/control b/debian/control index a24564e..17a8649 100644 --- a/debian/control +++ b/debian/control @@ -12,9 +12,9 @@ pkg-config, libmnl-dev Standards-Version: 3.9.8 -Vcs-Git: git://git.osmocom.org/libgtpnl.git -Vcs-Browser: http://git.osmocom.org/gitweb?p=libgtpnl.git;a=summary -Homepage: https://projects.osmocom.org/projects/openggsn +Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/libgtpnl +Vcs-Browser: https://gitea.osmocom.org/cellular-infrastructure/libgtpnl +Homepage: https://osmocom.org/projects/linux-kernel-gtp-u/wiki/Libgtpnl Package: libgtpnl0 Section: libs -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0 Gerrit-Change-Number: 34825 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libgtpnl[master]: include/linux/gtp.h: sync with kernel header
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email ) Change subject: include/linux/gtp.h: sync with kernel header ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594 Gerrit-Change-Number: 34829 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgtpnl[master]: configure: add --enable-werror
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email ) Change subject: configure: add --enable-werror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a Gerrit-Change-Number: 34827 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgtpnl[master]: configure: regular_C(PP)FLAGS -> C(PP)FLAGS
by laforge 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email ) Change subject: configure: regular_C(PP)FLAGS -> C(PP)FLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7 Gerrit-Change-Number: 34826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0