October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
by pespin 20 Oct '23

20 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ...................................................................... GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 --- M library/GTPv2_Templates.ttcn 1 file changed, 20 insertions(+), 11 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index e5022d8..753774d 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -740,38 +740,38 @@ template (present) PDU_GTPCv2 -tr_GTP2C_CreateSessionReq(template (present) hexstring imsi) := +tr_GTP2C_CreateSessionReq(template (present) hexstring imsi := ?, template (present) octetstring apn := ?) := tr_PDU_GTP2C('00000000'O, ?, { createSessionRequest := { iMSI := tr_GTP2C_Imsi(imsi), mSISDN := *, mEI := *, - userLocationInfo := ?, - servingNetwork := ?, - rAT_Type := tr_GTP2C_RatType(6), + userLocationInfo := *, + servingNetwork := *, + rAT_Type := tr_GTP2C_RatType(?), indication := *, fullyQualifiedTEID := ?, - accessPointName := tr_GTP2C_APN('012a'O), // '*' + accessPointName := tr_GTP2C_APN(apn), // '*' selectionMode := ?, - pDN_Type := ?, + pDN_Type := *, pDN_AddressAllocation := ?, - maxAPN_Restriction := ?, + maxAPN_Restriction := *, ambr := *, linkedEPS_Bearer_ID := omit, trustedWLANModeIndication := omit, protocolConfigOptions := omit, bearerContextGrouped := ?, traceInformation := *, - recovery := omit, + recovery := *, csid := omit, - uE_TimeZone := ?, + uE_TimeZone := *, user_CSG_Information := omit, - chargingCharacteristics := ?, + chargingCharacteristics := *, lDN := omit, signallingPriorityIndication := *, iP_Addr := omit, portNumber := omit, - aPCO := omit, + aPCO := *, trustedWLANAccessNetworkIdentifier := omit, cNOperatorSelectionEntity := omit, presenceReportingAreaInformation := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 Gerrit-Change-Number: 34822 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Fix tr_GSUP_IMSI params
by pespin 20 Oct '23

20 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: GSUP_Types: Fix tr_GSUP_IMSI params ...................................................................... GSUP_Types: Fix tr_GSUP_IMSI params Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892 --- M library/GSUP_Types.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index ef98175..739dcbc 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -507,7 +507,7 @@ ies := ies } -template GSUP_PDU tr_GSUP_IMSI(template GSUP_MessageType msgt := ?, template hexstring imsi) := { +template (present) GSUP_PDU tr_GSUP_IMSI(template (present) GSUP_MessageType msgt := ?, template (present) hexstring imsi := ?) := { msg_type := msgt, ies := { tr_GSUP_IE_IMSI(imsi), * } } @@ -715,7 +715,7 @@ } } -template GSUP_IE tr_GSUP_IE_IMSI(template hexstring imsi) := { +template (present) GSUP_IE tr_GSUP_IE_IMSI(template (present) hexstring imsi := ?) := { tag := OSMO_GSUP_IMSI_IE, len := ?, val := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892 Gerrit-Change-Number: 34831 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email ) Change subject: Introduce EPDG_Tests testsuite ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Oct 2023 12:24:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File scripts/repo-install-test.sh: https://gerrit.osmocom.org/c/osmo-ci/+/34837/comment/f296bbec_e12ba1db PS2, Line 156: qemu_ssh mkdir /repo-install-test You could probably do it in one command to save some time, but it's fine otherwise. qemu_ssh /bin/sh -c "rm -rf /repo-install-test/ && mkdir /repo-install-test" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d Gerrit-Change-Number: 34837 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Oct 2023 12:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite
by osmith 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email ) Change subject: Introduce EPDG_Tests testsuite ...................................................................... Patch Set 7: Code-Review+1 (5 comments) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/65775eb5_d730… PS6, Line 19: swtrongswan > strongswan Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/543cc28c_1132… PS6, Line 216: watchdong > watchdog Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/42a264dd_aba7… PS6, Line 231: /* TODO: maybe use, set to true */ > the comment? yes, it's for next stages. Ack File epdg/gen_links.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/e0087b88_0877… PS6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc" > commented out FILES here looks like left-overs that should be removed? Done File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/1c577b62_63ee… PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */ > I think it's fine for now, it helps people find the related templates/types. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Oct 2023 12:21:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: Fix match of 15-digit IMSIs
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GTPv2: Fix match of 15-digit IMSIs ...................................................................... GTPv2: Fix match of 15-digit IMSIs 15-digit IMSIs are len(imsi)=15, but decoded messages are octet-aligned, hence the hexstring in messages is len(imsi)=16, where the last hex char is a padding 'F'H. * Make sure IMSIs stored in GTPv2_Emulation are padded to 16 digits (8 octets) to process matches easily. * Update tr_ template to transparently adapt passed hexstrings to match the octet-aligned value received from the wire. Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e --- M library/GTPv2_Emulation.ttcn M library/GTPv2_Templates.ttcn M library/Osmocom_Types.ttcn 3 files changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/34821/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e Gerrit-Change-Number: 34821 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix sveral wrong ElementIdentifier
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GTPv2_Templates: Fix sveral wrong ElementIdentifier ...................................................................... GTPv2_Templates: Fix sveral wrong ElementIdentifier Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1 --- M library/GTPv2_Templates.ttcn 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/34820/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1 Gerrit-Change-Number: 34820 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Introduce EPDG_Tests testsuite ...................................................................... Introduce EPDG_Tests testsuite Relted: OS#6204 Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 --- M Makefile A epdg/EPDG_Tests.cfg A epdg/EPDG_Tests.default A epdg/EPDG_Tests.ttcn A epdg/gen_links.sh A epdg/regen_makefile.sh M library/DIAMETER_Templates.ttcn M library/GSUP_Types.ttcn 8 files changed, 746 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/34778/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171 Gerrit-Change-Number: 34778 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add EDPG_Tunnel messages
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, lynxis lazus, osmith, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: GSUP_Types: Add EDPG_Tunnel messages ...................................................................... GSUP_Types: Add EDPG_Tunnel messages Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5 --- M library/GSUP_Types.ttcn 1 file changed, 40 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/34832/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5 Gerrit-Change-Number: 34832 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Fix tr_GSUP_IMSI params
by pespin 20 Oct '23

20 Oct '23

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GSUP_Types: Fix tr_GSUP_IMSI params ...................................................................... GSUP_Types: Fix tr_GSUP_IMSI params Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892 --- M library/GSUP_Types.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/34831/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892 Gerrit-Change-Number: 34831 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0