October 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: Makefile: Add shell target
by pespin 19 Oct '23

19 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34805?usp=email ) Change subject: Makefile: Add shell target ...................................................................... Makefile: Add shell target Change-Id: Icec3e92c4597d73f141c6ba669e8d9d07ec2e220 --- M Makefile 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile index 5b2196e..b2fe66f 100644 --- a/Makefile +++ b/Makefile @@ -7,6 +7,9 @@ run: build ERL_FLAGS='-config config/sys.config' _build/default/bin/osmo-epdg +shell: build + rebar3 shell --config ./config/sys.config + check: rebar3 eunit -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Icec3e92c4597d73f141c6ba669e8d9d07ec2e220 Gerrit-Change-Number: 34805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: diameter_swx: Fix MAA and SAA parsing mixed
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email ) Change subject: diameter_swx: Fix MAA and SAA parsing mixed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I570dd7c0ae521ccaea5fceb7eef90b4975cb0fbc Gerrit-Change-Number: 34783 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:50:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgtpnl[master]: gitignore: add gtp-link, gtp-tunnel
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34824?usp=email ) Change subject: gitignore: add gtp-link, gtp-tunnel ...................................................................... gitignore: add gtp-link, gtp-tunnel Change-Id: I9f9c9f64d96e25d99c5631ec40c1439f76678905 --- M .gitignore 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 738b3c4..bf5732d 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,6 @@ debian/libgtpnl0 contrib/libgtpnl.spec + +tools/gtp-link +tools/gtp-tunnel -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9f9c9f64d96e25d99c5631ec40c1439f76678905 Gerrit-Change-Number: 34824 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: Add IPv6 support ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:43:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by osmith 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: Add IPv6 support ...................................................................... Patch Set 2: (4 comments) File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/b087f34e_d39e33cb PS2, Line 60: } > default: assert() Done https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/c350bc50_b555d079 PS2, Line 69: } > default: assert() Done https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/f1d30c8a_29d582ee PS2, Line 239: switch (pdp.ms_addr.family) { > All this can simply be: […] oh right, nice! :D https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/38353512_cb43cd01 PS2, Line 249: switch (pdp.sgsn_addr.family) { > inet_ntop(pdp.sgsn_addr.family, &pdp.sgsn_addr. […] Done -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by osmith 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add IPv6 support ...................................................................... Add IPv6 support Implement IPv6 in libgtpnl and the gtp-tunnel testing tool. Allow to combine: - GTPA_MS_ADDRESS and GTPA_PEER_ADDR6 - GTPA_MS_ADDR6 and GTPA_PEER_ADDRESS to specify IPv4-in-IPv6-GTP and IPv6-in-IPv4-GTP in the tunnel declaration from control plane. This patch is based on multiple patches from Pablo in OS#6123. I decided to squash them to directly implement v4-in-v6 and vice versa, instead of implementing another variant first and then changing it again. Co-developed-by: Pablo Neira Ayuso <pablo(a)netfilter.org> Related: OS#6096 Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b --- M include/libgtpnl/gtp.h M include/linux/gtp.h M src/gtp-genl.c M src/gtp.c M src/libgtpnl.map M tools/gtp-tunnel.c 6 files changed, 146 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/35/34735/3 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: ASCI: Reject TERMINATION, if MS is not the originator
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email ) Change subject: ASCI: Reject TERMINATION, if MS is not the originator ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibe289920fa3ea50dd3e7d5c1371456dca9b72604 Gerrit-Change-Number: 34830 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:42:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email ) Change subject: ASCI: Add System Information 10 support ...................................................................... Patch Set 6: (4 comments) File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/3a994631_16e74711 PS6, Line 1420: int gsm_generate_si10(uint8_t *data, size_t len, const struct gsm_subscriber_connection *conn) "struct gsm48_system_information_type_10 *data" ? https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/6aaafb03_f812b8ce PS6, Line 1424: struct gsm_bts *s_bts = conn->lchan->ts->trx->bts; Can conn->lchan be null? OSMO_ASSERT(conn && conn->lchan) perhaps? File src/osmo-bsc/vgcs_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/5ca286d7_976722cb PS6, Line 70: #define SI10_TIMER 3, 0 AFAIU this is no longer used. https://gerrit.osmocom.org/c/osmo-bsc/+/34626/comment/982f534c_2e5f996c PS6, Line 71: #define SI10_LENGTH 21 this length should be in the same header where the API is used, and probably be documented in the API that the data buf should be at least this size. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:38:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: Add IPv6 support ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/10e8a343_fd652bb7 PS2, Line 60: } default: assert() https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/696be098_103d2406 PS2, Line 69: } default: assert() https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/2c28aec1_c99fa3a7 PS2, Line 239: switch (pdp.ms_addr.family) { All this can simply be: inet_ntop(pdp.ms_addr.family, &pdp.ms_addr.ip4, buf, sizeof(buf)); https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/15e9f1bb_e05a5cec PS2, Line 249: switch (pdp.sgsn_addr.family) { inet_ntop(pdp.sgsn_addr.family, &pdp.sgsn_addr.ip4, buf, sizeof(buf)); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by osmith 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email ) Change subject: Add IPv6 support ...................................................................... Patch Set 2: (1 comment) File src/gtp-genl.c: https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/b6c8c366_6dac6244 PS1, Line 220: } > "default: return MNL_CB_ERROR;" ? Done -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:26:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0