October 2023 - gerrit-log - lists.osmocom.org

[S] Change in libgtpnl[master]: gitignore: add gtp-link, gtp-tunnel
by osmith 19 Oct '23

19 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/34824?usp=email ) Change subject: gitignore: add gtp-link, gtp-tunnel ...................................................................... gitignore: add gtp-link, gtp-tunnel Change-Id: I9f9c9f64d96e25d99c5631ec40c1439f76678905 --- M .gitignore 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/24/34824/1 diff --git a/.gitignore b/.gitignore index 738b3c4..bf5732d 100644 --- a/.gitignore +++ b/.gitignore @@ -34,3 +34,6 @@ debian/libgtpnl0 contrib/libgtpnl.spec + +tools/gtp-link +tools/gtp-tunnel -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9f9c9f64d96e25d99c5631ec40c1439f76678905 Gerrit-Change-Number: 34824 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libgtpnl[master]: Add IPv6 support
by osmith 19 Oct '23

19 Oct '23

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add IPv6 support ...................................................................... Add IPv6 support Implement IPv6 in libgtpnl and the gtp-tunnel testing tool. Allow to combine: - GTPA_MS_ADDRESS and GTPA_PEER_ADDR6 - GTPA_MS_ADDR6 and GTPA_PEER_ADDRESS to specify IPv4-in-IPv6-GTP and IPv6-in-IPv4-GTP in the tunnel declaration from control plane. This patch is based on multiple patches from Pablo in OS#6123. I decided to squash them to directly implement v4-in-v6 and vice versa, instead of implementing another variant first and then changing it again. Co-developed-by: Pablo Neira Ayuso <pablo(a)netfilter.org> Related: OS#6096 Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b --- M include/libgtpnl/gtp.h M include/linux/gtp.h M src/gtp-genl.c M src/gtp.c M src/libgtpnl.map M tools/gtp-tunnel.c 6 files changed, 153 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/35/34735/2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If864c9170f74af52a95cbc4cdb1b866e0309306b Gerrit-Change-Number: 34735 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in libgtpnl[master]: Use struct gtp_addr for ms_addr and sgsn_addr
by osmith 19 Oct '23

19 Oct '23

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Use struct gtp_addr for ms_addr and sgsn_addr ...................................................................... Use struct gtp_addr for ms_addr and sgsn_addr Prepare for IPv6 support by using a new struct for MS and SGSN addresses, in which either an IPv4 or IPv6 can be stored. Related: OS#6096 Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e --- M src/gtp-genl.c M src/gtp.c M src/internal.h 3 files changed, 42 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/34/34734/2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e Gerrit-Change-Number: 34734 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master b...
by pespin 19 Oct '23

19 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email ) Change subject: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master branch ...................................................................... Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master branch The repository branches were rebased and rearranged, where now its master branch follows upstream, and we keep an osmocom/master branch with our own patches (Osmux, not aimed at upstream) which can then be rebased on top of master. Related: OS#6011 Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94 --- M deps/Makefile 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/34823/1 diff --git a/deps/Makefile b/deps/Makefile index bd6ce8a..c6031cb 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -89,7 +89,7 @@ titan.ProtocolEmulations.SCCP_commit= f8a44f2cdef44d0c3adf787ab3184c293a9a58be titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a -titan.ProtocolModules.BSSMAP_commit= 814c5d786ab633bce384eea99685f0e49a386172 +titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 titan.ProtocolModules.GTP_v13.5.0_commit= 54219599037626c675610d3a44433d01af264fbb -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94 Gerrit-Change-Number: 34823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-bsc[master]: ASCI: Add System Information 10 support
by jolly 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ASCI: Add System Information 10 support ...................................................................... ASCI: Add System Information 10 support A timer is used to wait some seconds before sending SI 10 to all BTS. This ensures that all channels are established by the MSC, before sending a complete list of VGCS/VBS neighbor cells for a call. For each BTS, an SI 10 is generated with all other neighbor BTS. The SI 10 will only define neighbor cells within the same BSC, because it does not know about neighbor cells within other BSCs. Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 --- M include/osmocom/bsc/system_information.h M src/osmo-bsc/system_information.c M src/osmo-bsc/vgcs_fsm.c 3 files changed, 329 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/34626/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd3101e6dd935a57f003253aaef400c2cf95a0c3 Gerrit-Change-Number: 34626 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: arehbein, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 13:42:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue
by arehbein 19 Oct '23

19 Oct '23

Attention is currently required from: dexter, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 7: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/6b4eecc1_8e80ac10 PS5, Line 726: "dropping message\n"); > 1- Alright, I'll keep that in mind […] Not sure if this was forgotten, so a short 'comment-ping' here. I don't mind putting the string literal in one line, if it isn't considered as an unrelated change in code review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 13:14:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmo-netif[master]: stream_test: Fix memleaks
by arehbein 19 Oct '23

19 Oct '23

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34793?usp=email ) Change subject: stream_test: Fix memleaks ...................................................................... stream_test: Fix memleaks - Clean up all allocations, introduce clean memory management to entire test Related: OS#6222 Change-Id: Ica25fcd71e8bf8946def3ea7ce320354ea6edb3a --- M tests/stream/stream_test.c 1 file changed, 47 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 0851558..e50752b 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -121,6 +121,7 @@ osmo_stream_cli_set_data(cli, msg); CLI_SND(cli, "Doh, responding to server :-D"); } + msgb_free(msg); return 0; } @@ -299,6 +300,7 @@ than it must be subsequent (after reconnect) call */ request_test_stop(srv); } + msgb_free(msg); osmo_stream_srv_destroy(srv); return -EINVAL; } else { @@ -505,14 +507,11 @@ unsigned char *data; struct ipa_head *h = (struct ipa_head *) msg->l1h; uint8_t ipac_msg_type = *msg->data; - struct msgb *reply = msgb_alloc_headroom(128, 0, "IPA reply"); - if (reply == NULL) { - fprintf(stderr, "Cannot allocate message\n"); - return -ENOMEM; - } + struct msgb *reply; LOGCLI(osc, "Received message from stream (payload len = %" PRIu16 ")\n", msgb_length(msg)); if (ipac_msg_type < 0 || 5 < ipac_msg_type) { fprintf(stderr, "Received unexpected IPAC message type %"PRIu8"\n", ipac_msg_type); + msgb_free(msg); return -ENOMSG; } LOGCLI(osc, "\tType: %s\n", IPAC_MSG_TYPES[ipac_msg_type]); @@ -520,6 +519,11 @@ LOGCLI(osc, "Got IPAC_MSGT_ID_GET from server\n"); LOGCLI(osc, "[(%u + 2/3) -cli] Appending: Second third of IPAC_MSGT_ID_GET\n", test_segm_ipa_stream_srv_msglognum_cli); + reply = msgb_alloc_headroom(128, 0, "IPA reply"); + if (reply == NULL) { + fprintf(stderr, "Cannot allocate message\n"); + return -ENOMEM; + } data = msgb_put(reply, ipac_msg_idreq_third); memcpy(data, ipac_msg_idreq + ipac_msg_idreq_third, ipac_msg_idreq_third); @@ -535,15 +539,14 @@ LOGCLI(osc, "\texpected=%s\n", osmo_hexdump(ipac_msg_idresp, sizeof(ipac_msg_idresp))); } + msgb_free(msg); printf("\n"); return 0; } struct osmo_stream_cli *test_segm_ipa_stream_srv_run_client(void *ctx) { - struct osmo_stream_cli *osc; - - osc = osmo_stream_cli_create(ctx); + struct osmo_stream_cli *osc = osmo_stream_cli_create(ctx); if (osc == NULL) { fprintf(stderr, "osmo_stream_cli_create_iofd()\n"); return NULL; @@ -589,6 +592,7 @@ osmo_stream_srv_send(conn, m); } else if (msgnum_srv == 7 && *msgt == IPAC_MSGT_PONG) { test_segm_ipa_stream_srv_all_msgs_processed = true; + osmo_stream_srv_destroy(conn); } return 0; } @@ -631,6 +635,7 @@ printf("==================================Test %s complete========================================\n\n", testname); if (osc) osmo_stream_cli_destroy(osc); + osmo_stream_srv_link_close(srv); } static void sigalarm_handler(int _foo) @@ -640,6 +645,7 @@ } static struct osmo_timer_list fragmented_send_tl_srv; +static struct osmo_timer_list fragmented_send_tl_srv_destroy; static unsigned test_segm_ipa_stream_cli_srv_msglognum = 0; @@ -652,6 +658,11 @@ put_ipa_msg(UCHAR_PTR_DST, STRUCT_MSGB_PTR, SRC_IPAC_MSG_BUF);\ } while (0) +static void destroy_conn(void *osmo_stream_srv_arg) +{ + osmo_stream_srv_destroy(osmo_stream_srv_arg); +} + static void send_last_third_srv(void *osmo_stream_srv_arg) { struct osmo_stream_srv *oss = osmo_stream_srv_arg; @@ -675,6 +686,11 @@ "[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ]\n"); LOGSRV(oss, "\t(msg dump: %s)\n\n", osmo_hexdump(reply->data, reply->len)); osmo_stream_srv_send(oss, reply); + osmo_timer_setup(&fragmented_send_tl_srv_destroy, destroy_conn, oss); + osmo_timer_add(&fragmented_send_tl_srv_destroy); + /* 2 select loop iterations needed, timing only 1 will leave the client side hanging while waiting + * to receive the last messages */ + osmo_timer_schedule(&fragmented_send_tl_srv_destroy, 0, 2); } int test_segm_ipa_stream_cli_srv_read_cb(struct osmo_stream_srv *conn, struct msgb *msg) @@ -786,11 +802,9 @@ return 0; } -static void *test_segm_ipa_stream_cli_run_client(void *ctx) +static struct osmo_stream_cli *test_segm_ipa_stream_cli_run_client(void *ctx) { - struct osmo_stream_cli *osc; - - osc = osmo_stream_cli_create(ctx); + struct osmo_stream_cli *osc = osmo_stream_cli_create(ctx); if (osc == NULL) { fprintf(stderr, "osmo_stream_cli_create_iofd()\n"); return NULL; @@ -806,13 +820,14 @@ return NULL; } - return NULL; + return osc; } static void test_segm_ipa_stream_cli_run(void *ctx, const char *host, unsigned port, struct osmo_stream_srv_link *srv) { const char *testname = "test_segm_ipa_stream_cli"; + struct osmo_stream_cli *osc = NULL; osmo_stream_srv_link_set_accept_cb(srv, test_segm_ipa_stream_cli_srv_accept_cb); osmo_stream_srv_link_set_port(srv, 1112); @@ -820,7 +835,7 @@ printf("Unable to open server\n"); exit(1); } - test_segm_ipa_stream_cli_run_client(ctx); + osc = test_segm_ipa_stream_cli_run_client(ctx); printf("______________________________________Running test %s______________________________________\n", testname); alarm(2); @@ -831,6 +846,9 @@ } alarm(0); printf("==================================Test %s complete========================================\n\n", testname); + if (osc) + osmo_stream_cli_destroy(osc); + osmo_stream_srv_link_close(srv); } int main(void) @@ -850,7 +868,6 @@ osmo_gettimeofday_override_time.tv_sec = 2; osmo_gettimeofday_override_time.tv_usec = 0; - msgb_talloc_ctx_init(tall_test, 0); osmo_init_logging2(tall_test, &osmo_stream_test_log_info); log_set_log_level(osmo_stderr_target, LOGL_INFO); log_set_use_color(osmo_stderr_target, 0); @@ -881,6 +898,7 @@ printf("Stream tests completed\n"); osmo_stream_srv_link_destroy(srv); + log_fini(); talloc_free(tall_test); return EXIT_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ica25fcd71e8bf8946def3ea7ce320354ea6edb3a Gerrit-Change-Number: 34793 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmo-netif[master]: stream_test: Improve mem mgmt, fix connection mgmt
by arehbein 19 Oct '23

19 Oct '23

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email ) Change subject: stream_test: Improve mem mgmt, fix connection mgmt ...................................................................... stream_test: Improve mem mgmt, fix connection mgmt - Use tall_test as root context everywhere, don't create any other contexts - change .*_(cli|srv)_run_client() signature by adding talloc context as parameter - Open and Close server link inside test_recon() Related: OS#6222 Change-Id: I9ef02ed113bc049ae430b93d0eb69641e2ee809b --- M tests/stream/stream_test.c M tests/stream/stream_test.ok 2 files changed, 93 insertions(+), 81 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 4830302..0851558 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -340,10 +340,17 @@ bool autoreconnect) { struct timeval tv; - struct osmo_stream_cli *cli = make_client(ctx, host, port, autoreconnect); + struct osmo_stream_cli *cli; + if (osmo_stream_srv_link_open(lnk) < 0) { + printf("Unable to open server\n"); + osmo_stream_srv_link_destroy(lnk); + return; + } + cli = make_client(ctx, host, port, autoreconnect); if (!cli) return; + printf("=======================================\n"); printf("Client/Server entering %s event loop...\n", ASTR(autoreconnect)); printf("=======================================\n"); @@ -368,6 +375,7 @@ } osmo_stream_cli_destroy(cli); + osmo_stream_srv_link_close(lnk); printf("{%lu.%06lu} %s test complete.\n\n", tv.tv_sec, tv.tv_usec, ASTR(autoreconnect)); } @@ -531,12 +539,10 @@ return 0; } -struct osmo_stream_cli *test_segm_ipa_stream_srv_run_client(void) +struct osmo_stream_cli *test_segm_ipa_stream_srv_run_client(void *ctx) { struct osmo_stream_cli *osc; - void *ctx = talloc_named_const(NULL, 0, __func__); - (void) msgb_talloc_ctx_init(ctx, 0); osc = osmo_stream_cli_create(ctx); if (osc == NULL) { fprintf(stderr, "osmo_stream_cli_create_iofd()\n"); @@ -546,7 +552,6 @@ osmo_stream_cli_set_local_port(osc, 8977); osmo_stream_cli_set_port(osc, 1111); osmo_stream_cli_set_connect_cb(osc, test_segm_ipa_stream_srv_cli_connect_cb); - osmo_stream_cli_set_data(osc, ctx); osmo_stream_cli_set_read_cb2(osc, test_segm_ipa_stream_srv_cli_read_cb); osmo_stream_cli_set_nodelay(osc, true); if (osmo_stream_cli_open(osc) < 0) { @@ -590,7 +595,7 @@ static int test_segm_ipa_stream_srv_srv_accept_cb(struct osmo_stream_srv_link *srv, int fd) { - void *ctx = talloc_named_const(NULL, 0, __func__); + void *ctx = osmo_stream_srv_link_get_data(srv); struct osmo_stream_srv *oss = osmo_stream_srv_create2(ctx, srv, fd, NULL); if (oss == NULL) { @@ -613,7 +618,7 @@ printf("Unable to open server\n"); exit(1); } - osc = test_segm_ipa_stream_srv_run_client(); + osc = test_segm_ipa_stream_srv_run_client(ctx); printf("______________________________________Running test %s______________________________________\n", testname); alarm(2); @@ -714,7 +719,7 @@ static int test_segm_ipa_stream_cli_srv_accept_cb(struct osmo_stream_srv_link *srv, int fd) { - void *ctx = talloc_named_const(NULL, 0, __func__); + void *ctx = osmo_stream_srv_link_get_data(srv); struct osmo_stream_srv *oss = osmo_stream_srv_create2(ctx, srv, fd, NULL); unsigned char *data; @@ -781,12 +786,10 @@ return 0; } -static void *test_segm_ipa_stream_cli_run_client(void) +static void *test_segm_ipa_stream_cli_run_client(void *ctx) { struct osmo_stream_cli *osc; - void *ctx = talloc_named_const(NULL, 0, __func__); - (void) msgb_talloc_ctx_init(ctx, 0); osc = osmo_stream_cli_create(ctx); if (osc == NULL) { fprintf(stderr, "osmo_stream_cli_create_iofd()\n"); @@ -795,7 +798,6 @@ osmo_stream_cli_set_addr(osc, "127.0.0.11"); osmo_stream_cli_set_local_port(osc, 8977); osmo_stream_cli_set_port(osc, 1112); - osmo_stream_cli_set_data(osc, ctx); osmo_stream_cli_set_read_cb2(osc, test_segm_ipa_stream_cli_cli_read_cb); osmo_stream_cli_set_nodelay(osc, true); osmo_stream_cli_set_segmentation_cb(osc, osmo_ipa_segmentation_cb); @@ -818,7 +820,7 @@ printf("Unable to open server\n"); exit(1); } - test_segm_ipa_stream_cli_run_client(); + test_segm_ipa_stream_cli_run_client(ctx); printf("______________________________________Running test %s______________________________________\n", testname); alarm(2); @@ -869,20 +871,16 @@ osmo_stream_srv_link_set_accept_cb(srv, accept_cb_srv); osmo_stream_srv_link_set_nodelay(srv, true); - if (osmo_stream_srv_link_open(srv) < 0) { - printf("Unable to open server\n"); - osmo_stream_srv_link_destroy(srv); - return EXIT_FAILURE; - } - test_recon(tall_test, host, port, 12, srv, true); test_recon(tall_test, host, port, 8, srv, false); + osmo_stream_srv_link_set_data(srv, tall_test); test_segm_ipa_stream_srv_run(tall_test, host, port, srv); test_segm_ipa_stream_cli_run(tall_test, host, port, srv); printf("Stream tests completed\n"); osmo_stream_srv_link_destroy(srv); + talloc_free(tall_test); return EXIT_SUCCESS; } diff --git a/tests/stream/stream_test.ok b/tests/stream/stream_test.ok index fb65aa7..14da5fa 100644 --- a/tests/stream/stream_test.ok +++ b/tests/stream/stream_test.ok @@ -49,18 +49,18 @@ {20.000019} non-reconnecting test complete. ______________________________________Running test test_segm_ipa_stream_srv______________________________________ -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [1-cli] Appending msg of type IPAC_MSGT_PING into buffer -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [2-cli] Appending msg of type IPAC_MSGT_PONG into buffer -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 01 ) -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [3-cli] Appending msg of type IPAC_MSGT_PING into buffer -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [4-cli] Appending msg of type IPAC_MSGT_ID_RESP into buffer -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 07 fe 05 01 01 de ad be ef ) -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [(04 + 1/3)-cli] Appending 1st third of msg of type IPAC_MSGT_ID_GET into buffer -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (dump: 00 03 ) -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): Sending 4 + 1/3 messages as one: -{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 00 01 fe 01 00 01 fe 00 00 07 fe 05 01 01 de ad be ef 00 03 ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [1-cli] Appending msg of type IPAC_MSGT_PING into buffer +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [2-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 01 ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [3-cli] Appending msg of type IPAC_MSGT_PING into buffer +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [4-cli] Appending msg of type IPAC_MSGT_ID_RESP into buffer +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 07 fe 05 01 01 de ad be ef ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [(04 + 1/3)-cli] Appending 1st third of msg of type IPAC_MSGT_ID_GET into buffer +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (dump: 00 03 ) +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): Sending 4 + 1/3 messages as one: +{20.000020} [NA] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 00 01 fe 01 00 01 fe 00 00 07 fe 05 01 01 de ad be ef 00 03 ) {20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [1-srv] Received IPA message from stream (payload len = 1) {20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 00 @@ -84,21 +84,21 @@ {20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 07 fe 05 01 01 de ad be ef ) {20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Send IPAC_MSGT_ID_GET to trigger client to send next third -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Received message from stream (payload len = 3) -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Type: IPAC_MSGT_ID_GET -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Got IPAC_MSGT_ID_GET from server -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): [(4 + 2/3) -cli] Appending: Second third of IPAC_MSGT_ID_GET -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Sending: Second third of IPAC_MSGT_ID_GET -{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): (msg dump: fe 04 ) +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): Received message from stream (payload len = 3) +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): Type: IPAC_MSGT_ID_GET +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): Got IPAC_MSGT_ID_GET from server +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): [(4 + 2/3) -cli] Appending: Second third of IPAC_MSGT_ID_GET +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): Sending: Second third of IPAC_MSGT_ID_GET +{20.000024} [NA] Client's test_segm_ipa_stream_srv_cli_read_cb(): (msg dump: fe 04 ) -{20.500024} [OK] Client's send_last_third(): Delay for sending last third of message is over -{20.500024} [OK] Client's send_last_third(): [5-cli] Appending: Last third of IPAC_MSGT_ID_GET -{20.500024} [OK] Client's send_last_third(): [6-cli] Appending msg of type IPAC_MSGT_PONG into buffer -{20.500024} [OK] Client's send_last_third(): (msg dump: 00 01 fe 01 ) -{20.500024} [OK] Client's send_last_third(): [7-cli] Appending msg of type IPAC_MSGT_PONG into buffer -{20.500024} [OK] Client's send_last_third(): (msg dump: 00 01 fe 01 ) -{20.500024} [OK] Client's send_last_third(): Sending:[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ] -{20.500024} [OK] Client's send_last_third(): (msg dump: 01 01 00 01 fe 01 00 01 fe 01 ) +{20.500024} [NA] Client's send_last_third(): Delay for sending last third of message is over +{20.500024} [NA] Client's send_last_third(): [5-cli] Appending: Last third of IPAC_MSGT_ID_GET +{20.500024} [NA] Client's send_last_third(): [6-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.500024} [NA] Client's send_last_third(): (msg dump: 00 01 fe 01 ) +{20.500024} [NA] Client's send_last_third(): [7-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.500024} [NA] Client's send_last_third(): (msg dump: 00 01 fe 01 ) +{20.500024} [NA] Client's send_last_third(): Sending:[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ] +{20.500024} [NA] Client's send_last_third(): (msg dump: 01 01 00 01 fe 01 00 01 fe 01 ) {20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [5-srv] Received IPA message from stream (payload len = 3) {20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 03 fe 04 01 01 @@ -131,27 +131,27 @@ {20.500027} [NA|OK] Server's test_segm_ipa_stream_cli_srv_accept_cb(): Sending 4 + 1/3 messages as one: {20.500027} [NA|OK] Server's test_segm_ipa_stream_cli_srv_accept_cb(): (msg dump: 00 01 fe 00 00 01 fe 01 00 01 fe 00 00 07 fe 05 01 01 de ad be ef 00 03 ) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [1-cli] Received message from stream (len = 1) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 00 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 00 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PING -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 00 ) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [2-cli] Received message from stream (len = 1) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [3-cli] Received message from stream (len = 1) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 00 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 00 -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PING -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 00 ) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [4-cli] Received message from stream (len = 7) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 05 01 01 de ad be ef -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 05 01 01 de ad be ef -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_ID_RESP -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 07 fe 05 01 01 de ad be ef ) -{20.500029} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Send IPAC_MSGT_ID_GET to trigger server to send next third +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [1-cli] Received message from stream (len = 1) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 00 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 00 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PING +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 00 ) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [2-cli] Received message from stream (len = 1) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [3-cli] Received message from stream (len = 1) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 00 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 00 +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PING +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 00 ) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [4-cli] Received message from stream (len = 7) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 05 01 01 de ad be ef +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 05 01 01 de ad be ef +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_ID_RESP +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 07 fe 05 01 01 de ad be ef ) +{20.500029} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Send IPAC_MSGT_ID_GET to trigger server to send next third {20.500031} [NA|OK] Server's test_segm_ipa_stream_cli_srv_read_cb(): Received message from stream (total len including stripped headers = 6) {20.500031} [NA|OK] Server's test_segm_ipa_stream_cli_srv_read_cb(): Type: IPAC_MSGT_ID_GET @@ -169,21 +169,21 @@ {20.625031} [NA|OK] Server's send_last_third_srv(): Sending:[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ] {20.625031} [NA|OK] Server's send_last_third_srv(): (msg dump: 01 01 00 01 fe 01 00 01 fe 01 ) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli] Received message from stream (len = 3) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 04 01 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 04 01 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_ID_GET -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 03 fe 04 01 01 ) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli] Received message from stream (len = 1) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli] Received message from stream (len = 1) -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG -{20.625033} [OK] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [5-cli] Received message from stream (len = 3) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 04 01 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 04 01 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_ID_GET +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 03 fe 04 01 01 ) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [6-cli] Received message from stream (len = 1) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): [7-cli] Received message from stream (len = 1) +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): msg buff data: 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): IPA payload: 01 +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): Type: IPAC_MSGT_PONG +{20.625033} [NA] Client's test_segm_ipa_stream_cli_cli_read_cb(): (msg dump (including stripped headers): 00 01 fe 01 ) ==================================Test test_segm_ipa_stream_cli complete======================================== Stream tests completed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9ef02ed113bc049ae430b93d0eb69641e2ee809b Gerrit-Change-Number: 34799 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands
by jolly 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email ) Change subject: mobile: vty: rework support enable/disable commands ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2 Gerrit-Change-Number: 34811 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 13:02:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0