October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
by fixeria 19 Oct '23

19 Oct '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email ) Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 Gerrit-Change-Number: 34822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 12:14:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix sveral wrong ElementIdentifier
by fixeria 19 Oct '23

19 Oct '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email ) Change subject: GTPv2_Templates: Fix sveral wrong ElementIdentifier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1 Gerrit-Change-Number: 34820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 12:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: Fix match of 15-digit IMSIs
by fixeria 19 Oct '23

19 Oct '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email ) Change subject: GTPv2: Fix match of 15-digit IMSIs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e Gerrit-Change-Number: 34821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 12:13:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgtpnl[master]: gtp-genl: allocate room for maximum IPv6 address
by osmith 19 Oct '23

19 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34738?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gtp-genl: allocate room for maximum IPv6 address ...................................................................... gtp-genl: allocate room for maximum IPv6 address Otherwise, inet_ntop() might return ENOSPC because of the buffer being too small to accomodate an IPv6 address. Change-Id: I2283e0c3112bec8e6e7e7b5c96657facc09d0a7a --- M src/gtp-genl.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gtp-genl.c b/src/gtp-genl.c index b8edc72..9c9e8d3 100644 --- a/src/gtp-genl.c +++ b/src/gtp-genl.c @@ -155,7 +155,7 @@ static int genl_gtp_attr_cb(const struct nlmsghdr *nlh, void *data) { struct nlattr *tb[GTPA_MAX + 1] = {}; - char buf[INET_ADDRSTRLEN]; + char buf[INET6_ADDRSTRLEN]; struct gtp_pdp pdp = {}; struct genlmsghdr *genl; -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I2283e0c3112bec8e6e7e7b5c96657facc09d0a7a Gerrit-Change-Number: 34738 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands
by pespin 19 Oct '23

19 Oct '23

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email ) Change subject: mobile: vty: rework support enable/disable commands ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34811/comment/bbfaa42c_19e2da88 PS1, Line 2019: struct osmocom_ms *ms = vty->index; \ Did you think about having all this code in a single helper function where you pass a bool* to it? This way we'd avoid tons of functions duplicating code. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2 Gerrit-Change-Number: 34811 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 11:48:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq
by pespin 19 Oct '23

19 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email ) Change subject: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq ...................................................................... GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 --- M library/GTPv2_Templates.ttcn 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/34822/1 diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index e5022d8..753774d 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -740,38 +740,38 @@ template (present) PDU_GTPCv2 -tr_GTP2C_CreateSessionReq(template (present) hexstring imsi) := +tr_GTP2C_CreateSessionReq(template (present) hexstring imsi := ?, template (present) octetstring apn := ?) := tr_PDU_GTP2C('00000000'O, ?, { createSessionRequest := { iMSI := tr_GTP2C_Imsi(imsi), mSISDN := *, mEI := *, - userLocationInfo := ?, - servingNetwork := ?, - rAT_Type := tr_GTP2C_RatType(6), + userLocationInfo := *, + servingNetwork := *, + rAT_Type := tr_GTP2C_RatType(?), indication := *, fullyQualifiedTEID := ?, - accessPointName := tr_GTP2C_APN('012a'O), // '*' + accessPointName := tr_GTP2C_APN(apn), // '*' selectionMode := ?, - pDN_Type := ?, + pDN_Type := *, pDN_AddressAllocation := ?, - maxAPN_Restriction := ?, + maxAPN_Restriction := *, ambr := *, linkedEPS_Bearer_ID := omit, trustedWLANModeIndication := omit, protocolConfigOptions := omit, bearerContextGrouped := ?, traceInformation := *, - recovery := omit, + recovery := *, csid := omit, - uE_TimeZone := ?, + uE_TimeZone := *, user_CSG_Information := omit, - chargingCharacteristics := ?, + chargingCharacteristics := *, lDN := omit, signallingPriorityIndication := *, iP_Addr := omit, portNumber := omit, - aPCO := omit, + aPCO := *, trustedWLANAccessNetworkIdentifier := omit, cNOperatorSelectionEntity := omit, presenceReportingAreaInformation := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499 Gerrit-Change-Number: 34822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: Fix match of 15-digit IMSIs
by pespin 19 Oct '23

19 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email ) Change subject: GTPv2: Fix match of 15-digit IMSIs ...................................................................... GTPv2: Fix match of 15-digit IMSIs 15-digit IMSIs are len(imsi)=15, but decoded messages are octet-aligned, hence the hexstring in messages is len(imsi)=16, where the last hex char is a padding 'F'H. * Make sure IMSIs stored in GTPv2_Emulation are padded to 16 digits (8 octets) to process matches easily. * Update tr_ template to transparently adapt passed hexstrings to match the octet-aligned value received from the wire. Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e --- M library/GTPv2_Emulation.ttcn M library/GTPv2_Templates.ttcn M library/Osmocom_Types.ttcn 3 files changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/34821/1 diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn index 571da4e..736dd03 100644 --- a/library/GTPv2_Emulation.ttcn +++ b/library/GTPv2_Emulation.ttcn @@ -602,6 +602,10 @@ }; function f_gtp2_register_imsi(hexstring imsi) runs on GTP2_ConnHdlr { + /* 15-digit IMSIs are len(imsi)=15, but decoded messages are + * octet-aligned, hence the hexstring in messages is len(imsi)=16, where + * the last hex char is a padding 'F'H */ + imsi := f_pad_bcd_number(imsi); GTP2_PROC.call(GTP2EM_register_imsi:{imsi}) { [] GTP2_PROC.getreply(GTP2EM_register_imsi:{imsi}); } diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index b306955..e5022d8 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -126,7 +126,7 @@ lengthIndicator := ?, instance := ?, spare := '0000'B, - iMSI_Value := imsi + iMSI_Value := f_pad_bcd_number_tmpl(imsi) } template (present) MSISDN ts_GTP2C_msisdn(template (present) hexstring msisdn) := { diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index ef55583..d034a74 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -261,6 +261,18 @@ } } +function f_pad_bcd_number_tmpl(template hexstring inp) return template hexstring { + if (istemplatekind(inp, "omit")) { + return omit; + } else if (istemplatekind(inp, "*")) { + return *; + } else if (istemplatekind(inp, "?")) { + return ?; + } else { + return f_pad_bcd_number(valueof(inp)); + } +} + /* like L1SAP_IS_PACKET_RACH */ function ra_is_ps(OCT1 ra) return boolean { if ((ra and4b 'F0'O == '70'O) and (ra and4b '0F'O != '0F'O)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e Gerrit-Change-Number: 34821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix sveral wrong ElementIdentifier
by pespin 19 Oct '23

19 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email ) Change subject: GTPv2_Templates: Fix sveral wrong ElementIdentifier ...................................................................... GTPv2_Templates: Fix sveral wrong ElementIdentifier Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1 --- M library/GTPv2_Templates.ttcn 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/34820/1 diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index 644728e..b306955 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -213,16 +213,16 @@ } -/* 8.5 */ +/* 8.6 */ template (value) AccessPointName ts_GTP2C_APN(template (value) octetstring apn) := { - elementIdentifier := '48'O, + elementIdentifier := '47'O, lengthIndicator := 0, /* overwritten */ instance := '0000'B, spare := '0000'B, aPN_Value := apn } template (present) AccessPointName tr_GTP2C_APN(template (present) octetstring apn) := { - elementIdentifier := '48'O, + elementIdentifier := '47'O, lengthIndicator := ?, instance := ?, spare := '0000'B, @@ -321,7 +321,7 @@ /* 8.17 */ template (value) RAT_Type ts_GTP2C_RatType(template (value) integer rat) := { - elementIdentifier := '53'O, + elementIdentifier := '52'O, lengthIndicator := 0, /* overwritten */ instance := '0000'B, spare := '0000'B, @@ -329,7 +329,7 @@ additionalOctets := omit } template (present) RAT_Type tr_GTP2C_RatType(template (present) integer rat) := { - elementIdentifier := '53'O, + elementIdentifier := '52'O, lengthIndicator := ?, instance := ?, spare := '0000'B, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1 Gerrit-Change-Number: 34820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands
by fixeria 19 Oct '23

19 Oct '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email ) Change subject: mobile: vty: rework support enable/disable commands ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2 Gerrit-Change-Number: 34811 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Oct 2023 11:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands
by fixeria 19 Oct '23

19 Oct '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email ) Change subject: mobile: vty: rework support enable/disable commands ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We cannot use `do-while(0)` here because these macros are used outside of functions. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2 Gerrit-Change-Number: 34811 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 19 Oct 2023 11:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0