October 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: transport: print reader device/number on init
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34686?usp=email ) Change subject: transport: print reader device/number on init ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > I wonder if we could have a command line option like --verbose. […] I don't like the --verbose idea - at leat not for this particular topic. The information like which card reader is used, the ATR of the card, ... should be printed by default to the user. We just want a way to disable non-deterministic bits during tests. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5c08995fcd55bd9bb173adc2acd9722e438a164b Gerrit-Change-Number: 34686 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2
by osmith 23 Oct '23

23 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat, part 2 ...................................................................... scripts/repo-install-test: fix sftp compat, part 2 Copy files inside repo-install-test, instead of copying the directory again. Otherwise it creates a /repo-install-test/repo-install-test/ path inside qemu and then fails to run the script inside the directory: Fix for: sh: 0: cannot open /repo-install-test/run-inside-env.sh: No such file Fixes: a7791217 ("scripts/repo-install-test: fix sftp compat") Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 --- M scripts/repo-install-test.sh 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 98f0176..7bef5bf 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -154,7 +154,7 @@ qemu_ssh rm -rf /repo-install-test/ qemu_ssh mkdir /repo-install-test - qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test" + qemu_scp -r "$TEST_DIR"/* "root@127.0.0.1:/repo-install-test" TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 Gerrit-Change-Number: 34856 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat, part 2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 Gerrit-Change-Number: 34856 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by osmith 23 Oct '23

23 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email ) Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841/comment/90a22bd4_b2f1… PS2, Line 17: # > Insert a space after # in each line to make it more readable? Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:12:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Makefile: run 'rebar3 clean' upon make clean Otherwise the diameter files generated during compile in include/ and src/ are not removed. Change-Id: I771860f965499bb754c13385819845ef23f33553 --- M Makefile 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/41/34841/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by osmith 23 Oct '23

23 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email ) Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File Makefile: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841/comment/ec1105b9_819e… PS2, Line 17: # Insert a space after # in each line to make it more readable? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 11:11:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Makefile: run 'rebar3 clean' upon make clean Otherwise the diameter files generated during compile in include/ and src/ are not removed. Change-Id: I771860f965499bb754c13385819845ef23f33553 --- M Makefile 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/41/34841/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat, part 2
by osmith 23 Oct '23

23 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email ) Change subject: scripts/repo-install-test: fix sftp compat, part 2 ...................................................................... scripts/repo-install-test: fix sftp compat, part 2 Copy files inside repo-install-test, instead of copying the directory again. Otherwise it creates a /repo-install-test/repo-install-test/ path inside qemu and then fails to run the script inside the directory: Fix for: sh: 0: cannot open /repo-install-test/run-inside-env.sh: No such file Fixes: a7791217 ("scripts/repo-install-test: fix sftp compat") Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 --- M scripts/repo-install-test.sh 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/56/34856/1 diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 98f0176..7bef5bf 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -154,7 +154,7 @@ qemu_ssh rm -rf /repo-install-test/ qemu_ssh mkdir /repo-install-test - qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test" + qemu_scp -r "$TEST_DIR"/* "root@127.0.0.1:/repo-install-test" TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I04d8c0e0fd31ee5d2a0912300dc93f5339bbef11 Gerrit-Change-Number: 34856 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-pcu[master]: pcuif_proto: drop support for PCUIF v10
by osmith 23 Oct '23

23 Oct '23

Attention is currently required from: dexter, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email ) Change subject: pcuif_proto: drop support for PCUIF v10 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8 Gerrit-Change-Number: 34706 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 10:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: signal BTS model via PCUIF
by pespin 23 Oct '23

23 Oct '23

Attention is currently required from: dexter, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 34647 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 10:21:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0