October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp
by osmith 23 Oct '23

23 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email ) Change subject: library: deduplicate f_logp ...................................................................... library: deduplicate f_logp Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3 --- M bsc/BSC_Tests.ttcn M hnbgw/HNBGW_Tests.ttcn M hnodeb/HNB_Tests.ttcn M library/Osmocom_VTY_Functions.ttcn M smlc/SMLC_Tests.ttcn M upf/UPF_Tests.ttcn 6 files changed, 19 insertions(+), 42 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 426109a..57b44e0 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1129,16 +1129,6 @@ "sccp-timer iar " & int2str(g_bsc_sccp_timer_iar)}); } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - if (pt.checkstate("Mapped")) { - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); - } -} - private function f_sysinfo_seen(integer rsl_idx, RSL_Message rsl) runs on test_CT { if (rsl_idx >= lengthof(g_system_information)) { diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index c3849b8..4afb8dd 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -349,14 +349,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - function f_init_vty(charstring id := "foo") runs on test_CT { if (HNBGWVTY.checkstate("Mapped")) { /* skip initialization if already executed once */ diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 6d1ddc5..df7a04c 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -95,14 +95,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - function f_init_vty(charstring id := "foo") runs on test_CT { if (HNBVTY.checkstate("Mapped")) { /* skip initialization if already executed once */ diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index a448b8b..3dd0429 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -363,4 +363,14 @@ mtc.stop; } +public function f_logp(TELNETasp_PT pt, charstring log_msg) +{ + // log on TTCN3 log output + log(log_msg); + // log in stderr log + if (pt.checkstate("Mapped")) { + f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); + } +} + } diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn index 5324d1c..2a50666 100644 --- a/smlc/SMLC_Tests.ttcn +++ b/smlc/SMLC_Tests.ttcn @@ -156,14 +156,6 @@ } } -private function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - /* global initialization function * \param nr_bts Number of BTSs we should start/bring up * \param handler_mode Start an RSL_Emulation_CT component (true) or not (false). diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 7dc01bb..140e81b 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -68,14 +68,6 @@ } } -friend function f_logp(TELNETasp_PT pt, charstring log_msg) -{ - // log on TTCN3 log output - log(log_msg); - // log in stderr log - f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); -} - private function f_get_name_val(out charstring val, charstring str, charstring name, charstring sep := ":", charstring delim := " ") return boolean { var charstring labl := name & sep; var integer namepos := f_strstr(str, labl); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3 Gerrit-Change-Number: 34838 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmocore[master]: LAPDm: Correctly count expiry of T200 during estabishment/release
by jolly 23 Oct '23

23 Oct '23

jolly has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email ) Change subject: LAPDm: Correctly count expiry of T200 during estabishment/release ...................................................................... LAPDm: Correctly count expiry of T200 during estabishment/release After T200 expires N200+1 times, the link establishment or relase fails. The counting must be performed prior check. Related: OS#5970 Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48 --- M src/isdn/lapd_core.c 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index 6475cb0..5674c66 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -593,6 +593,8 @@ switch (dl->state) { case LAPD_STATE_SABM_SENT: /* 5.4.1.3 */ + /* increment re-transmission counter */ + dl->retrans_ctr++; if (dl->retrans_ctr >= dl->n200_est_rel + 1) { /* flush tx and send buffers */ lapd_dl_flush_tx(dl); @@ -611,13 +613,13 @@ } /* retransmit SABM command */ lapd_send_resend(dl); - /* increment re-transmission counter */ - dl->retrans_ctr++; /* restart T200 (PH-READY-TO-SEND) */ lapd_start_t200(dl); break; case LAPD_STATE_DISC_SENT: /* 5.4.4.3 */ + /* increment re-transmission counter */ + dl->retrans_ctr++; if (dl->retrans_ctr >= dl->n200_est_rel + 1) { /* send MDL ERROR INIDCATION to L3 */ mdl_error(MDL_CAUSE_T200_EXPIRED, &dl->lctx); @@ -635,8 +637,6 @@ } /* retransmit DISC command */ lapd_send_resend(dl); - /* increment re-transmission counter */ - dl->retrans_ctr++; /* restart T200 (PH-READY-TO-SEND) */ lapd_start_t200(dl); break; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48 Gerrit-Change-Number: 34840 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: transport: move init message into concrete classes
by dexter 23 Oct '23

23 Oct '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34853?usp=email ) Change subject: transport: move init message into concrete classes ...................................................................... transport: move init message into concrete classes In in the module __init__.py we print an init message (which type of LinkBase class is providing the SimLink). However in __init__.py we tend to have only platform independed code but the message string can already be categorized as platform depened. Let's put the init message into the constructor of the concrete classes of LinkBase. Related: OS#6210 Change-Id: I0a6dd7deb79a5f3e42b29094a1cf2535075fa430 --- M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py 5 files changed, 21 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/34853/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 581f8e5..5f48657 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -297,20 +297,16 @@ Init card reader driver """ if opts.pcsc_dev is not None: - print("Using PC/SC reader interface") from pySim.transport.pcsc import PcscSimLink sl = PcscSimLink(opts.pcsc_dev, **kwargs) elif opts.osmocon_sock is not None: - print("Using Calypso-based (OsmocomBB) reader interface") from pySim.transport.calypso import CalypsoSimLink sl = CalypsoSimLink(sock_path=opts.osmocon_sock, **kwargs) elif opts.modem_dev is not None: - print("Using modem for Generic SIM Access (3GPP TS 27.007)") from pySim.transport.modem_atcmd import ModemATCommandLink sl = ModemATCommandLink( device=opts.modem_dev, baudrate=opts.modem_baud, **kwargs) else: # Serial reader is default - print("Using serial reader interface") from pySim.transport.serial import SerialSimLink sl = SerialSimLink(device=opts.device, baudrate=opts.baudrate, **kwargs) diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index d7d9649..3fd9992 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -79,6 +79,8 @@ def __init__(self, sock_path: str = "/tmp/osmocom_l2", **kwargs): super().__init__(**kwargs) + print("Using Calypso-based (OsmocomBB) reader interface") + # Make sure that a given socket path exists if not os.path.exists(sock_path): raise ReaderError( diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index 5e5a3dd..1b741b0 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -35,6 +35,7 @@ def __init__(self, device: str = '/dev/ttyUSB0', baudrate: int = 115200, **kwargs): super().__init__(**kwargs) + print("Using modem for Generic SIM Access (3GPP TS 27.007)") self._sl = serial.Serial(device, baudrate, timeout=5) self._echo = False # this will be auto-detected by _check_echo() self._device = device diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index c7b5878..3f3d06c 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -34,6 +34,7 @@ def __init__(self, reader_number: int = 0, **kwargs): super().__init__(**kwargs) + print("Using PC/SC reader interface") r = readers() if reader_number >= len(r): raise ReaderError('No reader found for number %d' % reader_number) diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index e5f7bdb..269ec9c 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -32,6 +32,7 @@ def __init__(self, device: str = '/dev/ttyUSB0', baudrate: int = 9600, rst: str = '-rts', debug: bool = False, **kwargs): super().__init__(**kwargs) + print("Using serial reader interface") if not os.path.exists(device): raise ValueError("device file %s does not exist -- abort" % device) self._sl = serial.Serial( -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0a6dd7deb79a5f3e42b29094a1cf2535075fa430 Gerrit-Change-Number: 34853 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: transport: move argument parser setup into concrete classes
by dexter 23 Oct '23

23 Oct '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34854?usp=email ) Change subject: transport: move argument parser setup into concrete classes ...................................................................... transport: move argument parser setup into concrete classes The argument parser is set up globally for all LinkBase objects in __init__.py. Since we tend to have only platform independed code in __init__.py, we should move the argument parser setup into the specific LinkBase classes. Related: OS#6210 Change-Id: I22c32aa81ca0588e3314c3ff4546f6e5092c11df --- M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py 5 files changed, 56 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/54/34854/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 5f48657..6cccf8c 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -267,27 +267,17 @@ return (rsp, sw) -def argparse_add_reader_args(arg_parser): +def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): """Add all reader related arguments to the given argparse.Argumentparser instance.""" - serial_group = arg_parser.add_argument_group('Serial Reader') - serial_group.add_argument('-d', '--device', metavar='DEV', default='/dev/ttyUSB0', - help='Serial Device for SIM access') - serial_group.add_argument('-b', '--baud', dest='baudrate', type=int, metavar='BAUD', default=9600, - help='Baud rate used for SIM access') + from pySim.transport.serial import SerialSimLink + from pySim.transport.pcsc import PcscSimLink + from pySim.transport.modem_atcmd import ModemATCommandLink + from pySim.transport.calypso import CalypsoSimLink - pcsc_group = arg_parser.add_argument_group('PC/SC Reader') - pcsc_group.add_argument('-p', '--pcsc-device', type=int, dest='pcsc_dev', metavar='PCSC', default=None, - help='PC/SC reader number to use for SIM access') - - modem_group = arg_parser.add_argument_group('AT Command Modem Reader') - modem_group.add_argument('--modem-device', dest='modem_dev', metavar='DEV', default=None, - help='Serial port of modem for Generic SIM Access (3GPP TS 27.007)') - modem_group.add_argument('--modem-baud', type=int, metavar='BAUD', default=115200, - help='Baud rate used for modem port') - - osmobb_group = arg_parser.add_argument_group('OsmocomBB Reader') - osmobb_group.add_argument('--osmocon', dest='osmocon_sock', metavar='PATH', default=None, - help='Socket path for Calypso (e.g. Motorola C1XX) based reader (via OsmocomBB)') + SerialSimLink.argparse_add_reader_args(arg_parser) + PcscSimLink.argparse_add_reader_args(arg_parser) + ModemATCommandLink.argparse_add_reader_args(arg_parser) + CalypsoSimLink.argparse_add_reader_args(arg_parser) return arg_parser diff --git a/pySim/transport/calypso.py b/pySim/transport/calypso.py index 3fd9992..ea97b69 100644 --- a/pySim/transport/calypso.py +++ b/pySim/transport/calypso.py @@ -20,7 +20,7 @@ import struct import socket import os - +import argparse from typing import Optional from pySim.transport import LinkBase @@ -164,3 +164,9 @@ def __str__(self) -> str: return "osmocon:%s" % (self._sock_path) + + @staticmethod + def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): + osmobb_group = arg_parser.add_argument_group('OsmocomBB Reader') + osmobb_group.add_argument('--osmocon', dest='osmocon_sock', metavar='PATH', default=None, + help='Socket path for Calypso (e.g. Motorola C1XX) based reader (via OsmocomBB)') diff --git a/pySim/transport/modem_atcmd.py b/pySim/transport/modem_atcmd.py index 1b741b0..fee09c8 100644 --- a/pySim/transport/modem_atcmd.py +++ b/pySim/transport/modem_atcmd.py @@ -20,6 +20,7 @@ import serial import time import re +import argparse from typing import Optional from pySim.utils import Hexstr, ResTuple @@ -173,3 +174,11 @@ def __str__(self) -> str: return "modem:%s" % self._device + + @staticmethod + def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): + modem_group = arg_parser.add_argument_group('AT Command Modem Reader') + modem_group.add_argument('--modem-device', dest='modem_dev', metavar='DEV', default=None, + help='Serial port of modem for Generic SIM Access (3GPP TS 27.007)') + modem_group.add_argument('--modem-baud', type=int, metavar='BAUD', default=115200, + help='Baud rate used for modem port') diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 3f3d06c..fbe7c0f 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -17,6 +17,7 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. # +import argparse from typing import Optional from smartcard.CardConnection import CardConnection @@ -96,3 +97,9 @@ def __str__(self) -> str: return "PCSC:%u[%s]" % (self._reader_number, self._reader) + + @staticmethod + def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): + pcsc_group = arg_parser.add_argument_group('PC/SC Reader') + pcsc_group.add_argument('-p', '--pcsc-device', type=int, dest='pcsc_dev', metavar='PCSC', default=None, + help='PC/SC reader number to use for SIM access') diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py index 269ec9c..867317c 100644 --- a/pySim/transport/serial.py +++ b/pySim/transport/serial.py @@ -19,6 +19,7 @@ import serial import time import os.path +import argparse from typing import Optional from pySim.exceptions import NoCardError, ProtocolError @@ -240,3 +241,11 @@ def __str__(self) -> str: return "serial:%s" % (self._sl.name) + + @staticmethod + def argparse_add_reader_args(arg_parser: argparse.ArgumentParser): + serial_group = arg_parser.add_argument_group('Serial Reader') + serial_group.add_argument('-d', '--device', metavar='DEV', default='/dev/ttyUSB0', + help='Serial Device for SIM access') + serial_group.add_argument('-b', '--baud', dest='baudrate', type=int, metavar='BAUD', default=9600, + help='Baud rate used for SIM access') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34854?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22c32aa81ca0588e3314c3ff4546f6e5092c11df Gerrit-Change-Number: 34854 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls
by jolly 23 Oct '23

23 Oct '23

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email ) Change subject: mobile: add support for Circuit Switched Data calls ...................................................................... Patch Set 4: (1 comment) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34762/comment/36d2fa71_3a575cbb PS4, Line 634: trans-cap (udi|3100khz-audio|facsimile) The transfer capability must be defined (generated) while doing the outgoing call (speech/fax/data), not at VTY. The only thing that needs to be defined here is how data calls have to be made: udi (ISDN) or audio (modem). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6 Gerrit-Change-Number: 34762 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 08:54:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: prevent SimCardCommands.select_adf_by_aid bypassing lchan
by fixeria 23 Oct '23

23 Oct '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34849?usp=email ) Change subject: prevent SimCardCommands.select_adf_by_aid bypassing lchan ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/34849/comment/bdd219c9_533d75ab PS1, Line 149: SimCardCommands `Optional[SimCardCommands]` as it can be `None` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idf05c297e6a2e24ca539408b8912e348c0782bb4 Gerrit-Change-Number: 34849 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Oct 2023 06:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Add 'switch_channel' command
by fixeria 23 Oct '23

23 Oct '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34848?usp=email ) Change subject: pySim-shell: Add 'switch_channel' command ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia76eb45c4925882ae6866e50b64d9610bd4d546d Gerrit-Change-Number: 34848 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Oct 2023 06:53:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Include current logical channel in prompt
by fixeria 23 Oct '23

23 Oct '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34850?usp=email ) Change subject: pySim-shell: Include current logical channel in prompt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I45781a6fba205eeb4ac7f58d5cb642b7131bdd88 Gerrit-Change-Number: 34850 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Oct 2023 06:53:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: utils: Fix bertlv_encode_tag() for multi-byte tags
by fixeria 23 Oct '23

23 Oct '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34851?usp=email ) Change subject: utils: Fix bertlv_encode_tag() for multi-byte tags ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0bd9137883c4c8b01c4dfcbb53cabeee5c1ce2b Gerrit-Change-Number: 34851 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Oct 2023 06:52:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: Initial support for eUICC
by laforge 23 Oct '23

23 Oct '23

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email to look at the new patch set (#4). Change subject: Initial support for eUICC ...................................................................... Initial support for eUICC This just adds basic support for the ISD-R application and its associated STORE DATA command which is used for the ES10x interfaces between off-card entities and the on-card ISD-R. Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a Closes: OS#5637 --- M pySim-shell.py A pySim/euicc.py M pySim/global_platform.py 3 files changed, 350 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/34852/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieab37b083e25d3f36c20f6e9ed3e4bdfdd14a42a Gerrit-Change-Number: 34852 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0