lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2023

  • 1 participants
  • 1843 discussions
[S] Change in ...osmo-epdg[master]: Fix sysmocom copyright typo
by lynxis lazus 23 Oct '23

23 Oct '23
Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email ) Change subject: Fix sysmocom copyright typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c Gerrit-Change-Number: 34863 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 13:02:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
by lynxis lazus 23 Oct '23

23 Oct '23
Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email ) Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp ...................................................................... Patch Set 4: (3 comments) Patchset: PS4: Isn't there a GTPv2 ping/pong or keepalive? I think we need to implement this procedure. File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/ca2ca488_6b71… PS4, Line 10: % This program is free software; you can redistribute it and/or modify In general on this project: We should have a separate discussion about the license. I don't know if we're compatible here with AGPL. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/5bb9a8af_1d83… PS4, Line 60: %% TODO: make APN configurable? get it from HSS? The UE sends the APN when connecting to the ePDG within the IKEv2. It's part of the identity. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579 Gerrit-Change-Number: 34804 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 13:01:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean
by lynxis lazus 23 Oct '23

23 Oct '23
Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email ) Change subject: Makefile: run 'rebar3 clean' upon make clean ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553 Gerrit-Change-Number: 34841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 12:49:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in ...osmo-epdg[master]: Fix sysmocom copyright typo
by pespin 23 Oct '23

23 Oct '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email ) Change subject: Fix sysmocom copyright typo ...................................................................... Fix sysmocom copyright typo Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c --- M dia/diameter_3gpp_ts29_273.dia M dia/diameter_3gpp_ts29_273_swx.dia M dia/diameter_etsi_es283_035.dia M dia/diameter_rfc5580.dia M dia/diameter_rfc8583.dia M src/epdg_diameter_swx.erl 6 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/63/34863/1 diff --git a/dia/diameter_3gpp_ts29_273.dia b/dia/diameter_3gpp_ts29_273.dia index ac22a53..e22cc0d 100644 --- a/dia/diameter_3gpp_ts29_273.dia +++ b/dia/diameter_3gpp_ts29_273.dia @@ -1,7 +1,7 @@ ;; ;; %CopyrightBegin% ;; -;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ;; Author: Alexander Couzens <lynxis(a)fe80.eu> ;; ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15 diff --git a/dia/diameter_3gpp_ts29_273_swx.dia b/dia/diameter_3gpp_ts29_273_swx.dia index d6d446c..1e86dee 100644 --- a/dia/diameter_3gpp_ts29_273_swx.dia +++ b/dia/diameter_3gpp_ts29_273_swx.dia @@ -1,7 +1,7 @@ ;; ;; %CopyrightBegin% ;; -;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ;; Author: Alexander Couzens <lynxis(a)fe80.eu> ;; ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15 diff --git a/dia/diameter_etsi_es283_035.dia b/dia/diameter_etsi_es283_035.dia index c1e4e5e..c0baff2 100644 --- a/dia/diameter_etsi_es283_035.dia +++ b/dia/diameter_etsi_es283_035.dia @@ -1,7 +1,7 @@ ;; ;; %CopyrightBegin% ;; -;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ;; Author: Alexander Couzens <lynxis(a)fe80.eu> ;; ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15 diff --git a/dia/diameter_rfc5580.dia b/dia/diameter_rfc5580.dia index bfc851a..9a41bd7 100644 --- a/dia/diameter_rfc5580.dia +++ b/dia/diameter_rfc5580.dia @@ -1,7 +1,7 @@ ;; ;; %CopyrightBegin% ;; -;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ;; Author: Alexander Couzens <lynxis(a)fe80.eu> ;; ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15 diff --git a/dia/diameter_rfc8583.dia b/dia/diameter_rfc8583.dia index cfde5e5..59df542 100644 --- a/dia/diameter_rfc8583.dia +++ b/dia/diameter_rfc8583.dia @@ -1,7 +1,7 @@ ;; ;; %CopyrightBegin% ;; -;; Copyright (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +;; Copyright (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ;; Author: Alexander Couzens <lynxis(a)fe80.eu> ;; ;; This resembles 3GPP TS 29.273 version 15.4.0 Release 15 diff --git a/src/epdg_diameter_swx.erl b/src/epdg_diameter_swx.erl index dadfa65..c278206 100644 --- a/src/epdg_diameter_swx.erl +++ b/src/epdg_diameter_swx.erl @@ -2,7 +2,7 @@ % % TS 29.273 % -% (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> +% (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> % Author: Alexander Couzens <lynxis(a)fe80.eu> % % All Rights Reserved -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia6a3748ac3eb7c5587ed978d60afd315dae07a3c Gerrit-Change-Number: 34863 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[L] Change in ...osmo-epdg[master]: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)
by pespin 23 Oct '23

23 Oct '23
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777) ...................................................................... diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777) S6b interface HSS<->PGW is defined in TS 28.273 section 9. TS 28.273 depends on some types defined in RFC 5777, which was missing so far. Some enumareated types in RFC 5777 whose enums fields are declared in yet other dependent RFCs are left with a dummy value, as TODO for the future if they are ever needed. Related: OS#6229 Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc --- A dia/diameter_3gpp_ts29_273_s6b.dia A dia/diameter_rfc5777.dia 2 files changed, 553 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/57/34857/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc Gerrit-Change-Number: 34857 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[L] Change in ...osmo-epdg[master]: Initial S6b support
by pespin 23 Oct '23

23 Oct '23
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Initial S6b support ...................................................................... Initial S6b support So far only the Rx of AAR msg and Tx of AAA is supported. This allows already going forward during the session creation, where PGW sends AAR to the AAA server and expects AAA message. Related: OS#6229 Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b --- M config/sys.config A src/aaa_diameter_s6b.erl A src/aaa_diameter_s6b_cb.erl M src/osmo_epdg_sup.erl 4 files changed, 305 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/58/34858/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b Gerrit-Change-Number: 34858 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
by pespin 23 Oct '23

23 Oct '23
Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp ...................................................................... Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp Initial GTPv2C infrastructure to send GTPv2C CreateSession Request upon receival of GSUP EPDG_Tunnel Request, and answer with EPDG_Tunnel Resp/err when creating the session fails. Related: OS#6046 Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579 --- M config/sys.config M rebar.config M rebar.lock A src/epdg_gtpc_s2b.erl M src/gsup_server.erl M src/osmo_epdg.app.src M src/osmo_epdg_sup.erl 7 files changed, 320 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/04/34804/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579 Gerrit-Change-Number: 34804 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in docker-playground[master]: ttcn3-epdg: Configure S6b interface
by pespin 23 Oct '23

23 Oct '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34862?usp=email ) Change subject: ttcn3-epdg: Configure S6b interface ...................................................................... ttcn3-epdg: Configure S6b interface Configure the newly added S6b interface on both TTCN3 emulation code as well as osmo-epdg. Depends: osmo-ttcn3-hacks.git Change-Id Ia50698a3f6f5ed8251486b84c09f84edfd6d3951 Depends: osmo-epdg.git Change-Id Ia2b138317cb291a95882853f5403949c5e6a5a1b Change-Id: I1145ee1068a2fdd2fe8d3e48b80c8e6c1fcb50ad --- M ttcn3-epdg-test/EPDG_Tests.cfg M ttcn3-epdg-test/osmo-epdg.config 2 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/62/34862/1 diff --git a/ttcn3-epdg-test/EPDG_Tests.cfg b/ttcn3-epdg-test/EPDG_Tests.cfg index f05a819..2a39b67 100644 --- a/ttcn3-epdg-test/EPDG_Tests.cfg +++ b/ttcn3-epdg-test/EPDG_Tests.cfg @@ -13,6 +13,7 @@ EPDG_Tests.mp_s2b_local_ip := "172.18.10.103" EPDG_Tests.mp_gsup_remote_ip := "172.18.10.20" +EPDG_Tests.mp_s6b_remote_ip := "172.18.10.20" EPDG_Tests.mp_s2b_remote_ip := "172.18.10.20" [MAIN_CONTROLLER] diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 8036b2c..0aa9807 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -10,11 +10,18 @@ {diameter_remote_ip, "172.18.10.103"}, {diameter_remote_port, 3868}, {diameter_proto, sctp}, - % Diameter Server parameters {vendor_id, 0}, {origin_host, "epdg.localdomain"}, {origin_realm, "localdomain"}, {context_id, "epdg@localdomain"}, + % Diameter s6b Connection parameters + {dia_s6b_local_ip, "172.18.10.20"}, + {dia_s6b_local_port, 3869}, + {dia_s6b_proto, sctp}, + {dia_s6b_vendor_id, 0}, + {dia_s6b_origin_host, "aaa.localdomain"}, + {dia_s6b_origin_realm, "localdomain"}, + {dia_s6b_context_id, "aaa@localdomain"}, % GTPv2C Connection parameters {gtpc_local_ip, "172.18.10.20"}, {gtpc_local_port, 2123}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1145ee1068a2fdd2fe8d3e48b80c8e6c1fcb50ad Gerrit-Change-Number: 34862 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: epdg: Emulate PGW tx AAR and rx AAA in S6b interface
by pespin 23 Oct '23

23 Oct '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34861?usp=email ) Change subject: epdg: Emulate PGW tx AAR and rx AAA in S6b interface ...................................................................... epdg: Emulate PGW tx AAR and rx AAA in S6b interface Related: OS#6229 Change-Id: Ia50698a3f6f5ed8251486b84c09f84edfd6d3951 --- M epdg/EPDG_Tests.ttcn 1 file changed, 42 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/34861/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 3a0c3a6..76fd45e 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -32,6 +32,8 @@ /* our emulated PGW (Diameter S6b) */ charstring mp_s6b_local_ip := "127.0.0.100"; integer mp_s6b_local_port := 3869; + charstring mp_s6b_remote_ip := "127.0.0.1"; + integer mp_s6b_remote_port := 3869; /* our emulated PGW (GTPv2C S2b) */ charstring mp_s2b_local_ip := "127.0.0.100"; @@ -212,14 +214,14 @@ /* S6b setup: */ pars := { - remote_ip := "", - remote_sctp_port := -1, /* server mode */ + remote_ip := mp_s6b_remote_ip, + remote_sctp_port := mp_s6b_remote_port, /* client mode */ local_ip := mp_s6b_local_ip, local_sctp_port := mp_s6b_local_port, - origin_host := "hss." & mp_diam_realm, + origin_host := "pgw." & mp_diam_realm, origin_realm := mp_diam_realm, - auth_app_id := omit, - vendor_app_id := c_DIAMETER_3GPP_S6_AID + auth_app_id := c_DIAMETER_3GPP_S6b_AID, + vendor_app_id := c_DIAMETER_3GPP_S6b_AID }; vc_S6b := DIAMETER_Emulation_CT.create(id); map(vc_S6b:DIAMETER, system:DIAMETER_CODEC_PT); @@ -228,8 +230,7 @@ vc_S6b.start(DIAMETER_Emulation.main(ops, pars, id)); f_diameter_wait_capability(SWx_UNIT); - // FIXME: osmo-epdg doesn't connect to S6b yet. - //f_diameter_wait_capability(S6b_UNIT); + f_diameter_wait_capability(S6b_UNIT); /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdog ping-pongs): * RFC6733 sec 5.1 @@ -362,6 +363,26 @@ } } +/* Send AAR as PGW to AAA server, expect back AAA */ +private function f_S6b_AA_success() runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; + var UINT32 hbh_id := f_rnd_octstring(4); + var UINT32 ete_id := f_rnd_octstring(4); + + /* Unlike AAR, AAA contains no IMSI. Register ete_id in DIAMETER_Emulation, + * so AIA is forwarded back to us in DIAMETER port instead of MTC_CT.DIAMETER_UNIT. + */ + f_epdg_connhldr_S6b_expect_eteid(ete_id); + + S6b.send(ts_DIA_S6b_AAR(g_pars.imsi, hbh_id := hbh_id, ete_id := ete_id)); + alt { + [] S6b.receive(tr_DIA_S6b_AAA) -> value rx_dia {} + [] S6b.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter S6b msg rx: ", rx_dia)); + } + } +} + /* Diameter SWx SAR + SAA. */ private altstep as_GTP2C_CreateSession_success() runs on EPDG_ConnHdlr { var PDU_GTPCv2 rx_msg; @@ -375,11 +396,15 @@ g_pars.teic := f_gtp2_allocate_teid(); g_pars.teid := g_pars.teic; + /* Upon rx of CreateSession, emulate PGW asking the AAA server. */ + f_S6b_AA_success(); + fteid_c_ie := ts_GTP2C_FTEID(FTEID_IF_S2b_ePDG_GTPC, g_pars.teic, 0, f_inet_addr(mp_s2b_local_ip), omit); fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S2bU_ePDG_GTPU, g_pars.teid, 2, f_inet_addr(mp_s2b_local_ip), omit); paa := ts_GTP2C_PdnAddrAlloc_v4(f_inet_addr(g_pars.ue_ip)); + GTP2.send(ts_GTP2C_CreateSessionResp({ fteid_c_ie }, paa)); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia50698a3f6f5ed8251486b84c09f84edfd6d3951 Gerrit-Change-Number: 34861 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Add S6b AAR and AAA message templates
by pespin 23 Oct '23

23 Oct '23
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34860?usp=email ) Change subject: DIAMETER_Templates: Add S6b AAR and AAA message templates ...................................................................... DIAMETER_Templates: Add S6b AAR and AAA message templates Related: OS#6229 Change-Id: I302d9a94e6ffbb62b6db81e1b14484355e55ebe5 --- M library/DIAMETER_Templates.ttcn 1 file changed, 97 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/34860/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index f909b5f..f46bf37 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -127,6 +127,8 @@ const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308; /* 3GPP TS 29.273 Section 8.2 */ const uint32_t c_DIAMETER_3GPP_SWx_AID := 16777265; +/* 3GPP TS 29.273 Section 9 */ +const uint32_t c_DIAMETER_3GPP_S6b_AID := 16777272; const octetstring c_def_sess_id := char2oct("ttcn3.session"); @@ -1518,6 +1520,34 @@ } } +/* RFC6733 8.7. Auth-Request-Type AVP */ +template (value) GenericAVP ts_AVP_AuthRequestType(BASE_NONE_Auth_Request_Type auth_req_type) := { + avp := { + avp_header := ts_DIA_Hdr(c_AVP_Code_BASE_NONE_Auth_Request_Type, '00000000'B), + avp_data := { + avp_BASE_NONE_Auth_Request_Type := auth_req_type + } + } +}/* +private function f_tr_AVP_AuthRequestType(template (present) BASE_NONE_Auth_Request_Type auth_req_type) +return template (present) BASE_NONE_Auth_Request_Type { + if (istemplatekind(auth_req_type, "?")) { + return ?; + } else { + var template (present) BASE_NONE_Auth_Request_Type c; + c := int2oct(enum2int(valueof(auth_req_type)), 4); + return c; + } +}*/ +template (present) GenericAVP tr_AVP_AuthRequestType(template (present) BASE_NONE_Auth_Request_Type auth_req_type) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Auth_Request_Type), + avp_data := { + avp_BASE_NONE_Auth_Request_Type := auth_req_type + } + } +} + /* 5.3.1 Capabilities Exchange Request */ template (value) PDU_DIAMETER @@ -2276,9 +2306,9 @@ } } -/***************************** - * SWx 3GPP TS 29.273 - *****************************/ +/******************************* + * SWx 3GPP TS 29.273 section 8 + *******************************/ /* SIP-Auth-Data-Item , 3GPP TS 29.273 8.2.3.9 */ template (present) GenericAVP tr_AVP_3GPP_SIPAuthDataItem(template (present) uint32_t num := ?) := { @@ -2445,4 +2475,58 @@ */ }); +/******************************* + * S6b 3GPP TS 29.273 section 9 + *******************************/ + + /* TS 29.273 9.2.2.5.1 AA-Request (AAR) */ +template (value) PDU_DIAMETER +ts_DIA_S6b_AAR(template (value) hexstring imsi, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "pgw.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '11000000'B, + cmd_code := Authorize_Authenticate, + app_id := int2oct(c_DIAMETER_3GPP_S6b_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + /* Optional: DRMP, */ + ts_AVP_AuthAppId(int2oct(c_DIAMETER_3GPP_S6b_AID, 4)), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_DestinationRealm(dest_realm), + ts_AVP_AuthRequestType(AUTHORIZE_ONLY), + ts_AVP_UserNameImsi(valueof(imsi)) + /* TODO: Lots other optional */ + }); + +/* TS 29.273 9.2.2.2.2 AA-Answer (AAA) */ +template (present) PDU_DIAMETER +tr_DIA_S6b_AAA(template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?, + template (present) CxDx_3GPP_Server_Assignment_Type server_ass_type := ?, + template (present) charstring service_selection := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Authorize_Authenticate, + app_id := int2oct(c_DIAMETER_3GPP_S6b_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + /* Optional: DRMP, */ + tr_AVP_AuthAppId(int2oct(c_DIAMETER_3GPP_S6b_AID, 4)), + tr_AVP_AuthRequestType(AUTHORIZE_ONLY), + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm) + )); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I302d9a94e6ffbb62b6db81e1b14484355e55ebe5 Gerrit-Change-Number: 34860 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 45
  • 46
  • 47
  • 48
  • 49
  • 50
  • 51
  • ...
  • 185
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.