Attention is currently required from: fixeria, laforge, pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )
Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Isn't there a GTPv2 ping/pong or keepalive?
I think we need to implement this procedure.
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/ca2ca488_6b71…
PS4, Line 10: % This program is free software; you can redistribute it and/or modify
In general on this project: We should have a separate discussion about the license. I don't know if we're compatible here with AGPL.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804/comment/5bb9a8af_1d83…
PS4, Line 60: %% TODO: make APN configurable? get it from HSS?
The UE sends the APN when connecting to the ePDG within the IKEv2.
It's part of the identity.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )
Change subject: Makefile: run 'rebar3 clean' upon make clean
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 12:49:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)
......................................................................
diameter: Add spec definitions for S6b (TS 28.273 and dep RFC 5777)
S6b interface HSS<->PGW is defined in TS 28.273 section 9.
TS 28.273 depends on some types defined in RFC 5777, which was missing
so far.
Some enumareated types in RFC 5777 whose enums fields are declared in
yet other dependent RFCs are left with a dummy value, as TODO for the
future if they are ever needed.
Related: OS#6229
Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
---
A dia/diameter_3gpp_ts29_273_s6b.dia
A dia/diameter_rfc5777.dia
2 files changed, 553 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/57/34857/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I8075dd54a5fec386feecdf797d710a2524413acc
Gerrit-Change-Number: 34857
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Initial S6b support
......................................................................
Initial S6b support
So far only the Rx of AAR msg and Tx of AAA is supported.
This allows already going forward during the session creation, where PGW
sends AAR to the AAA server and expects AAA message.
Related: OS#6229
Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
---
M config/sys.config
A src/aaa_diameter_s6b.erl
A src/aaa_diameter_s6b_cb.erl
M src/osmo_epdg_sup.erl
4 files changed, 305 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/58/34858/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.
Hello Jenkins Builder, fixeria, laforge, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
......................................................................
Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
Initial GTPv2C infrastructure to send GTPv2C CreateSession Request upon
receival of GSUP EPDG_Tunnel Request, and answer with EPDG_Tunnel
Resp/err when creating the session fails.
Related: OS#6046
Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
---
M config/sys.config
M rebar.config
M rebar.lock
A src/epdg_gtpc_s2b.erl
M src/gsup_server.erl
M src/osmo_epdg.app.src
M src/osmo_epdg_sup.erl
7 files changed, 320 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/04/34804/4
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset