January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31096 ) Change subject: Mark *_fsm_timeouts as static ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf2a6ee5636ae7102ffd13b7497769652bcc3202 Gerrit-Change-Number: 31096 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 29 Jan 2023 10:48:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

by laforge

Attention is currently required from: neels, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342 ) Change subject: After RX of an SMPP Submit, send the SMS we just received. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > so the summary is to abandon this patch, or to merge it because it hardly matters? if this patch helps you in production setups, and it has been tested/verified there, please rebase and we can get it merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Sun, 29 Jan 2023 10:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: clone repos with --recurse-submodules

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31100 ) Change subject: gen_makefile.py: clone repos with --recurse-submodules ...................................................................... gen_makefile.py: clone repos with --recurse-submodules Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a --- M gen_makefile.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved fixeria: Verified diff --git a/gen_makefile.py b/gen_makefile.py index 6267888..d45e5e8 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -178,7 +178,7 @@ .make.{proj}.clone: @echo -e "\\n\\n\\n===== $@\\n" test -d {src} || mkdir -p {src} - test -d {src_proj} || ( git -C {src} clone "{url}/{proj}" "{proj}" && git -C "{src}/{proj}" remote set-url --push origin "{push_url}/{proj}" ) + test -d {src_proj} || ( git -C {src} clone --recurse-submodules "{url}/{proj}" "{proj}" && git -C "{src}/{proj}" remote set-url --push origin "{push_url}/{proj}" ) sync touch $@ ''' -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a Gerrit-Change-Number: 31100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gits: fix alias 're' of 'rebase' doing nothing

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31101 ) Change subject: gits: fix alias 're' of 'rebase' doing nothing ...................................................................... gits: fix alias 're' of 'rebase' doing nothing Change-Id: Ib861155ee988503ee142c97fac531770700761db --- M src/gits 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved fixeria: Verified diff --git a/src/gits b/src/gits index 735dc4e..de2fe88 100755 --- a/src/gits +++ b/src/gits @@ -465,7 +465,7 @@ print_status() elif args.action in ['fetch', 'f']: cmd_do(['fetch'] + args.remainder) - elif args.action in ['rebase', 'r']: + elif args.action in ['rebase', 'r', 're']: cmd_rebase() elif args.action == 'sh': cmd_sh(args.remainder) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib861155ee988503ee142c97fac531770700761db Gerrit-Change-Number: 31101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

by neels

Attention is currently required from: keith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342 ) Change subject: After RX of an SMPP Submit, send the SMS we just received. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I would not use the term "bypass". […] so the summary is to abandon this patch, or to merge it because it hardly matters? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gits: fix alias 're' of 'rebase' doing nothing

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31101 ) Change subject: gits: fix alias 're' of 'rebase' doing nothing ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib861155ee988503ee142c97fac531770700761db Gerrit-Change-Number: 31101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:25:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: clone repos with --recurse-submodules

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31100 ) Change subject: gen_makefile.py: clone repos with --recurse-submodules ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a Gerrit-Change-Number: 31100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gits: fix alias 're' of 'rebase' doing nothing

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31101 ) Change subject: gits: fix alias 're' of 'rebase' doing nothing ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: btw, you can just merge changes to osmo-dev directly -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib861155ee988503ee142c97fac531770700761db Gerrit-Change-Number: 31101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:24:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: clone repos with --recurse-submodules

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/31100 ) Change subject: gen_makefile.py: clone repos with --recurse-submodules ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a Gerrit-Change-Number: 31100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:24:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31096 ) Change subject: Mark *_fsm_timeouts as static ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File src/tbf_dl_ass_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31096/comment/866b54ec_cac4cb9d PS2, Line 40: const struct value_string tbf_dl_ass_fsm_event_names[] = { (this could also go static) https://gerrit.osmocom.org/c/osmo-pcu/+/31096/comment/20f53543_655acaba PS2, Line 57: struct msgb *create_packet_dl_assign(const struct tbf_dl_ass_fsm_ctx *ctx, (this too apparently. probably there's a couple more but i'm not bothering now) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf2a6ee5636ae7102ffd13b7497769652bcc3202 Gerrit-Change-Number: 31096 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:22:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023