Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31092 )
Change subject: osmo-pcu: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31092
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9559486ce64a9ccf348b4ee0e1d09141dbc1ae8f
Gerrit-Change-Number: 31092
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Jan 2023 11:47:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31093 )
Change subject: libosmocore: Transition to use of 'telnet_init_default'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie762d0c642021db1a6ef95333cd771351de86845
Gerrit-Change-Number: 31093
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Jan 2023 11:46:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31039 )
Change subject: Add SI10 support
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31039
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab
Gerrit-Change-Number: 31039
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 28 Jan 2023 11:42:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31031
to look at the new patch set (#2).
Change subject: Add more L1 signals to common part
......................................................................
Add more L1 signals to common part
Change-Id: I295dc340d3d3a7cbb5aba5afe807746acbcde33f
---
M include/osmocom/abis/e1_input.h
M src/e1_input.c
2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/31/31031/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31031
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I295dc340d3d3a7cbb5aba5afe807746acbcde33f
Gerrit-Change-Number: 31031
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31032
to look at the new patch set (#2).
Change subject: Add function to set Sa bits to common part
......................................................................
Add function to set Sa bits to common part
Change-Id: I4f5f975f0e5f708ae573a1e1ce41c6a08c207fad
---
M TODO-RELEASE
M include/osmocom/abis/e1_input.h
M src/e1_input.c
3 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/32/31032/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31032
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I4f5f975f0e5f708ae573a1e1ce41c6a08c207fad
Gerrit-Change-Number: 31032
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: jolly.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31035
to look at the new patch set (#4).
Change subject: Use correct bit order of RAW channels at misdn driver
......................................................................
Use correct bit order of RAW channels at misdn driver
mISDN Kernel driver uses reversed bit order for RAW (transparent)
channels. With this patch, the order is reversed. Now it uses the
same bit order as RTP payload does. Also it uses same bit order as
other drivers do, like dahdi and e1d.
Change-Id: I77b899bceacdf5484ea9a841cad55775864b4c82
---
M src/input/misdn.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/35/31035/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I77b899bceacdf5484ea9a841cad55775864b4c82
Gerrit-Change-Number: 31035
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31034
to look at the new patch set (#4).
Change subject: Add setting of Sa bits to misdn driver
......................................................................
Add setting of Sa bits to misdn driver
Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0
---
M src/input/misdn.c
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/34/31034/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31034
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I54205a2534a7638cc071888d853f9d6d312dc9f0
Gerrit-Change-Number: 31034
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31031 )
Change subject: Add more L1 signals to common part
......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/abis/e1_input.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/1579fa08_8ba36a55
PS1, Line 245: S_L_INP_LINE_LOS,
: S_L_INP_LINE_NOLOS,
: S_L_INP_LINE_AIS,
: S_L_INP_LINE_NOAIS,
: S_L_INP_LINE_RAI,
: S_L_INP_LINE_NORAI,
: S_L_INP_LINE_SLIP_RX,
: S_L_INP_LINE_SLIP_TX,
> I understand the above signals, but what does the SA_BITS signal do? when is it supposed to be gener […]
I will add a description of the location of the bits.
https://gerrit.osmocom.org/c/libosmo-abis/+/31031/comment/fb4ec6db_5805a40f
PS1, Line 370: uint8_t sa_bits;
> IIUC this doesn't break ABI in struct size sense, since it's filling a hole.
Yes, it checked it.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31031
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I295dc340d3d3a7cbb5aba5afe807746acbcde33f
Gerrit-Change-Number: 31031
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Jan 2023 10:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )
Change subject: Add L1 signals to misdn driver
......................................................................
Patch Set 3:
(1 comment)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/fa2f86e5_ac9b6893
PS3, Line 115: LOGP(DLMI, LOGL_DEBUG, "L1_SIGNAL_LOS_OFF\n");
> I agree, a value_string migt make sense. […]
I will put the signals into a value_string array.
AIS/LOS/RAI may be received very often when the interface is not connected. (Due to noise.) A NOTICE would flood the log.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Id8b6fad9b073cf92eee92a6906bf5b57af37e2f0
Gerrit-Change-Number: 31033
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 28 Jan 2023 09:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment