January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBAP port to ConnHdlr

by neels

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 ) Change subject: hnbgw: add HNBAP port to ConnHdlr ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/0bef79be_fcf3… PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */ > because there may be tests currently spawning ConHdlr but still sending HNBAP from the test_CT, that […] When I want to send HNBAP in-between some RUA-SCCP conn activities, it is cumbersome to have to go back to test_CT for HNBAP. AFAIU we can send HNBAP from the test_CT, and when we start ConnHdlr we can use HNBAP in there. In test_CT we have HNBAP[NUM_HNB], in ConnHdlr we have just the one HNBAP related to the specific HNB for that conn. Once a ConnHdlr is started, that HNBAP[hnb_nr] will stop working in test_CT. We have no tests that would want that to work. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e7ffded5bd9974c444dbb567b6afa643b5b2501 Gerrit-Change-Number: 31085 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: add HNBGWVTY to ConnHdlr

by neels

Attention is currently required from: pespin, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 ) Change subject: hnbgw: add HNBGWVTY to ConnHdlr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes sure, I'm just asking whether is this needed and how will it be used :) i had tests for HNBGW memleaks that need the VTY in ConnHdlr tests ... the tests kind of didn't work out the way i wanted / may come later, or may not. I figured since there is a comment asking for a VTY port i might as well add it now before someone else (or future me) has to figure it out again -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic325fd5eb5134529012856c08336633c1413284d Gerrit-Change-Number: 31084 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 19:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: drop duplicate import

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31083 ) Change subject: hnbgw: drop duplicate import ...................................................................... hnbgw: drop duplicate import Change-Id: Ib24ecca40679fd80be2555ada208121d730c1904 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index d76ff9d..0d32edf 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -48,8 +48,6 @@ import from RANAP_Templates all; import from RAN_Adapter all; - -import from RAN_Adapter all; import from RAN_Emulation all; import from MGCP_Emulation all; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib24ecca40679fd80be2555ada208121d730c1904 Gerrit-Change-Number: 31083 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others ...................................................................... gsm_r: EF_Predefined: Decode first record different from others In their infinite wisdom, the authors of the EIRENE FFFIS for GSM-R SIM cards invented yet a new way of encoding data in SIM card files: The first record of a file may be encoded differently than further records of files. This patch implements the feature based on the newly-introduced way by which we pass the record number to the encoder and decoder methods. Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Related: OS#5784 --- M pySim/gsm_r.py 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index 5ddb04b..347c4e6 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -237,17 +237,29 @@ class EF_Predefined(LinFixedEF): """Section 8.5""" + # header and other records have different structure. WTF !?! + construct_first = Struct('next_table_type'/NextTableType, + 'id_of_next_table'/HexAdapter(Bytes(2))) + construct_others = Struct('predefined_value1'/HexAdapter(Bytes(2)), + 'string_table_index1'/Int8ub) def __init__(self, fid, name, desc): super().__init__(fid=fid, sfid=None, name=name, desc=desc, rec_len=(3, 3)) - # header and other records have different structure. WTF !?! - self._construct = Struct('next_table_type'/NextTableType, - 'id_of_next_table'/HexAdapter(Bytes(2)), - 'predefined_value1'/HexAdapter(Bytes(2)), - 'string_table_index1'/Int8ub) - # TODO: predefined value n, ... + def _decode_record_bin(self, raw_bin_data : bytes, record_nr : int) -> dict: + if record_nr == 1: + return parse_construct(self.construct_first, raw_bin_data) + else: + return parse_construct(self.construct_others, raw_bin_data) + + def _encode_record_bin(self, abstract_data : dict, record_nr : int) -> bytearray: + r = None + if record_nr == 1: + r = self.construct_first.build(abstract_data) + else: + r = self.construct_others.build(abstract_data) + return filter_dict(r) class EF_DialledVals(TransparentEF): """Section 8.6""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Gerrit-Change-Number: 31056 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31064 ) Change subject: ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS ...................................................................... ts_51_011: Fix bit-order in EF.VGCSS and EF.VBSS Those files contain a bit-mask of active group IDs stored at the respective positions in EV.VGCS and EF.VBS. However, the bit-order of each byte is reversed. Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index bb49f13..a353101 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -714,8 +714,8 @@ def __init__(self, fid='6fb2', sfid=None, name='EF.VGCSS', size=(7, 7), desc='Voice Group Call Service Status', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) - self._construct = BitStruct( - 'flags'/Bit[50], Padding(6, pattern=b'\xff')) + self._construct = BitsSwapped(BitStruct( + 'flags'/Bit[50], Padding(6, pattern=b'\xff'))) # TS 51.011 Section 10.3.24 class EF_eMLPP(TransparentEF): 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77674c23823aae71c9504b1a85cd75266edadc6f Gerrit-Change-Number: 31064 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in pysim[master]: gsm_r: Fix byte/nibble ordering of predefined_value1

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31057 ) Change subject: gsm_r: Fix byte/nibble ordering of predefined_value1 ...................................................................... gsm_r: Fix byte/nibble ordering of predefined_value1 Change-Id: Ia0dd8994556548a17a0a3101225c23e804511717 Related: OS#5784 --- M pySim/gsm_r.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index 347c4e6..edb5193 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -240,7 +240,7 @@ # header and other records have different structure. WTF !?! construct_first = Struct('next_table_type'/NextTableType, 'id_of_next_table'/HexAdapter(Bytes(2))) - construct_others = Struct('predefined_value1'/HexAdapter(Bytes(2)), + construct_others = Struct('predefined_value1'/BcdAdapter(Bytes(2)), 'string_table_index1'/Int8ub) def __init__(self, fid, name, desc): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0dd8994556548a17a0a3101225c23e804511717 Gerrit-Change-Number: 31057 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Support EF.SDN

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31065 ) Change subject: ts_51_011: Support EF.SDN ...................................................................... ts_51_011: Support EF.SDN DF.TELECOM/EF.SDN (Service Dialling Numbers) is specified in section 10.5.9 of TS 51.011 and required by EIRENE for GSM-R. Let's use the pre-existing EF.ADN decoder to decode this file. Change-Id: If91332b10138096d465a9dccf90744de2c14b2be Related: OS#5784 --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index a353101..de49e7a 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -490,7 +490,8 @@ EF_MSISDN(), EF_SMSP(), EF_SMSS(), - # LND, SDN + # LND + EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers'), EF_EXT('6f4a', None, 'EF.EXT1', 'Extension1 (ADN/SSC)'), EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN/SSC)'), EF_EXT('6f4c', None, 'EF.EXT3', 'Extension3 (SDN)'), 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If91332b10138096d465a9dccf90744de2c14b2be Gerrit-Change-Number: 31065 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: Mark *_fsm_timeouts as static

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31096 ) Change subject: Mark *_fsm_timeouts as static ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibf2a6ee5636ae7102ffd13b7497769652bcc3202 Gerrit-Change-Number: 31096 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 28 Jan 2023 15:46:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gits: fix alias 're' of 'rebase' doing nothing

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/31101 ) Change subject: gits: fix alias 're' of 'rebase' doing nothing ...................................................................... gits: fix alias 're' of 'rebase' doing nothing Change-Id: Ib861155ee988503ee142c97fac531770700761db --- M src/gits 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/01/31101/1 diff --git a/src/gits b/src/gits index 735dc4e..de2fe88 100755 --- a/src/gits +++ b/src/gits @@ -465,7 +465,7 @@ print_status() elif args.action in ['fetch', 'f']: cmd_do(['fetch'] + args.remainder) - elif args.action in ['rebase', 'r']: + elif args.action in ['rebase', 'r', 're']: cmd_rebase() elif args.action == 'sh': cmd_sh(args.remainder) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ib861155ee988503ee142c97fac531770700761db Gerrit-Change-Number: 31101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: clone repos with --recurse-submodules

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/31100 ) Change subject: gen_makefile.py: clone repos with --recurse-submodules ...................................................................... gen_makefile.py: clone repos with --recurse-submodules Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a --- M gen_makefile.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/00/31100/1 diff --git a/gen_makefile.py b/gen_makefile.py index 6267888..d45e5e8 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -178,7 +178,7 @@ .make.{proj}.clone: @echo -e "\\n\\n\\n===== $@\\n" test -d {src} || mkdir -p {src} - test -d {src_proj} || ( git -C {src} clone "{url}/{proj}" "{proj}" && git -C "{src}/{proj}" remote set-url --push origin "{push_url}/{proj}" ) + test -d {src_proj} || ( git -C {src} clone --recurse-submodules "{url}/{proj}" "{proj}" && git -C "{src}/{proj}" remote set-url --push origin "{push_url}/{proj}" ) sync touch $@ ''' -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/31100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie305422145aff257eeb6f13d82d6a978d6c2849a Gerrit-Change-Number: 31100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023