September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hlr[master]: Debian: bump compatibility level

by msuraev

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 to look at the new patch set (#2). Change subject: Debian: bump compatibility level ...................................................................... Debian: bump compatibility level See https://manpages.debian.org/bullseye/debhelper/debhelper.7.en.html for exact changes between versions Related: OS#4107 Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 --- M .gitignore M debian/compat A debian/not-installed M debian/osmo-hlr.install 4 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/81/29381/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Added support for BL-ACK, work on advanced link, small improvements

by wbokslag

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29390 ) Change subject: Added support for BL-ACK, work on advanced link, small improvements ...................................................................... Added support for BL-ACK, work on advanced link, small improvements BL-ACK with and without FCS are now supported Various improvements for advanced link parsing tetra_llc_pdu_parse now prevents further out-of-bounds reads by setting the tl sdu length to 0 whenever the tm sdu was too short for proper parsing Change-Id: If31858a16611ab7853e3ab840704dd2d9657a2a8 --- M src/tetra_llc_pdu.c 1 file changed, 92 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/90/29390/1 diff --git a/src/tetra_llc_pdu.c b/src/tetra_llc_pdu.c index 5bd1688..a4c520d 100644 --- a/src/tetra_llc_pdu.c +++ b/src/tetra_llc_pdu.c @@ -109,9 +109,10 @@ { uint8_t *cur = buf; uint8_t pdu_type; + lpp->have_fcs = 0; lpp->fcs = 0; - + lpp->fcs_invalid = 0; pdu_type = bits_to_uint(cur, 4); cur += 4; @@ -128,7 +129,7 @@ if (pdu_type == TLLC_PDUT_BL_ADATA_FCS) { if (lpp->tl_sdu_len < 32) { printf("\nWARNING frame too small for FCS (%d)\n", lpp->tl_sdu_len); - return cur-buf; + goto out; } lpp->tl_sdu_len -= 32; lpp->have_fcs = 1; @@ -147,7 +148,7 @@ if (pdu_type == TLLC_PDUT_BL_DATA_FCS) { if (lpp->tl_sdu_len < 32) { printf("\nWARNING frame too small for FCS (%d)\n", lpp->tl_sdu_len); - return cur-buf; + goto out; } lpp->tl_sdu_len -= 32; lpp->have_fcs = 1; @@ -165,7 +166,7 @@ if (pdu_type == TLLC_PDUT_BL_UDATA_FCS) { if (lpp->tl_sdu_len < 32) { printf("\nWARNING frame too small for FCS (%d)\n", lpp->tl_sdu_len); - return cur-buf; + goto out; } lpp->tl_sdu_len -= 32; lpp->have_fcs = 1; @@ -174,19 +175,46 @@ } break; + case TLLC_PDUT_BL_ACK: + case TLLC_PDUT_BL_ACK_FCS: + lpp->nr = *cur++; + lpp->tl_sdu = cur; + lpp->tl_sdu_len = len - (cur - buf); + lpp->pdu_type = TLLC_PDUT_DEC_BL_ACK; + + if (pdu_type == TLLC_PDUT_BL_ACK_FCS) { + if (lpp->tl_sdu_len < 32) { + printf("\nWARNING frame too small for FCS (%d)\n", lpp->tl_sdu_len); + goto out; + } + lpp->tl_sdu_len -= 32; + lpp->have_fcs = 1; + lpp->fcs = bits_to_uint(buf + len - 32, 32); + lpp->fcs_invalid = !tetra_llc_check_fcs(lpp, cur, lpp->tl_sdu_len); + } + break; + + case TLLC_PDUT_AL_SETUP: + /* TODO FIXME IMPLEMENT */ + lpp->pdu_type = TLLC_PDUT_DEC_AL_SETUP; + lpp->tl_sdu = cur; + lpp->tl_sdu_len = 0; + break; + case TLLC_PDUT_AL_DATA_FINAL: if (*cur++) { /* FINAL */ - cur++; + cur++; /* if set, AL_FINAL_AR */ lpp->ns = bits_to_uint(cur, 3); cur += 3; lpp->ss = bits_to_uint(cur, 8); cur += 8; - if (*cur++) { - /* FIXME: FCS */ - len -= 32; - } + lpp->tl_sdu = cur; lpp->tl_sdu_len = len - (cur - buf); lpp->pdu_type = TLLC_PDUT_DEC_AL_FINAL; + + /* Needs to be defragmented so FCS is checked elsewhere */ + lpp->have_fcs = 1; + } else { /* DATA Table 21.19 */ cur++; @@ -197,25 +225,73 @@ lpp->pdu_type = TLLC_PDUT_DEC_AL_DATA; } break; + case TLLC_PDUT_AL_UDATA_UFINAL: if (*cur++) { /* UFINAL 21.2.3.7 / Table 21.26 */ - lpp->ns = bits_to_uint(cur, 8); cur+= 8; - lpp->ss = bits_to_uint(cur, 8); cur+= 8; + lpp->ns = bits_to_uint(cur, 8); cur += 8; + lpp->ss = bits_to_uint(cur, 8); cur += 8; lpp->tl_sdu = cur; - /* FIXME: FCS */ - len -= 32; lpp->tl_sdu_len = len - (cur - buf); lpp->pdu_type = TLLC_PDUT_DEC_AL_UFINAL; + + /* Needs to be defragmented so FCS is checked elsewhere */ + lpp->have_fcs = 1; + } else { /* UDATA 21.2.3.6 / Table 21.24 */ - lpp->ns = bits_to_uint(cur, 8); cur+= 8; - lpp->ss = bits_to_uint(cur, 8); cur+= 8; + lpp->ns = bits_to_uint(cur, 8); cur += 8; + lpp->ss = bits_to_uint(cur, 8); cur += 8; lpp->tl_sdu = cur; lpp->tl_sdu_len = len - (cur - buf); lpp->pdu_type = TLLC_PDUT_DEC_AL_UDATA; } break; + + case TLLC_PDUT_AL_ACK_RNR: + /* TODO FIXME IMPLEMENT */ + if (*cur++) { + /* AL-ACK 21.2.3.1 */ + lpp->pdu_type = TLLC_PDUT_DEC_AL_ACK; + } else { + /* AL-RNR 21.2.3.1 */ + lpp->pdu_type = TLLC_PDUT_DEC_AL_RNR; + } + + lpp->tl_sdu = cur; + lpp->tl_sdu_len = 0; + break; + + case TLLC_PDUT_AL_RECONNECT: + /* TODO FIXME IMPLEMENT */ + lpp->pdu_type = TLLC_PDUT_DEC_AL_RECONNECT; + lpp->tl_sdu = cur; + lpp->tl_sdu_len = 0; + break; + + case TLLD_PDUT_AL_DISC: + /* TODO FIXME IMPLEMENT */ + lpp->pdu_type = TLLC_PDUT_DEC_AL_DISC; + lpp->tl_sdu = cur; + lpp->tl_sdu_len = 0; + break; + + case TLLC_PDUT_SUPPL: + case TLLC_PDUT_L2SIG: + /* TODO FIXME IMPLEMENT */ + default: + /* Prevent further parsing */ + lpp->pdu_type = TLLC_PDUT_DEC_UNKNOWN; + lpp->tl_sdu = cur; + lpp->tl_sdu_len = 0; } - return (cur - buf); + +out: + /* Sanity check to prevent (further) out of bounds reads */ + if (len < cur - buf) { + lpp->tl_sdu_len = 0; + return len; + } + + return cur - buf; } -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If31858a16611ab7853e3ab840704dd2d9657a2a8 Gerrit-Change-Number: 29390 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: only compute filter when opt_afc is enabled

by wbokslag

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29389 ) Change subject: only compute filter when opt_afc is enabled ...................................................................... only compute filter when opt_afc is enabled Change-Id: Icc42a70b07600267ccfad3969b738b3b4a606a61 --- M src/float_to_bits.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/89/29389/1 diff --git a/src/float_to_bits.c b/src/float_to_bits.c index 89d0421..6948f24 100644 --- a/src/float_to_bits.c +++ b/src/float_to_bits.c @@ -81,13 +81,11 @@ int fd, fd_out, opt; int opt_verbose = 0; int opt_afc = 0; - float filter = 0; float filter_val = 0.0001; float filter_goal = 0; int sym; - while ((opt = getopt(argc, argv, "vaf:F:")) != -1) { switch (opt) { case 'v': @@ -141,11 +139,10 @@ rc /= sizeof(*fl); int i; for (i = 0; i < rc; ++i) { - - if ((fl[i] > -MAXVAL) && (fl[i] < MAXVAL)) { - filter = filter * (1.0 - filter_val) + (fl[i] - filter_goal) * filter_val; - } if (opt_afc) { + if ((fl[i] > -MAXVAL) && (fl[i] < MAXVAL)) { + filter = filter * (1.0 - filter_val) + (fl[i] - filter_goal) * filter_val; + } sym = process_sym_fl(fl[i]-filter); } else { sym = process_sym_fl(fl[i]); -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Icc42a70b07600267ccfad3969b738b3b4a606a61 Gerrit-Change-Number: 29389 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Support parsing of multiple mac resources in the same timeslot

by wbokslag

Attention is currently required from: wbokslag. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 to look at the new patch set (#2). Change subject: Support parsing of multiple mac resources in the same timeslot ...................................................................... Support parsing of multiple mac resources in the same timeslot Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 --- M src/lower_mac/tetra_lower_mac.c M src/tetra_gsmtap.c M src/tetra_upper_mac.c 3 files changed, 24 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/88/29388/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 Gerrit-Change-Number: 29388 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Support parsing of multiple mac resources in the same timeslot

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29388 ) Change subject: Support parsing of multiple mac resources in the same timeslot ...................................................................... Patch Set 1: (1 comment) File src/lower_mac/tetra_lower_mac.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-tetra-lint-26): https://gerrit.osmocom.org/c/osmo-tetra/+/29388/comment/a5a81fb4_f19c196f PS1, Line 316: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 Gerrit-Change-Number: 29388 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 18 Sep 2022 09:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Support parsing of multiple mac resources in the same timeslot

by wbokslag

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29388 ) Change subject: Support parsing of multiple mac resources in the same timeslot ...................................................................... Support parsing of multiple mac resources in the same timeslot Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 --- M src/lower_mac/tetra_lower_mac.c M src/tetra_gsmtap.c M src/tetra_upper_mac.c 3 files changed, 25 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/88/29388/1 diff --git a/src/lower_mac/tetra_lower_mac.c b/src/lower_mac/tetra_lower_mac.c index bf0896b..2ea03cb 100644 --- a/src/lower_mac/tetra_lower_mac.c +++ b/src/lower_mac/tetra_lower_mac.c @@ -307,10 +307,28 @@ /* FIXME: do something */ break; } - /* send Rx time along with the TMV-UNITDATA.ind primitive */ - memcpy(&tup->tdma_time, &tcd->time, sizeof(tup->tdma_time)); - upper_mac_prim_recv(&ttp->oph, tms); + int parsed = 0; + int offset = 0; + unsigned char *orig_head = msg->head; + unsigned char *orig_tail = msg->tail; + while (parsed != -1 && offset < tbp->type1_bits - 16) { + + /* send Rx time along with the TMV-UNITDATA.ind primitive */ + memcpy(&tup->tdma_time, &tcd->time, sizeof(tup->tdma_time)); + parsed = upper_mac_prim_recv(&ttp->oph, tms); + + /* Increment head and l1h ptrs and reset tail to end of msg (may be altered by removing FCS) */ + offset += parsed; + msg->head = orig_head + offset; + msg->tail = orig_tail; + msg->len = msg->tail - msg->head; + msg->l1h = msg->head; + msg->l2h = 0; + msg->l3h = 0; + msg->l4h = 0; + } + + talloc_free(msg); + talloc_free(ttp); } - - diff --git a/src/tetra_gsmtap.c b/src/tetra_gsmtap.c index 3f872c5..3e06223 100644 --- a/src/tetra_gsmtap.c +++ b/src/tetra_gsmtap.c @@ -64,16 +64,11 @@ int tetra_gsmtap_sendmsg(struct msgb *msg) { - int rc; - if (g_gti) { - rc = gsmtap_sendmsg_free(g_gti, msg); + return gsmtap_sendmsg(g_gti, msg); } else { - msgb_free(msg); - rc = 0; + return 0; } - - return rc; } int tetra_gsmtap_init(const char *host, uint16_t port) diff --git a/src/tetra_upper_mac.c b/src/tetra_upper_mac.c index a499c66..1a9e3c3 100644 --- a/src/tetra_upper_mac.c +++ b/src/tetra_upper_mac.c @@ -554,8 +554,5 @@ break; } - talloc_free(op->msg); - talloc_free(op); - return pdu_bits; } -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 Gerrit-Change-Number: 29388 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC f...

by wbokslag

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 ) Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ...................................................................... Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 --- M src/lower_mac/tetra_lower_mac.c M src/tetra_upper_mac.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/86/29386/1 diff --git a/src/lower_mac/tetra_lower_mac.c b/src/lower_mac/tetra_lower_mac.c index f6a893a..bf0896b 100644 --- a/src/lower_mac/tetra_lower_mac.c +++ b/src/lower_mac/tetra_lower_mac.c @@ -273,7 +273,7 @@ switch (type) { case TPSAP_T_SB1: printf("TMB-SAP SYNC CC %s(0x%02x) ", osmo_ubit_dump(type2+4, 6), bits_to_uint(type2+4, 6)); - printf("TN %s(%u) ", osmo_ubit_dump(type2+10, 2), bits_to_uint(type2+10, 2)); + printf("TN %s(%u) ", osmo_ubit_dump(type2+10, 2), bits_to_uint(type2+10, 2) + 1); printf("FN %s(%2u) ", osmo_ubit_dump(type2+12, 5), bits_to_uint(type2+12, 5)); printf("MN %s(%2u) ", osmo_ubit_dump(type2+17, 6), bits_to_uint(type2+17, 6)); printf("MCC %s(%u) ", osmo_ubit_dump(type2+31, 10), bits_to_uint(type2+31, 10)); @@ -281,7 +281,7 @@ /* obtain information from SYNC PDU */ if (tup->crc_ok) { tcd->colour_code = bits_to_uint(type2+4, 6); - tcd->time.tn = bits_to_uint(type2+10, 2); + tcd->time.tn = bits_to_uint(type2+10, 2) + 1; tcd->time.fn = bits_to_uint(type2+12, 5); tcd->time.mn = bits_to_uint(type2+17, 6); tcd->mcc = bits_to_uint(type2+31, 10); diff --git a/src/tetra_upper_mac.c b/src/tetra_upper_mac.c index 0e090cf..f6b34bf 100644 --- a/src/tetra_upper_mac.c +++ b/src/tetra_upper_mac.c @@ -276,7 +276,7 @@ return 0; gsmtap_msg = tetra_gsmtap_makemsg(&tup->tdma_time, tup->lchan, - tup->tdma_time.tn, + tup->tdma_time.tn-1, /* expects timeslot in 0-3 range */ /* FIXME: */ 0, 0, 0, msg->l1h, msgb_l1len(msg), tms); if (gsmtap_msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 Gerrit-Change-Number: 29386 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: added support for fill bits and basic link defragmentation (also than...

by wbokslag

wbokslag has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 --- M src/tetra-rx.c M src/tetra_llc_pdu.h M src/tetra_mac_pdu.c M src/tetra_mac_pdu.h M src/tetra_upper_mac.c M src/tetra_upper_mac.h 6 files changed, 306 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/87/29387/1 diff --git a/src/tetra-rx.c b/src/tetra-rx.c index ed4d252..b6d2d0e 100644 --- a/src/tetra-rx.c +++ b/src/tetra-rx.c @@ -33,6 +33,7 @@ #include <phy/tetra_burst.h> #include <phy/tetra_burst_sync.h> #include "tetra_gsmtap.h" +#include "tetra_upper_mac.h" void *tetra_tall_ctx; @@ -71,6 +72,7 @@ } tetra_gsmtap_init("localhost", 0); + upper_mac_init_fragslots(); while (1) { uint8_t buf[64]; diff --git a/src/tetra_llc_pdu.h b/src/tetra_llc_pdu.h index 4d260c7..bcbc951 100644 --- a/src/tetra_llc_pdu.h +++ b/src/tetra_llc_pdu.h @@ -77,8 +77,8 @@ uint32_t fcs; /* FCS value extracted from pdu */ uint8_t fcs_invalid; /* 1 if extracted FCS does not match computed FCS */ - uint8_t *tl_sdu; /* pointer to bitbuf */ - uint8_t tl_sdu_len; /* in bits */ + uint8_t *tl_sdu; /* pointer to bitbuf */ + uint32_t tl_sdu_len; /* in bits */ }; /* parse a received LLC PDU and parse it into 'lpp' */ diff --git a/src/tetra_mac_pdu.c b/src/tetra_mac_pdu.c index d114703..5c5f5f2 100644 --- a/src/tetra_mac_pdu.c +++ b/src/tetra_mac_pdu.c @@ -61,23 +61,22 @@ sid->cck_id = bits_to_uint(cur, 16); else sid->hyperframe_number = bits_to_uint(cur, 16); - + sid->option_field = bits_to_uint(cur, 2); cur += 2; - switch(sid->option_field) - { - case TETRA_MAC_OPT_FIELD_EVEN_MULTIFRAME: // Even multiframe definition for TS mode - case TETRA_MAC_OPT_FIELD_ODD_MULTIFRAME: // Odd multiframe definition for TS mode - sid->frame_bitmap = bits_to_uint(cur, 20); cur += 20; - break; - case TETRA_MAC_OPT_FIELD_ACCESS_CODE: // Default definition for access code A - sid->access_code = bits_to_uint(cur, 20); cur += 20; - break; - case TETRA_MAC_OPT_FIELD_EXT_SERVICES: // Extended services broadcast - sid->ext_service = bits_to_uint(cur, 20); cur += 20; - break; + switch (sid->option_field) { + case TETRA_MAC_OPT_FIELD_EVEN_MULTIFRAME: // Even multiframe definition for TS mode + case TETRA_MAC_OPT_FIELD_ODD_MULTIFRAME: // Odd multiframe definition for TS mode + sid->frame_bitmap = bits_to_uint(cur, 20); cur += 20; + break; + case TETRA_MAC_OPT_FIELD_ACCESS_CODE: // Default definition for access code A + sid->access_code = bits_to_uint(cur, 20); cur += 20; + break; + case TETRA_MAC_OPT_FIELD_EXT_SERVICES: // Extended services broadcast + sid->ext_service = bits_to_uint(cur, 20); cur += 20; + break; } - decode_d_mle_sysinfo(&sid->mle_si, si_bits + 124-42); // could be also cur due to previous fixes + decode_d_mle_sysinfo(&sid->mle_si, si_bits + 124 - 42); // could be also cur due to previous fixes } static const uint8_t addr_len_by_type[] = { @@ -91,16 +90,16 @@ }; /* 21.5.2 */ -static int macpdu_decode_chan_alloc(struct tetra_chan_alloc_decoded *cad, const uint8_t *bits) +int macpdu_decode_chan_alloc(struct tetra_chan_alloc_decoded *cad, const uint8_t *bits) { const uint8_t *cur = bits; - cad->type = bits_to_uint(cur, 2); cur += 2; - cad->timeslot = bits_to_uint(cur, 4); cur += 4; - cad->ul_dl = bits_to_uint(cur, 2); cur += 2; - cad->clch_perm = *cur++; - cad->cell_chg_f = *cur++; - cad->carrier_nr = bits_to_uint(cur, 12); cur += 12; + cad->type = bits_to_uint(cur, 2); cur += 2; + cad->timeslot = bits_to_uint(cur, 4); cur += 4; + cad->ul_dl = bits_to_uint(cur, 2); cur += 2; + cad->clch_perm = *cur++; + cad->cell_chg_f = *cur++; + cad->carrier_nr = bits_to_uint(cur, 12); cur += 12; cad->ext_carr_pres = *cur++; if (cad->ext_carr_pres) { @@ -115,15 +114,15 @@ cur += 2; } if (cad->ul_dl == 0) { - cad->aug.ul_dl_ass = bits_to_uint(cur, 2); cur += 2; - cad->aug.bandwidth = bits_to_uint(cur, 3); cur += 3; - cad->aug.modulation = bits_to_uint(cur, 3); cur += 3; - cad->aug.max_ul_qam = bits_to_uint(cur, 3); cur += 3; + cad->aug.ul_dl_ass = bits_to_uint(cur, 2); cur += 2; + cad->aug.bandwidth = bits_to_uint(cur, 3); cur += 3; + cad->aug.modulation = bits_to_uint(cur, 3); cur += 3; + cad->aug.max_ul_qam = bits_to_uint(cur, 3); cur += 3; cur += 3; /* reserved */ - cad->aug.conf_chan_stat=bits_to_uint(cur, 3); cur += 3; - cad->aug.bs_imbalance = bits_to_uint(cur, 4); cur += 4; - cad->aug.bs_tx_rel = bits_to_uint(cur, 5); cur += 5; - cad->aug.napping_sts = bits_to_uint(cur, 2); cur += 2; + cad->aug.conf_chan_stat = bits_to_uint(cur, 3); cur += 3; + cad->aug.bs_imbalance = bits_to_uint(cur, 4); cur += 4; + cad->aug.bs_tx_rel = bits_to_uint(cur, 5); cur += 5; + cad->aug.napping_sts = bits_to_uint(cur, 2); cur += 2; if (cad->aug.napping_sts == 1) cur += 11; /* napping info 21.5.2c */ cur += 4; /* reserved */ @@ -160,9 +159,6 @@ return dec_tbl[in & 0xf]; } -#define MACPDU_LEN_2ND_STOLEN -1 -#define MACPDU_LEN_START_FRAG -2 - static int decode_length(unsigned int length_ind) { /* FIXME: Y2/Z2 for non-pi4 DQPSK */ @@ -388,14 +384,14 @@ } static const struct value_string addr_type_names[] = { - { ADDR_TYPE_NULL, "Null PDU" }, - { ADDR_TYPE_SSI, "SSI" }, - { ADDR_TYPE_EVENT_LABEL,"Event Label" }, - { ADDR_TYPE_USSI, "USSI (migrading MS un-exchanged)" }, - { ADDR_TYPE_SMI, "SMI (management)" }, - { ADDR_TYPE_SSI_EVENT, "SSI + Event Label" }, - { ADDR_TYPE_SSI_USAGE, "SSI + Usage Marker" }, - { ADDR_TYPE_SMI_EVENT, "SMI + Event Label" }, + { ADDR_TYPE_NULL, "Null PDU" }, + { ADDR_TYPE_SSI, "SSI" }, + { ADDR_TYPE_EVENT_LABEL, "Event Label" }, + { ADDR_TYPE_USSI, "USSI (migrading MS un-exchanged)" }, + { ADDR_TYPE_SMI, "SMI (management)" }, + { ADDR_TYPE_SSI_EVENT, "SSI + Event Label" }, + { ADDR_TYPE_SSI_USAGE, "SSI + Usage Marker" }, + { ADDR_TYPE_SMI_EVENT, "SMI + Event Label" }, { 0, NULL } }; const char *tetra_get_addr_t_name(uint8_t addrt) diff --git a/src/tetra_mac_pdu.h b/src/tetra_mac_pdu.h index d243062..4b1baeb 100644 --- a/src/tetra_mac_pdu.h +++ b/src/tetra_mac_pdu.h @@ -1,6 +1,9 @@ #ifndef TETRA_MAC_PDU #define TETRA_MAC_PDU +#define MACPDU_LEN_2ND_STOLEN -2 +#define MACPDU_LEN_START_FRAG -1 + enum tetra_mac_pdu_types { TETRA_PDU_T_MAC_RESOURCE = 0, TETRA_PDU_T_MAC_FRAG_END = 1, @@ -157,7 +160,7 @@ enum tetra_mac_res_addr_type { ADDR_TYPE_NULL = 0, ADDR_TYPE_SSI = 1, - ADDR_TYPE_EVENT_LABEL = 2, + ADDR_TYPE_EVENT_LABEL = 2, ADDR_TYPE_USSI = 3, ADDR_TYPE_SMI = 4, ADDR_TYPE_SSI_EVENT = 5, @@ -234,6 +237,8 @@ }; int macpdu_decode_resource(struct tetra_resrc_decoded *rsd, const uint8_t *bits, uint8_t is_decrypted); +int macpdu_decode_chan_alloc(struct tetra_chan_alloc_decoded *cad, const uint8_t *bits); + const char *tetra_addr_dump(const struct tetra_addr *addr); const char *tetra_get_ul_dl_name(uint8_t ul_dl); diff --git a/src/tetra_upper_mac.c b/src/tetra_upper_mac.c index f6b34bf..a499c66 100644 --- a/src/tetra_upper_mac.c +++ b/src/tetra_upper_mac.c @@ -40,7 +40,30 @@ static int rx_tm_sdu(struct tetra_mac_state *tms, struct msgb *msg, unsigned int len); -static void rx_bcast(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) + +struct fragslot fragslots[FRAGSLOT_NR_SLOTS]; /* slots are 1-4 but sometimes slot==0 */ + +void upper_mac_init_fragslots() +{ + memset(&fragslots, 0, sizeof(fragslots)); + for (int i = 0; i < FRAGSLOT_NR_SLOTS; i++) { + fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot"); + msgb_reset(fragslots[i].msgb); + } +} + +static int get_num_fill_bits(const unsigned char *l1h, int len_with_fillbits) +{ + for (int i = 1; i < len_with_fillbits; i++) { + if (l1h[len_with_fillbits - i] == 1) { + return i; + } + } + printf("WARNING get_fill_bits_len: no 1 bit within %d bytes from end\n", len_with_fillbits); + return 0; +} + +static int rx_bcast(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) { struct msgb *msg = tmvp->oph.msg; struct tetra_si_decoded sid; @@ -73,6 +96,7 @@ sid.mle_si.bs_service_details & (1 << i) ? 1 : 0); memcpy(&tms->last_sid, &sid, sizeof(sid)); + return -1; /* FIXME check this indeed fills slot */ } const char *tetra_alloc_dump(const struct tetra_chan_alloc_decoded *cad, struct tetra_mac_state *tms) @@ -141,8 +165,13 @@ memset(&lpp, 0, sizeof(lpp)); tetra_llc_pdu_parse(&lpp, bits, len); - printf("TM-SDU(%s,%u,%u): ", + printf("TM-SDU(%s,%u,%u)", tetra_get_llc_pdut_dec_name(lpp.pdu_type), lpp.ns, lpp.ss); + if (lpp.have_fcs) { + printf("(FCS: %s)", lpp.fcs_invalid ? "BAD" : "OK"); + } + printf(": "); + if (lpp.tl_sdu && lpp.ss == 0) { msg->l3h = lpp.tl_sdu; rx_tl_sdu(tms, msg, lpp.tl_sdu_len); @@ -150,22 +179,43 @@ return len; } -static void rx_resrc(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) +static int rx_resrc(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) { struct msgb *msg = tmvp->oph.msg; struct tetra_resrc_decoded rsd; - int tmpdu_offset; + struct msgb *fragmsgb; + int tmpdu_offset, slot; + int pdu_bits; /* Full length of pdu, including fill bits */ memset(&rsd, 0, sizeof(rsd)); tmpdu_offset = macpdu_decode_resource(&rsd, msg->l1h, 0); - msg->l2h = msg->l1h + tmpdu_offset; - printf("RESOURCE Encr=%u, Length=%d Addr=%s ", - rsd.encryption_mode, rsd.macpdu_length, + if (rsd.macpdu_length == MACPDU_LEN_2ND_STOLEN) { + pdu_bits = -1; /* Fills slot */ + printf("WARNING pdu with MACPDU_LEN_2ND_STOLEN, not implemented\n"); + } else if (rsd.macpdu_length == MACPDU_LEN_START_FRAG) { + pdu_bits = -1; /* Fills slot */ + } else { + pdu_bits = rsd.macpdu_length * 8; /* Length given */ + msg->tail = msg->head + pdu_bits; + } + + /* Strip fill bits */ + if (rsd.fill_bits) { + int num_fill_bits = get_num_fill_bits(msg->l1h, msgb_l1len(msg)); + msg->tail -= num_fill_bits; + } + + /* We now have accurate length and start of TM-SDU, set LLC start in msg->l2h */ + msg->l2h = msg->l1h + tmpdu_offset; + printf("RESOURCE Encr=%u, len=%d l1_len=%d l2_len %d Addr=%s ", + rsd.encryption_mode, rsd.macpdu_length, msgb_l1len(msg), msgb_l2len(msg), tetra_addr_dump(&rsd.addr)); - if (rsd.addr.type == ADDR_TYPE_NULL) + if (rsd.addr.type == ADDR_TYPE_NULL) { + pdu_bits = -1; /* No more PDUs in slot */ goto out; + } if (rsd.chan_alloc_pres) printf("ChanAlloc=%s ", tetra_alloc_dump(&rsd.cad, tms)); @@ -174,20 +224,152 @@ printf("SlotGrant=%u/%u ", rsd.slot_granting.nr_slots, rsd.slot_granting.delay); - if (rsd.macpdu_length > 0 && rsd.encryption_mode == 0) { - int len_bits = rsd.macpdu_length*8; - if (msg->l2h + len_bits > msg->l1h + msgb_l1len(msg)) - len_bits = msgb_l1len(msg) - tmpdu_offset; - rx_tm_sdu(tms, msg, len_bits); + if (rsd.macpdu_length != MACPDU_LEN_START_FRAG || !REASSEMBLE_FRAGMENTS) { + /* Non-fragmented resource (or no reassembly desired) */ + if (!rsd.is_encrypted) { + rx_tm_sdu(tms, msg, msgb_l2len(msg)); + } + } else { + /* Fragmented resource */ + slot = tmvp->u.unitdata.tdma_time.tn; + if (fragslots[slot].active) { + printf("\nWARNING: fragment slot still active\n"); + } + + fragmsgb = fragslots[slot].msgb; + msgb_reset(fragmsgb); + + /* Copy l2 part to fragmsgb. l3h is constructed once all fragments are merged */ + fragmsgb->l1h = msgb_put(fragmsgb, msgb_l1len(msg)); + fragmsgb->l2h = fragmsgb->l1h + tmpdu_offset; + fragmsgb->l3h = 0; + memcpy(fragmsgb->l2h, msg->l2h, msgb_l2len(msg)); + + printf("\nFRAG-START slot=%d len=%d msgb=%s\n", slot, msgb_l2len(fragmsgb), osmo_ubit_dump(fragmsgb->l2h, msgb_l2len(msg))); + fragslots[slot].active = 1; + fragslots[slot].num_frags = 1; + fragslots[slot].length = msgb_l2len(msg); + fragslots[slot].encryption = rsd.encryption_mode; } tms->ssi = rsd.addr.ssi; out: printf("\n"); + return pdu_bits; } -static void rx_suppl(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) +void append_frag_bits(int slot, uint8_t *bits, int bitlen) +{ + struct msgb *fragmsgb; + fragmsgb = fragslots[slot].msgb; + if (fragmsgb->len + bitlen > fragmsgb->data_len) { + printf(" WARNING: FRAG LENGTH ERROR!\n"); + return; + } + unsigned char *append_ptr = msgb_put(fragmsgb, bitlen); + memcpy(append_ptr, bits, bitlen); + + fragslots[slot].length = fragslots[slot].length + bitlen; + fragslots[slot].num_frags++; + fragslots[slot].age = 0; +} + +static int rx_macfrag(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) +{ + struct msgb *msg = tmvp->oph.msg; + int slot = tmvp->u.unitdata.tdma_time.tn; + uint8_t *bits = msg->l1h; + uint8_t fillbits_present; + int n = 0; + int m = 0; + + if (fragslots[slot].active) { + m = 2; n = n + m; /* MAC-FRAG/END (01) */ + m = 1; n = n + m; /* MAC-FRAG (0) */ + m = 1; fillbits_present = bits_to_uint(bits + n, m); n = n + m; + msg->l2h = msg->l1h + n; + + /* MAC-FRAG will always fill remainder of the slot, but fill bits may be present */ + if (fillbits_present) { + int num_fill_bits = get_num_fill_bits(msg->l1h, msgb_l1len(msg)); + msgb_get(msg, num_fill_bits); + } + + /* Add frag to fragslot buffer */ + struct msgb *fragmsgb = fragslots[slot].msgb; + append_frag_bits(slot, msg->l2h, msgb_l2len(msg)); + printf("FRAG-CONT slot=%d added=%d msgb=%s\n", slot, msgb_l2len(msg), osmo_ubit_dump(fragmsgb->l2h, msgb_l2len(fragmsgb))); + } else { + printf("WARNING got fragment without start packet for slot=%d\n", slot); + } + return -1; /* Always fills slot */ +} + +static int rx_macend(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) +{ + struct msgb *msg = tmvp->oph.msg; + int slot = tmvp->u.unitdata.tdma_time.tn; + struct tetra_resrc_decoded rsd; + uint8_t *bits = msg->l1h; + uint8_t fillbits_present, chanalloc_present, length_indicator, slot_granting; + int num_fill_bits; + struct msgb *fragmsgb; + int n = 0; + int m = 0; + + memset(&rsd, 0, sizeof(rsd)); + m = 2; n = n + m; /* MAC-FRAG/END (01) */ + m = 1; n = n + m; /* MAC-END (1) */ + m = 1; fillbits_present = bits_to_uint(bits + n, m); n = n + m; + m = 1; n = n + m; /* position_of_grant */ + m = 6; length_indicator = bits_to_uint(bits + n, m); n = n + m; + + fragmsgb = fragslots[slot].msgb; + if (fragslots[slot].active) { + + /* FIXME: handle napping bit in d8psk and qam */ + m = 1; slot_granting = bits_to_uint(bits + n, m); n = n + m; + if (slot_granting) { + /* FIXME: multiple slot granting in qam */ + m = 8; /* basic slot granting */ n = n + m; + } + m = 1; chanalloc_present = bits_to_uint(bits + n, m); n = n + m; + + /* Determine msg len, strip fill bits if any */ + msg->tail = msg->head + length_indicator * 8; + if (fillbits_present) { + num_fill_bits = get_num_fill_bits(msg->l1h, msgb_l1len(msg)); + msg->tail -= num_fill_bits; + } + + /* Parse chanalloc element (if present) and update l2 offsets */ + if (chanalloc_present) { + m = macpdu_decode_chan_alloc(&rsd.cad, bits + n); n = n + m; + } + msg->l2h = msg->l1h + n; + append_frag_bits(slot, msg->l2h, msgb_l2len(msg)); + printf("FRAG-END slot=%d added=%d msgb=%s\n", slot, msgb_l2len(msg), osmo_ubit_dump(fragmsgb->l2h, msgb_l2len(fragmsgb))); + + /* Message is completed inside fragmsgb now */ + if (!fragslots[slot].encryption) { + rx_tm_sdu(tms, fragmsgb, fragslots[slot].length); + } + } else { + printf("FRAG: got end frag with len %d without start packet for slot=%d\n", length_indicator * 8, slot); + } + + msgb_reset(fragmsgb); + fragslots[slot].active = 0; + fragslots[slot].encryption = 0; + fragslots[slot].num_frags = 0; + fragslots[slot].length = 0; + fragslots[slot].age = 0; + return length_indicator * 8; +} + + +static int rx_suppl(struct tetra_tmvsap_prim *tmvp, struct tetra_mac_state *tms) { //struct tmv_unitdata_param *tup = &tmvp->u.unitdata; struct msgb *msg = tmvp->oph.msg; @@ -214,6 +396,7 @@ rx_tm_sdu(tms, msg, 100); printf("\n"); + return -1; /* TODO FIXME check length */ } static void dump_access(struct tetra_access_field *acc, unsigned int num) @@ -257,6 +440,7 @@ uint8_t pdu_type = bits_to_uint(msg->l1h, 2); const char *pdu_name; struct msgb *gsmtap_msg; + int len_parsed; if (tup->lchan == TETRA_LC_BSCH) pdu_name = "SYNC"; @@ -273,7 +457,7 @@ tup->crc_ok, pdu_name); if (!tup->crc_ok) - return 0; + return -1; gsmtap_msg = tetra_gsmtap_makemsg(&tup->tdma_time, tup->lchan, tup->tdma_time.tn-1, /* expects timeslot in 0-3 range */ @@ -282,6 +466,26 @@ if (gsmtap_msg) tetra_gsmtap_sendmsg(gsmtap_msg); + /* age out old fragments */ + if (REASSEMBLE_FRAGMENTS && tup->tdma_time.fn == 18) { + int i; + for (i = 0; i < FRAGSLOT_NR_SLOTS; i++) { + if (fragslots[i].active) { + fragslots[i].age++; + if (fragslots[i].age > N203) { + printf("\nFRAG: aged out old fragments for slot=%d fragments=%d length=%d timer=%d\n", i, fragslots[i].num_frags, fragslots[i].length, fragslots[i].age); + msgb_reset(fragslots[i].msgb); + fragslots[i].num_frags = 0; + fragslots[i].active = 0; + fragslots[i].length = 0; + fragslots[i].age = 0; + fragslots[i].encryption = 0; + } + } + } + } + + len_parsed = -1; /* Default for cases where slot is filled or otherwise irrelevant */ switch (tup->lchan) { case TETRA_LC_AACH: rx_aach(tmvp, tms); @@ -291,24 +495,35 @@ case TETRA_LC_SCH_F: switch (pdu_type) { case TETRA_PDU_T_BROADCAST: - rx_bcast(tmvp, tms); + len_parsed = rx_bcast(tmvp, tms); break; case TETRA_PDU_T_MAC_RESOURCE: - rx_resrc(tmvp, tms); + len_parsed = rx_resrc(tmvp, tms); break; case TETRA_PDU_T_MAC_SUPPL: - rx_suppl(tmvp, tms); + len_parsed = rx_suppl(tmvp, tms); break; case TETRA_PDU_T_MAC_FRAG_END: - if (msg->l1h[3] == TETRA_MAC_FRAGE_FRAG) { - printf("FRAG/END FRAG: "); - msg->l2h = msg->l1h+4; - rx_tm_sdu(tms, msg, 100 /*FIXME*/); - printf("\n"); - } else - printf("FRAG/END END\n"); + if (REASSEMBLE_FRAGMENTS) { + if (msg->l1h[3] == TETRA_MAC_FRAGE_FRAG) { + len_parsed = rx_macfrag(tmvp, tms); + } else { + len_parsed = rx_macend(tmvp, tms); + } + } else { + len_parsed = -1; /* Can't determine len */ + if (msg->l1h[3] == TETRA_MAC_FRAGE_FRAG) { + printf("FRAG/END FRAG: "); + msg->l2h = msg->l1h+4; + rx_tm_sdu(tms, msg, 100 /*FIXME*/); + printf("\n"); + } else { + printf("FRAG/END END\n"); + } + } break; default: + len_parsed = -1; /* Can't determine len */ printf("STRANGE pdu=%u\n", pdu_type); break; } @@ -320,19 +535,19 @@ break; } - return 0; + return len_parsed; } int upper_mac_prim_recv(struct osmo_prim_hdr *op, void *priv) { struct tetra_tmvsap_prim *tmvp; struct tetra_mac_state *tms = priv; - int rc; + int pdu_bits = -1; switch (op->sap) { case TETRA_SAP_TMV: tmvp = (struct tetra_tmvsap_prim *) op; - rc = rx_tmv_unitdata_ind(tmvp, tms); + pdu_bits = rx_tmv_unitdata_ind(tmvp, tms); break; default: printf("primitive on unknown sap\n"); @@ -342,5 +557,5 @@ talloc_free(op->msg); talloc_free(op); - return rc; + return pdu_bits; } diff --git a/src/tetra_upper_mac.h b/src/tetra_upper_mac.h index 9e77b57..9460604 100644 --- a/src/tetra_upper_mac.h +++ b/src/tetra_upper_mac.h @@ -3,6 +3,22 @@ #include "tetra_prim.h" +/* Define whether to reassemble MAC-RESOURCE / MAC-FRAG / MAC-END */ +#define REASSEMBLE_FRAGMENTS 1 +#define FRAGSLOT_NR_SLOTS 5 /* Slot 0 is unused */ + +#define N203 6 /* see N.203 in the tetra docs, should be 4 or greater */ +#define FRAGSLOT_MSGB_SIZE 8192 +struct fragslot { + int active; + int age; + struct msgb *msgb; + int length; + int num_frags; + int encryption; +}; + +void upper_mac_init_fragslots(); int upper_mac_prim_recv(struct osmo_prim_hdr *op, void *priv); #endif -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: doc: Document use of Osmux in IPA Abis against OsmoBTS

by fixeria

Attention is currently required from: osmith, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29351 ) Change subject: doc: Document use of Osmux in IPA Abis against OsmoBTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29351 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41788f8d3bc29735cc30516f429311b73ba71910 Gerrit-Change-Number: 29351 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 06:41:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: vty: Allow setting LAC as hexadecimal value

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29358 ) Change subject: vty: Allow setting LAC as hexadecimal value ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9090d73ae9d39244b79b9dbafa1b164faebabc52 Gerrit-Change-Number: 29358 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 06:32:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022