September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-tetra[master]: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC f...

by fixeria

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 ) Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-tetra/+/29386/comment/67aed41e_928c7f9b PS1, Line 7: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame > As you can see in the tetra_tdma_time struct definition comments in tetra_tdma. […] Thanks for explaining. Please add this to the commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 Gerrit-Change-Number: 29386 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 13:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: wbokslag <w.bokslag(a)midnightblue.nl> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Support parsing of multiple mac resources in the same timeslot

by fixeria

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29388 ) Change subject: Support parsing of multiple mac resources in the same timeslot ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ic2956a5f10cffe296b76a290a0d16f45461eb2e7 Gerrit-Change-Number: 29388 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 13:08:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: added support for fill bits and basic link defragmentation (also than...

by fixeria

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... Patch Set 1: Code-Review-1 (6 comments) File src/tetra_llc_pdu.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/4e9c20e6_86624c56 PS1, Line 80: unrelated ws changed File src/tetra_mac_pdu.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/bcfe051a_f99de347 PS1, Line 160: unrelated ws change File src/tetra_mac_pdu.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/32eca4db_e3c142cb PS1, Line 64: In this particular place, it's a good change. But it should be done in a separate patch. https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/877cd340_dd50c049 PS1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2; Please keep the original formatting in this patch. Unrelated changes make it harder to see what's actually done during code review (and probably later). https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/ec5bc71b_677ea78b PS1, Line 387: why are you changing this? maybe it's your editor doing this automatically? File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/d9f119f8_845d348f PS1, Line 51: msgb_reset I don't think calling msgb_reset() is needed right after calling msgb_alloc(). It's already reset when allocated. Correct me if I am wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 13:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC f...

by wbokslag

Attention is currently required from: fixeria. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 ) Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-tetra/+/29386/comment/1749fae9_1ea77205 PS1, Line 7: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame > Would be good to see the motivation for this change in the commit message. […] As you can see in the tetra_tdma_time struct definition comments in tetra_tdma.h, it is always supposed to be in this range. Also, tetra_burst_sync_in increments the timeslot number when synchronized, ultimately using the function normalize_tn in tetra_tdma.c which also only works properly on the uses the 1-4 range. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 Gerrit-Change-Number: 29386 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 13:03:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-tetra[master]: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC f...

by fixeria

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29386 ) Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-tetra/+/29386/comment/2f6f3f28_d1d41a66 PS1, Line 7: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame Would be good to see the motivation for this change in the commit message. Why is it needed to shift the timeslot number value from 0..3 to 1..4? -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66 Gerrit-Change-Number: 29386 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 12:55:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by fixeria

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File debian/not-installed: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/a08e7c1e_6523639b PS1, Line 2: osmo-hlr-dgsm.cfg > Installed into /usr/share/doc/osmo-hlr/examples/ Sorry for not stating this explicitly, but I believe this should have been done in a separate change. This commit says "bump compatibility level", so it should do so. Installing missing config file is definitely another thing. File debian/osmo-hlr.install: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/e3960b0d_1eb17db6 PS3, Line 9: usr/share/doc/osmo-hlr/examples/osmo-hlr-dgsm.cfg usr/share/doc/osmo-hlr/examples For consistency with the other entries, please: * remove the destination path, it's installed there anyway (I guess); * move this line above closer to '.../examples/osmo-hlr.cfg'; * start the path with '/'. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 12:48:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump copyright year to match current

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29380 ) Change subject: Debian: bump copyright year to match current ...................................................................... Debian: bump copyright year to match current Related: OS#4107 Change-Id: I581e62b5410a9dddc6b5fd974081d633cc20416d --- M debian/copyright 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/debian/copyright b/debian/copyright index c0e2b45..374c9a2 100644 --- a/debian/copyright +++ b/debian/copyright @@ -3,7 +3,7 @@ Source: http://cgit.osmocom.org/osmo-hlr/ Files: * -Copyright: 2016-2017 Sysmocom s. f. m. c. GmbH <info(a)sysmocom.de> +Copyright: 2016-2022 Sysmocom s. f. m. c. GmbH <info(a)sysmocom.de> License: AGPL-3+ License: AGPL-3+ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I581e62b5410a9dddc6b5fd974081d633cc20416d Gerrit-Change-Number: 29380 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: reformat package description

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29382 ) Change subject: Debian: reformat package description ...................................................................... Debian: reformat package description Shorten the lines of package description to comply with Debian Policy Manual section 3.4.1 Related: OS#4107 Change-Id: Id6bbfc0b013f0e8da80af76206d3ac7fd6b6b0d4 --- M debian/control 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/debian/control b/debian/control index bda8282..0ed4883 100644 --- a/debian/control +++ b/debian/control @@ -22,8 +22,9 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Description: Osmocom Home Location Register - OsmoHLR is a Osmocom implementation of HLR (Home Location Registrar) which works over GSUP - protocol. The subscribers are store in sqlite DB. It supports both 2G and 3G authentication. + OsmoHLR is a Osmocom implementation of HLR (Home Location Registrar) which + works over GSUP protocol. The subscribers are store in sqlite DB. + It supports both 2G and 3G authentication. Package: osmo-hlr-dbg Architecture: any 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id6bbfc0b013f0e8da80af76206d3ac7fd6b6b0d4 Gerrit-Change-Number: 29382 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by msuraev

Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Patch Set 3: (1 comment) File debian/not-installed: https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/7424bd41_4c100aaf PS1, Line 2: osmo-hlr-dgsm.cfg > Like we always Do in projects with multiple configuration samples,check bsc Installed into /usr/share/doc/osmo-hlr/examples/ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 12:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hlr[master]: Debian: bump compatibility level

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 ) Change subject: Debian: bump compatibility level ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867 Gerrit-Change-Number: 29381 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 18 Sep 2022 12:32:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022