Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29384 )
Change subject: vty doc: indicate default nft table name
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-upf/upf_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/29384/comment/fb6b1108_ea4eeb24
PS2, Line 239: "Set the nft inet table name to create and place GTP tunnel forwarding chains in"
IMO, the interactive VTY help is not the right place for such a verbose explanation. Ideally this should go to the documentation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29384
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I79b4d287cae47c37b45a35904f298e57120a65f0
Gerrit-Change-Number: 29384
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Sep 2022 06:29:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29381 )
Change subject: Debian: bump compatibility level
......................................................................
Patch Set 1:
(1 comment)
File debian/not-installed:
https://gerrit.osmocom.org/c/osmo-hlr/+/29381/comment/b75c54d0_a4dd8a3e
PS1, Line 2: osmo-hlr-dgsm.cfg
> As part of osmo-hlr or some other package?
Like we always Do in projects with multiple configuration samples,check bsc
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29381
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Id1557cd07b5d28dbb6018cbf972ce41008b65867
Gerrit-Change-Number: 29381
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Sep 2022 05:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29380 )
Change subject: Debian: bump copyright year to match current
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29380
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I581e62b5410a9dddc6b5fd974081d633cc20416d
Gerrit-Change-Number: 29380
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Sep 2022 05:42:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment