Attention is currently required from: osmith.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 )
Change subject: add ttcn3-hnbgw-test variant with-pfcp
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe
Gerrit-Change-Number: 29339
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Sep 2022 16:29:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 )
Change subject: vty: Allow using hex and octal representations in cmd numeric ranges
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I still need to add tests for this, but sharing now in case someone wants to provide early feedback.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4
Gerrit-Change-Number: 19422
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 )
Change subject: vty: Allow using hex and octal representations in cmd numeric ranges
......................................................................
Patch Set 3:
(1 comment)
File src/vty/command.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmocore-lint-503):
https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/fce93f98_f3db605a
PS3, Line 1566: val = strtoul(str, &endptr,val_base);
space required after that ',' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4
Gerrit-Change-Number: 19422
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:57:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/19422
to look at the new patch set (#3).
Change subject: vty: Allow using hex and octal representations in cmd numeric ranges
......................................................................
vty: Allow using hex and octal representations in cmd numeric ranges
Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4
---
M src/vty/command.c
1 file changed, 53 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/19422/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4
Gerrit-Change-Number: 19422
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 )
Change subject: osmo-hnbgw-master: build with --enable-pfcp
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I would really enable pfcp by default at some point near in time.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7
Gerrit-Change-Number: 29355
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 )
Change subject: add ttcn3-hnbgw-test-pfcp
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
ok but it would be nice to see all the results in a single jenkins job result
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe
Gerrit-Change-Number: 29339
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 )
Change subject: add ttcn3-hnbgw-test-pfcp
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Why not having everything under ttcn2-hnbgw-test and same jenkins.sh, etc.? […]
it was too easy to just copy it, and too intricate to mess with the jenkins.sh
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe
Gerrit-Change-Number: 29339
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Sep 2022 15:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment