September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs: add ttcn3-hnbgw-test-pfcp

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29356 ) Change subject: jobs: add ttcn3-hnbgw-test-pfcp ...................................................................... jobs: add ttcn3-hnbgw-test-pfcp Change-Id: I56fdbd2e52bba2eca6c209a2ca89dc7e1a8f1f84 --- M jobs/ttcn3-testsuites.yml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index e8420ec..9eef9f8 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -150,6 +150,9 @@ - ttcn3-hnbgw-test: blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * + - ttcn3-hnbgw-test-pfcp: + blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" + timer: 40 15 * * * - ttcn3-fr-test: blocking: "^(ttcn3|TTCN3-.*)-fr-test.*" timer: 40 10 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I56fdbd2e52bba2eca6c209a2ca89dc7e1a8f1f84 Gerrit-Change-Number: 29356 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs: add ttcn3-hnbgw-test-pfcp

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29356 ) Change subject: jobs: add ttcn3-hnbgw-test-pfcp ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial, already running on jenkins -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I56fdbd2e52bba2eca6c209a2ca89dc7e1a8f1f84 Gerrit-Change-Number: 29356 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:28:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs: add ttcn3-hnbgw-test-pfcp

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29356 ) Change subject: jobs: add ttcn3-hnbgw-test-pfcp ...................................................................... jobs: add ttcn3-hnbgw-test-pfcp Change-Id: I56fdbd2e52bba2eca6c209a2ca89dc7e1a8f1f84 --- M jobs/ttcn3-testsuites.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/56/29356/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index e8420ec..9eef9f8 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -150,6 +150,9 @@ - ttcn3-hnbgw-test: blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * + - ttcn3-hnbgw-test-pfcp: + blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" + timer: 40 15 * * * - ttcn3-fr-test: blocking: "^(ttcn3|TTCN3-.*)-fr-test.*" timer: 40 10 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I56fdbd2e52bba2eca6c209a2ca89dc7e1a8f1f84 Gerrit-Change-Number: 29356 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: do not depend on libosmo-gtlv

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 ) Change subject: do not depend on libosmo-gtlv ...................................................................... do not depend on libosmo-gtlv Depending on libosmo-pfcp implies libosmo-gtlv, no need to explicitly add this dependency. Change-Id: I39eb59520231bcfed724060d3fda4ba919f2199d --- M configure.ac 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 1a73496..290a939 100644 --- a/configure.ac +++ b/configure.ac @@ -64,7 +64,6 @@ AC_ARG_ENABLE([pfcp], [AS_HELP_STRING([--enable-pfcp], [Build with PFCP support, for GTP tunnel mapping via UPF])], [osmo_ac_pfcp="$enableval"],[osmo_ac_pfcp="no"]) if test "x$osmo_ac_pfcp" = "xyes" ; then - PKG_CHECK_MODULES(LIBOSMOGTLV, libosmo-gtlv >= 0.1.0) PKG_CHECK_MODULES(LIBOSMOPFCP, libosmo-pfcp >= 0.1.0) AC_DEFINE(ENABLE_PFCP, 1, [Define to build with PFCP support]) fi -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39eb59520231bcfed724060d3fda4ba919f2199d Gerrit-Change-Number: 29352 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: do not depend on libosmo-gtlv

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 ) Change subject: do not depend on libosmo-gtlv ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > That's because osmo-hnbgw doesn't really use any libosmo-gtlv stuff directly, correct? that's right, only the libosmo-pfcp api. i wasn't thinking clearly when i added the deps originally... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39eb59520231bcfed724060d3fda4ba919f2199d Gerrit-Change-Number: 29352 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:24:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... osmo-hnbgw-master: build with --enable-pfcp Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 --- M osmo-hnbgw-master/Dockerfile 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/55/29355/1 diff --git a/osmo-hnbgw-master/Dockerfile b/osmo-hnbgw-master/Dockerfile index 4f7fbb5..d842fb3 100644 --- a/osmo-hnbgw-master/Dockerfile +++ b/osmo-hnbgw-master/Dockerfile @@ -14,7 +14,9 @@ libosmo-ranap-dev \ libosmo-rua-dev \ libosmo-hnbap-dev \ - libasn1c-dev && \ + libasn1c-dev \ + libosmo-pfcp-dev \ + && \ apt-get clean WORKDIR /tmp @@ -29,7 +31,7 @@ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_HNBGW_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ - ./configure && \ + ./configure --enable-pfcp && \ make "-j$(nproc)" install && \ ldconfig -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-hnbgw-test-pfcp

by neels

Attention is currently required from: neels. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/29339 to look at the new patch set (#2). Change subject: add ttcn3-hnbgw-test-pfcp ...................................................................... add ttcn3-hnbgw-test-pfcp Add a new test suite, running osmo-hnbgw with PFCP enabled. Just run all the same tests again, no matter if they are related to PS RAB Assignment or not, to also ensure no ill side effects from PFCP configuration. Related: SYS#5895 Depends: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 (osmo-ttcn3-hacks) Change-Id: I02b60941343000a4618e95f56326bec170c32bfe --- A ttcn3-hnbgw-test-pfcp/Dockerfile A ttcn3-hnbgw-test-pfcp/HNBGW_Tests.cfg A ttcn3-hnbgw-test-pfcp/Makefile A ttcn3-hnbgw-test-pfcp/jenkins.sh A ttcn3-hnbgw-test-pfcp/osmo-hnbgw.cfg A ttcn3-hnbgw-test-pfcp/osmo-stp.cfg 6 files changed, 232 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/29339/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: Make osmo_mgcpc_ep_fsm_pre_term() static

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29320 ) Change subject: Make osmo_mgcpc_ep_fsm_pre_term() static ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaa44906baa201571f6bc3192bd3caacb272fec0b Gerrit-Change-Number: 29320 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:04:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: do not depend on libosmo-gtlv

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 ) Change subject: do not depend on libosmo-gtlv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29352 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39eb59520231bcfed724060d3fda4ba919f2199d Gerrit-Change-Number: 29352 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 15:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix AMR tests matching RSL MultiRate configuration IE

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29350 ) Change subject: BSC_Tests: fix AMR tests matching RSL MultiRate configuration IE ...................................................................... BSC_Tests: fix AMR tests matching RSL MultiRate configuration IE The RSL_IE_MultirateCfg was implemented and added to union RSL_IE_Body in [1]. Before this change, this IE was decoded as RSL_LV (basically an octetstring). Now this IE is decoded as RSL_IE_MultirateCfg, while some AMR tests still expect RSL_LV. Let them use RSL_IE_MultirateCfg. Change-Id: I40dab41d5dc5d14e358ba5a070ce174e7d8d4a4b Fixes: [1] I0a5ddce570c0fd70f096d897b0b609d20b552ff7 --- M bsc/BSC_Tests.ttcn 1 file changed, 60 insertions(+), 33 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 4d7717e..6d4bd82 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -4632,21 +4632,14 @@ f_shutdown_helper(); } -function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring s8_s0, bitstring exp_s8_s0, - charstring start_mode := "1") +function f_TC_assignment_codec_amr(boolean fr, RSL_IE_MultirateCfg mr_cfg, + bitstring s8_s0, bitstring exp_s8_s0, + charstring start_mode := "1") runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); var MSC_ConnHdlr vc_conn; - /* See note above */ - var RSL_IE_Body mr_conf := { - other := { - len := lengthof(mrconf), - payload := mrconf - } - }; - if (fr) { pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecAMR_F})); } else { @@ -4654,7 +4647,7 @@ } pars.ass_codec_list.codecElements[0].s0_7 := s8_s0; pars.ass_codec_list.codecElements[0].s8_15 := '00000111'B; - pars.expect_mr_conf_ie := mr_conf; + pars.expect_mr_conf_ie := { multirate_cfg := mr_cfg }; pars.expect_mr_s0_s7 := exp_s8_s0; f_init(1, true); @@ -4693,71 +4686,90 @@ f_vty_amr_start_mode_restore(fr); } - /* Set S1, we expect an AMR multirate configuration IE with all four rates * set. */ testcase TC_assignment_codec_amr_f_S1() runs on test_CT { - f_TC_assignment_codec_amr(true, '289520882208'O, '00000010'B, '00000010'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '00000011'B, '00000010'B); f_shutdown_helper(); } /* Set S1, we expect an AMR multirate configuration IE with the lower three * rates set. */ testcase TC_assignment_codec_amr_h_S1() runs on test_CT { - f_TC_assignment_codec_amr(false, '2815208820'O, '00000010'B, '00000010'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '00000010'B, '00000010'B); f_shutdown_helper(); } /* Set S1 and two other rates, we expect an AMR MULTIRATE CONFIGURATION IE with * all four rates (and only S1 set in the ASSIGNMENT COMPLETE) */ testcase TC_assignment_codec_amr_f_S124() runs on test_CT { - f_TC_assignment_codec_amr(true, '289520882208'O, '00010110'B, '00000010'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '00010110'B, '00000010'B); f_shutdown_helper(); } /* Set S1 and two other rates, we expect an AMR MULTIRATE CONFIGURATION IE with * all four rates (and only S1 set in the ASSIGNMENT COMPLETE) */ testcase TC_assignment_codec_amr_h_S124() runs on test_CT { - f_TC_assignment_codec_amr(false, '2815208820'O, '00010110'B, '00000010'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '00010110'B, '00000010'B); f_shutdown_helper(); } /* The following block of tests selects more and more rates until all four * possible rates are in the active set (full rate) */ testcase TC_assignment_codec_amr_f_S0() runs on test_CT { - f_TC_assignment_codec_amr(true, '2801'O, '00000001'B, '00000001'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00000001'B)); + f_TC_assignment_codec_amr(true, mr_cfg, '00000001'B, '00000001'B); f_shutdown_helper(); } testcase TC_assignment_codec_amr_f_S02() runs on test_CT { - f_TC_assignment_codec_amr(true, '28052080'O, '00000101'B, '00000101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00000101'B, + params := '2080'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '00000101'B, '00000101'B); f_shutdown_helper(); } testcase TC_assignment_codec_amr_f_S024() runs on test_CT { - f_TC_assignment_codec_amr(true, '2815208820'O, '00010101'B, '00010101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '00010101'B, '00010101'B); f_shutdown_helper(); } testcase TC_assignment_codec_amr_f_S0247() runs on test_CT { - f_TC_assignment_codec_amr(true, '289520882208'O, '10010101'B, '10010101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '10010101'B, '10010101'B); f_shutdown_helper(); } /* The following block of tests selects more and more rates until all three * possible rates are in the active set (half rate) */ testcase TC_assignment_codec_amr_h_S0() runs on test_CT { - f_TC_assignment_codec_amr(false, '2801'O, '00000001'B, '00000001'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00000001'B)); + f_TC_assignment_codec_amr(false, mr_cfg, '00000001'B, '00000001'B); f_shutdown_helper(); } testcase TC_assignment_codec_amr_h_S02() runs on test_CT { - f_TC_assignment_codec_amr(false, '28052080'O, '00000101'B, '00000101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00000101'B, + params := '2080'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '00000101'B, '00000101'B); f_shutdown_helper(); } testcase TC_assignment_codec_amr_h_S024() runs on test_CT { - f_TC_assignment_codec_amr(false, '2815208820'O, '00010101'B, '00010101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '00010101'B, '00010101'B); f_shutdown_helper(); } @@ -4770,7 +4782,9 @@ testcase TC_assignment_codec_amr_h_S0247() runs on test_CT { /* Try to include 12,2k in into the active set even though the channel * is half rate only. The BSC is expected to remove the 12,0k */ - f_TC_assignment_codec_amr(false, '2815208820'O, '10010101'B, '00010101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '10010101'B, '00010101'B); f_shutdown_helper(); } @@ -4778,7 +4792,9 @@ /* See what happens when all rates are selected at once. Since then * Also S1 is selected, this setting will be prefered and we should * get 12.2k, 7,40k, 5,90k, and 4,75k in the active set. */ - f_TC_assignment_codec_amr(true, '289520882208'O, '11111111'B, '00000010'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '11111111'B, '00000010'B); f_shutdown_helper(); } @@ -4786,7 +4802,9 @@ /* Same as above, but with S1 missing, the MSC is then expected to * select the currently supported rates, which are also 12.2k, 7,40k, * 5,90k, and 4,75k, into the active set. */ - f_TC_assignment_codec_amr(true, '289520882208'O, '11111101'B, '10010101'B); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '11111101'B, '10010101'B); f_shutdown_helper(); } @@ -4809,28 +4827,37 @@ } testcase TC_assignment_codec_amr_f_start_mode_auto() runs on test_CT { - f_TC_assignment_codec_amr(true, '209520882208'O, '11111111'B, '00000010'B, - start_mode := "auto"); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(icmi := false, + codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '11111111'B, '00000010'B, start_mode := "auto"); f_shutdown_helper(); } testcase TC_assignment_codec_amr_h_start_mode_auto() runs on test_CT { - f_TC_assignment_codec_amr(false, '2015208820'O, '10010101'B, '00010101'B, + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(icmi := false, + codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '10010101'B, '00010101'B, start_mode := "auto"); f_shutdown_helper(); } testcase TC_assignment_codec_amr_f_start_mode_4() runs on test_CT { /* "amr tch-f modes 0 2 4 7" => total 4 modes and start mode 4 => '11'B on the wire */ - f_TC_assignment_codec_amr(true, '2b9520882208'O, '11111111'B, '00000010'B, - start_mode := "4"); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(start_mode := 3, + codec_modes := '10010101'B, + params := '20882208'O)); + f_TC_assignment_codec_amr(true, mr_cfg, '11111111'B, '00000010'B, start_mode := "4"); f_shutdown_helper(); } testcase TC_assignment_codec_amr_h_start_mode_4() runs on test_CT { /* "amr tch-h modes 0 2 4" => total 3 modes and start mode 4 => '10'B on the wire */ - f_TC_assignment_codec_amr(false, '2a15208820'O, '10010101'B, '00010101'B, - start_mode := "4"); + var RSL_IE_MultirateCfg mr_cfg := valueof(ts_RSL_MultirateCfg(start_mode := 2, + codec_modes := '00010101'B, + params := '208820'O)); + f_TC_assignment_codec_amr(false, mr_cfg, '10010101'B, '00010101'B, start_mode := "4"); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40dab41d5dc5d14e358ba5a070ce174e7d8d4a4b Gerrit-Change-Number: 29350 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022