September 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... osmo-hnbgw-master: build with --enable-pfcp Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 --- M osmo-hnbgw-master/Dockerfile 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/osmo-hnbgw-master/Dockerfile b/osmo-hnbgw-master/Dockerfile index 4f7fbb5..d842fb3 100644 --- a/osmo-hnbgw-master/Dockerfile +++ b/osmo-hnbgw-master/Dockerfile @@ -14,7 +14,9 @@ libosmo-ranap-dev \ libosmo-rua-dev \ libosmo-hnbap-dev \ - libasn1c-dev && \ + libasn1c-dev \ + libosmo-pfcp-dev \ + && \ apt-get clean WORKDIR /tmp @@ -29,7 +31,7 @@ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_HNBGW_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ - ./configure && \ + ./configure --enable-pfcp && \ make "-j$(nproc)" install && \ ldconfig -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would really enable pfcp by default at some point near in time. it was discussed before with a different conclusion -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp

by neels

Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 4: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/030b802e_0ea… PS3, Line 82: echo Starting container with STP > running with gdb in the jenkins.sh? […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:50:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp

by neels

Attention is currently required from: osmith, pespin. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/29339 to look at the new patch set (#4). Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... add ttcn3-hnbgw-test variant with-pfcp Run HNBGW tests a second time with PFCP enabled. Just run all the same tests again, no matter if they are related to PS RAB Assignment or not, to also ensure no ill side effects from PFCP configuration. Related: SYS#5895 Depends: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 (osmo-ttcn3-hacks) Change-Id: I02b60941343000a4618e95f56326bec170c32bfe --- M ttcn3-hnbgw-test/jenkins.sh A ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg A ttcn3-hnbgw-test/with-pfcp/osmo-hnbgw.cfg 3 files changed, 164 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/29339/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: vty: Allow using hex representations in cmd numeric ranges

by fixeria

Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex representations in cmd numeric ranges ...................................................................... Patch Set 6: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/de6283d2_15fb856b PS6, Line 9: in hexadecimal range I would say: "... using hexadecimal notation". Not critical. File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/843f0d85_ed249169 PS6, Line 1487: error s/error/a negative value/ https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/098c9a5c_dec050c3 PS6, Line 1505: if (isdigit(*ptr) || > just use isxdigit()? Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:29:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-hnbgw-test variant with-pfcp

by neels

Attention is currently required from: osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29339 ) Change subject: add ttcn3-hnbgw-test variant with-pfcp ...................................................................... Patch Set 3: (1 comment) File ttcn3-hnbgw-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29339/comment/f5d5a5cb_f63… PS3, Line 82: echo Starting container with STP > If you want to understand what's run here, and how run a subset of the things here: yes it helps a l […] running with gdb in the jenkins.sh? i still disagree that it helps at all nor that it's worth the effort but if it makes your day and if we can stop ping ponging on bikesheds in a jenkins ci shell script that could hardly be more obscure in the first place even without indirection of calling functions with parameters... hrm. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I02b60941343000a4618e95f56326bec170c32bfe Gerrit-Change-Number: 29339 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: vty: Allow using hex representations in cmd numeric ranges

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex representations in cmd numeric ranges ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/19422/comment/1f5b7854_6026b341 PS6, Line 1505: if (isdigit(*ptr) || just use isxdigit()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:15:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: osmo-hnbgw-master: build with --enable-pfcp

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29355 ) Change subject: osmo-hnbgw-master: build with --enable-pfcp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29355 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If84261cba2bf3b75c454fd5d16fd19a88a468eb7 Gerrit-Change-Number: 29355 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:13:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: lint: ignore MACRO_WITH_FLOW_CONTROL

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29359 ) Change subject: lint: ignore MACRO_WITH_FLOW_CONTROL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: i have made one too, OSMO_NAME_C_IMPL(), but still i think it's ok to let the linter complain about it. because in general we should avoid flow control macros, and for the very rare cases where we allow it, it should be good enough to find someone to remove the linter vote before merging -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79da5a426db59031e3b16aecedeaa1498c91e847 Gerrit-Change-Number: 29359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:06:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: Make esme struct shared

by neels

Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 21: (2 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/5e997766_64e5457e PS21, Line 14: esme You marked my comment as resolved without responding. struct naming seems unclear; we now have struct esme and struct smpp_esme, right? api doc explanation of the difference would be good File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/57114f65_ac22c05a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \ > I completely agree - this problems dates back to BSC/MSC split and the shared gsm_network struct whi […] struct gsm_network contains opaque pointers to vlr_instance, that shouldn't pull in libvlr as dependency; is it gsm_network_init()? this is not so important, but seems like an easy way out here -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 21 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Sep 2022 12:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022