August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_om2000: move switch-case to function

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 ) Change subject: abis_om2000: move switch-case to function ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/42ee9eaf_02cb0fbc PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state) > I am not sure about the naming scheme. "abis" is one layer below. […] Why do you say abis is one layer below? AFAIU OM2K is (part of) an implementation of the Abis interface, which deviates from what is specified in TS 12.21. abis_nm_op_sate_from_om2k_op_state() om2k_to_abis_nm_op_state() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 10:45:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo_dia2gsup in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo_dia2gsup failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo_dia2gsup Last lines of build log: [ 199s] ===> App osmo_ss7 is a checkout dependency and cannot be locked. [ 199s] ===> App osmo_gsup is a checkout dependency and cannot be locked. [ 199s] ===> App lager is a checkout dependency and cannot be locked. [ 199s] make[2]: Entering directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 199s] make[2]: '/usr/src/packages/BUILD/_checkouts/epcap/c_src/../priv/epcap' is up to date. [ 199s] make[2]: Leaving directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 199s] ===> Analyzing applications... [ 200s] ===> Compiling pkt [ 200s] ===> Compiling parse_trans [ 200s] ===> Compiling epcap [ 200s] ===> Compiling osmo_ss7 [ 200s] ===> Compiling setup [ 200s] ===> Compiling osmo_gsup [ 200s] ===> Compiling goldrush [ 200s] ===> Compiling lager [ 200s] ===> Getting log of git repo failed in /usr/src/packages/BUILD/_checkouts/parse_trans. Falling back to version 0.0.0 [ 200s] ===> Building escript for setup... [ 200s] ===> Unable to run pre hooks for 'compile', command 'compile' in namespace 'diameter' not found. [ 200s] make[1]: *** [debian/rules:14: override_dh_auto_build] Error 1 [ 200s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 200s] make: *** [debian/rules:8: build] Error 2 [ 200s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 200s] ### VM INTERACTION START ### [ 200s] [ 183.477396] sysrq: SysRq : Power Off [ 200s] [ 183.479165] reboot: Power down [ 200s] ### VM INTERACTION END ### [ 200s] [ 200s] armbuild22 failed "build osmo-diameter2gsup_0.1.1.202208040949.dsc" at Thu Aug 4 10:30:03 UTC 2022. [ 200s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: move switch-case to function

by dexter

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 to look at the new patch set (#2). Change subject: abis_om2000: move switch-case to function ...................................................................... abis_om2000: move switch-case to function The switch-case in update_op_state() and update_mo_state() can be split off into functions. This makes to code better readable. Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Related: OS#5634 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 41 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/28914/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: move switch-case to function

by dexter

Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 ) Change subject: abis_om2000: move switch-case to function ...................................................................... Patch Set 2: (4 comments) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/9d616c3e_a8adb091 PS1, Line 964: oml_avstate_from_om2k_mostate > static? Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/6e594a99_5be912e9 PS1, Line 997: switch (mo->class) { > You can probably move this inside oml_avstate_from_om2k_mostate() too, and pass mo->class there as a […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/4e50cb90_dd571a7b PS1, Line 1016: oml_opstate_from_om2k_opstate > static? Done https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/8d93e84e_3d5f657d PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state) > it's a bit strange that a function starting with "oml_opstate" returns a "abis_nm_op_state" don't yo […] I am not sure about the naming scheme. "abis" is one layer below. As far as I understand om2k is also on top of abis. The real difference is between OM2K and OML. Du you have a suggestion for a better function name? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 10:27:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo_dia2gsup in Debian_10/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo_dia2gsup failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo_dia2gsup Last lines of build log: [ 173s] [0m[0;32m===> App osmo_ss7 is a checkout dependency and cannot be locked. [ 173s] [0m[0;32m===> App osmo_gsup is a checkout dependency and cannot be locked. [ 173s] [0m[0;32m===> App lager is a checkout dependency and cannot be locked. [ 173s] [0mmake[2]: Entering directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 173s] make[2]: '/usr/src/packages/BUILD/_checkouts/epcap/c_src/../priv/epcap' is up to date. [ 173s] make[2]: Leaving directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 173s] [0;32m===> Analyzing applications... [ 173s] [0m[0;32m===> Compiling pkt [ 173s] [0m[0;32m===> Compiling parse_trans [ 173s] [0m[0;32m===> Compiling epcap [ 173s] [0m[0;32m===> Compiling osmo_ss7 [ 173s] [0m[0;32m===> Compiling setup [ 173s] [0m[0;32m===> Compiling osmo_gsup [ 173s] [0m[0;32m===> Compiling goldrush [ 173s] [0m[0;32m===> Compiling lager [ 173s] [0m[0;35m===> Getting log of git repo failed in /usr/src/packages/BUILD/_checkouts/parse_trans. Falling back to version 0.0.0 [ 173s] [0m[0;32m===> Building escript for setup... [ 173s] [0m[0;31m===> [1mUnable to run pre hooks for 'compile', command 'compile' in namespace 'diameter' not found. [ 173s] [0m[0mmake[1]: *** [debian/rules:14: override_dh_auto_build] Error 1 [ 173s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 173s] make: *** [debian/rules:8: build] Error 2 [ 173s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 173s] ### VM INTERACTION START ### [ 174s] [ 158.241606][ T1] sysrq: Power Off [ 174s] [ 158.242986][ T7] reboot: Power down [ 174s] ### VM INTERACTION END ### [ 174s] [ 174s] obs-arm-8 failed "build osmo-diameter2gsup_0.1.1.202208040949.dsc" at Thu Aug 4 09:58:15 UTC 2022. [ 174s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs-mirror.sh: exclude dotfiles

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28927 ) Change subject: obs-mirror.sh: exclude dotfiles ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e Gerrit-Change-Number: 28927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 09:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo_dia2gsup in Debian_10/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo_dia2gsup failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo_dia2gsup Last lines of build log: [ 97s] [0m[0;32m===> App osmo_ss7 is a checkout dependency and cannot be locked. [ 97s] [0m[0;32m===> App osmo_gsup is a checkout dependency and cannot be locked. [ 97s] [0m[0;32m===> App lager is a checkout dependency and cannot be locked. [ 97s] [0mmake[2]: Entering directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 97s] make[2]: '/usr/src/packages/BUILD/_checkouts/epcap/c_src/../priv/epcap' is up to date. [ 97s] make[2]: Leaving directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 97s] [0;32m===> Analyzing applications... [ 97s] [0m[0;32m===> Compiling pkt [ 97s] [0m[0;32m===> Compiling parse_trans [ 97s] [0m[0;32m===> Compiling epcap [ 97s] [0m[0;32m===> Compiling osmo_ss7 [ 97s] [0m[0;32m===> Compiling setup [ 97s] [0m[0;32m===> Compiling osmo_gsup [ 97s] [0m[0;32m===> Compiling goldrush [ 97s] [0m[0;32m===> Compiling lager [ 97s] [0m[0;35m===> Getting log of git repo failed in /usr/src/packages/BUILD/_checkouts/parse_trans. Falling back to version 0.0.0 [ 97s] [0m[0;32m===> Building escript for setup... [ 97s] [0m[0;31m===> [1mUnable to run pre hooks for 'compile', command 'compile' in namespace 'diameter' not found. [ 97s] [0m[0mmake[1]: *** [debian/rules:14: override_dh_auto_build] Error 1 [ 97s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 97s] make: *** [debian/rules:8: build] Error 2 [ 97s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 97s] ### VM INTERACTION START ### [ 97s] [ 88.031930][ T1] sysrq: Power Off [ 97s] [ 88.034745][ T7] reboot: Power down [ 98s] ### VM INTERACTION END ### [ 98s] [ 98s] sheep86 failed "build osmo-diameter2gsup_0.1.1.202208040949.dsc" at Thu Aug 4 09:55:44 UTC 2022. [ 98s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo_dia2gsup in xUbuntu_20.04/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo_dia2gsup failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo_dia2gsup Last lines of build log: [ 185s] [0m[0;32m===> App osmo_gsup is a checkout dependency and cannot be locked. [ 185s] [0m[0;32m===> App lager is a checkout dependency and cannot be locked. [ 186s] [0mmake[2]: Entering directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 186s] make[2]: '/usr/src/packages/BUILD/_checkouts/epcap/c_src/../priv/epcap' is up to date. [ 186s] make[2]: Leaving directory '/usr/src/packages/BUILD/_checkouts/epcap/c_src' [ 186s] [0;32m===> Analyzing applications... [ 186s] [0m[0;32m===> Compiling pkt [ 186s] [0m[0;32m===> Compiling parse_trans [ 186s] [0m[0;32m===> Compiling epcap [ 186s] [0m[0;32m===> Compiling osmo_ss7 [ 186s] [0m[0;32m===> Compiling setup [ 186s] [0m[0;32m===> Compiling osmo_gsup [ 186s] [0m[0;32m===> Compiling goldrush [ 186s] [0m[0;32m===> Compiling lager [ 186s] [0m[0;35m===> Getting log of git repo failed in /usr/src/packages/BUILD/_checkouts/parse_trans. Falling back to version 0.0.0 [ 186s] [0m[0;32m===> Building escript for setup... [ 186s] [0m[0;31m===> [1mUnable to run pre hooks for 'compile', command 'compile' in namespace 'diameter' not found. [ 186s] [0m[0mmake[1]: *** [debian/rules:14: override_dh_auto_build] Error 1 [ 186s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 186s] make: *** [debian/rules:8: build] Error 2 [ 186s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 186s] ### VM INTERACTION START ### [ 186s] Failed to write utmp record: Read-only file system [ 186s] Powering off. [ 186s] [ 164.212759][ T9014] reboot: Power down [ 186s] ### VM INTERACTION END ### [ 186s] [ 186s] lamb25 failed "build osmo-diameter2gsup_0.1.1.202208040949.dsc" at Thu Aug 4 09:55:38 UTC 2022. [ 186s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28897 ) Change subject: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req ...................................................................... sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req 3GPP TS 23.041 9.3.32 states that the IE is always present for non-ETWS messages and never present in ETWS messages. Related: OS#4945 Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef --- M src/sbcap_msg.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/sbcap_msg.c b/src/sbcap_msg.c index 1c0e768..f9fa70a 100644 --- a/src/sbcap_msg.c +++ b/src/sbcap_msg.c @@ -223,6 +223,14 @@ ptr++; } ASN_SEQUENCE_ADD(as_pdu, ie); + + /* Concurrent Warning Message Indicator + * 3GPP TS 36.413 8.12.1.2 and 9.2.1.72, 3GPP TS 23.041 9.3.32 + * static const long asn_VAL_13_SBcAP_id_Concurrent_Warning_Message_Indicator = 20; */ + ie = sbcap_alloc_Write_Replace_Warning_Request_IE(20, SBcAP_Criticality_reject, + SBcAP_Write_Replace_Warning_Request_IEs__value_PR_Concurrent_Warning_Message_Indicator); + ie->value.choice.Concurrent_Warning_Message_Indicator = SBcAP_Concurrent_Warning_Message_Indicator_true; + ASN_SEQUENCE_ADD(as_pdu, ie); } /* Send Write-Replace-Warning-Indication -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef Gerrit-Change-Number: 28897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28897 ) Change subject: sbcap: Add Concurrent-Warning-Message-Indicator IE to Write-Replace-Req ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4a5ac56b7e6eeb85aee07ae2ddf10fa2afbbf4ef Gerrit-Change-Number: 28897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Aug 2022 09:55:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022