August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: sbcap: Fix spec references in comments

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28930 ) Change subject: sbcap: Fix spec references in comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89bc9d15548e6c709f0e1b614f00bc98ec41d441 Gerrit-Change-Number: 28930 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:33:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over SBc-AP

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28929 ) Change subject: cbc: Test ETWS msg over SBc-AP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I506322fc8a664716db8cd79217c2091b0b926836 Gerrit-Change-Number: 28929 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:33:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: (2 comments) File cbc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/4c012693_93bf… PS3, Line 101: var template (omit) uint8_t channel_ind := omit; AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. Could you explain why are you adding a separate template variable? What's wrong with passing msg.channel_ind directly? File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/47e68c4d_87a6… PS3, Line 353: g_pars.exp_cbs_msg.channel_ind Here I guess you're doing ispresent() because g_pars.exp_cbs_msg may be omitted? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: cbsp: Log storing of CellId info received from peers

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28932 ) Change subject: cbsp: Log storing of CellId info received from peers ...................................................................... cbsp: Log storing of CellId info received from peers This is already done similarly in Sbc-AP. Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692 --- M src/cbsp_smscb_peer_fsm.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/32/28932/1 diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c index 8a435f9..f5e3d95 100644 --- a/src/cbsp_smscb_peer_fsm.c +++ b/src/cbsp_smscb_peer_fsm.c @@ -171,6 +171,8 @@ cci_from_cbsp(cci, id_discr, &ce->cell_id); cci->num_compl.num_compl += ce->num_compl; cci->num_compl.num_bcast_info += ce->num_bcast_info; + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s to Broadcast Completed list\n", + cbc_cell_id2str(cci)); } static void msg_peer_append_cbsp_compl(struct cbc_message_peer *mp, struct osmo_cbsp_num_compl_list *nclist) @@ -195,6 +197,8 @@ llist_add_tail(&cci->list, &mp->cell_list); } cci_from_cbsp(cci, id_discr, &ce->cell_id); + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s to Cell list\n", + cbc_cell_id2str(cci)); } static void msg_peer_append_cbsp_cell(struct cbc_message_peer *mp, struct osmo_cbsp_cell_list *clist) @@ -219,6 +223,8 @@ } cci->id_discr = cci_discr_from_cell_id(fe->id_discr); cci->fail.cause = fe->cause; + LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s (cause: %u) to Failed list\n", + cbc_cell_id2str(cci), cci->fail.cause); } static void msg_peer_append_cbsp_fail(struct cbc_message_peer *mp, struct llist_head *flist) { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692 Gerrit-Change-Number: 28932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: cbsp: Store content of received Cell Id from Failed List

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28933 ) Change subject: cbsp: Store content of received Cell Id from Failed List ...................................................................... cbsp: Store content of received Cell Id from Failed List Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0 --- M src/cbsp_smscb_peer_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/33/28933/1 diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c index f5e3d95..001b822 100644 --- a/src/cbsp_smscb_peer_fsm.c +++ b/src/cbsp_smscb_peer_fsm.c @@ -221,7 +221,7 @@ return; llist_add_tail(&cci->list, &mp->fail_list); } - cci->id_discr = cci_discr_from_cell_id(fe->id_discr); + cci_from_cbsp(cci, fe->id_discr, &fe->cell_id); cci->fail.cause = fe->cause; LOGPFSML(mp->fi, LOGL_DEBUG, "Appending CellId %s (cause: %u) to Failed list\n", cbc_cell_id2str(cci), cci->fail.cause); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0 Gerrit-Change-Number: 28933 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add osmo-bsc-nat, osmo-fl2k

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28931 ) Change subject: obs: add osmo-bsc-nat, osmo-fl2k ...................................................................... obs: add osmo-bsc-nat, osmo-fl2k Looks like I copied the list of packages from the old latest script, so these two that were only in nightly are missing. Once added, they will be built for nightly again and not for latest as there's no tag matching the patterin in the git repositories. Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 --- M scripts/obs/lib/config.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/31/28931/1 diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 22c9c05..a4a10c5 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -49,9 +49,11 @@ "libsmpp34", "libusrp", "osmo-bsc", + "osmo-bsc-nat", "osmo-bts", "osmo-cbc", "osmo-e1d", + "osmo-fl2k", "osmo-gbproxy", "osmo-ggsn", "osmo-gsm-manuals", @@ -86,6 +88,7 @@ "limesuite": "https://github.com/myriadrf/LimeSuite", "neocon": "https://github.com/laf0rge/neocon", "open5gs": "https://github.com/open5gs/open5gs", + "osmo-fl2k": "https://gitea.osmocom.org/sdr/osmo-fl2k", "rtl-sdr": "https://gitea.osmocom.org/sdr/rtl-sdr", } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 Gerrit-Change-Number: 28931 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: (1 comment) File library/CBSP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/17f7f09c_f5d3… PS2, Line 424: > 6.5.0 > As stated I'm simply keeping the original message here, notreally related to this patch. […] The comment is correct. git blame gives us the explanation: commit e53a23db707e04e9283d89284c49862b005bbac7 Author: Harald Welte <laforge(a)osmocom.org> Date: Mon Apr 20 18:01:00 2020 +0200 HACK: avoid compilation error with TITAN > 6.5.0 it seems TITAN no longer supports 'ifpresent' in certain situations, see https://www.eclipse.org/forums/index.php/m/1826175/#msg_1826175 Let's make the tests fail if we actually run in those cases, but at least compile fine and be able to execute all the other tests. Change-Id: Ia401c2d696979c0062872bca8da62c2ea153427b -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:17:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 ) Change subject: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e0ecbcced9f94d2b44d981db353007cad3ae959 Gerrit-Change-Number: 28920 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 ) Change subject: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest ...................................................................... Patch Set 1: (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920/comment/1d02963c_7a94… PS1, Line 5806: kC128, codecList := ?); > why not setting codecList := ? as default if it should always be present? And changing the type to t […] Because this assumption is only valid for AoIP. I decided to make no assumptions in tr_BSSMAP_HandoverRequest which transport is used. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e0ecbcced9f94d2b44d981db353007cad3ae959 Gerrit-Change-Number: 28920 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 12:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 11:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022