Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28933 )
Change subject: cbsp: Store content of received Cell Id from Failed List
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I10d2627cb5ef327fd57c22480a4e7d9a464930f0
Gerrit-Change-Number: 28933
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 12:58:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28932 )
Change subject: cbsp: Log storing of CellId info received from peers
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I81ad8d40c5e2b9fbc011db795993fb7f00e99692
Gerrit-Change-Number: 28932
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 12:57:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28903 )
Change subject: fix_perms: use debian:bullseye
......................................................................
fix_perms: use debian:bullseye
Use debian:bullseye instead of debian-bullseye-build. Building the
latter requires a lot of time, it's definitively not needed for just
running chmod. Use debian:bullseye, since we use it as base for most
images and it's therefore very likely that it's already downloaded
(and if not, it would get downloaded here).
Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd
---
M jenkins-common.sh
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/jenkins-common.sh b/jenkins-common.sh
index b393b05..33b1a67 100644
--- a/jenkins-common.sh
+++ b/jenkins-common.sh
@@ -238,16 +238,12 @@
}
fix_perms() {
- if ! docker_image_exists "debian-bullseye-build"; then
- docker_images_require "debian-bullseye-build"
- fi
-
echo Fixing permissions
docker run --rm \
-v $VOL_BASE_DIR:/data \
-v $CACHE_DIR:/cache \
--name ${BUILD_TAG}-cleaner \
- $REPO_USER/debian-bullseye-build \
+ debian:bullseye \
chmod -R a+rX /data/ /cache/
}
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd
Gerrit-Change-Number: 28903
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/28903
to look at the new patch set (#2).
Change subject: fix_perms: use debian:bullseye
......................................................................
fix_perms: use debian:bullseye
Use debian:bullseye instead of debian-bullseye-build. Building the
latter requires a lot of time, it's definitively not needed for just
running chmod. Use debian:bullseye, since we use it as base for most
images and it's therefore very likely that it's already downloaded
(and if not, it would get downloaded here).
Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd
---
M jenkins-common.sh
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/03/28903/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28903
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I88f513a0a8ee04628842a7aa1b663c390d2032cd
Gerrit-Change-Number: 28903
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28908 )
Change subject: Cosmetic: jobs/ttcn3: debian-stretch -> debian
......................................................................
Cosmetic: jobs/ttcn3: debian-stretch -> debian
Remove reference to stretch (debian 9), as the jobs run on a newer
debian version now. Remove the reference altogether so we don't need to
update it here. The current version can be looked up in
docker-playground.git.
Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de
---
M jobs/ttcn3-testsuites.yml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index 131ffac..2016dd2 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -20,7 +20,7 @@
- "{job-name}"
# Folders from docker-playground.git
job-name:
- # debian-stretch nightly - order by time
+ # debian nightly - order by time
- nplab-m3ua-test:
blocking: "^(nplab|NPLAB-.*)-m3ua-test.*"
timer: 10 03 * * *
@@ -160,7 +160,7 @@
description: |
Test open5gs-smfd + open5gs-upfd PGW main.
- # debian-stretch latest stable
+ # debian latest stable
- nplab-m3ua-test-latest:
blocking: "^(nplab|NPLAB-.*)-m3ua-test.*"
timer: 10 03 * * *
@@ -240,7 +240,7 @@
blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*"
timer: 40 13 * * *
- # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs
+ # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian) jobs
# centos7 nightly
- TTCN3-centos7-pcap-client-test:
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de
Gerrit-Change-Number: 28908
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/28908
to look at the new patch set (#3).
Change subject: Cosmetic: jobs/ttcn3: debian-stretch -> debian
......................................................................
Cosmetic: jobs/ttcn3: debian-stretch -> debian
Remove reference to stretch (debian 9), as the jobs run on a newer
debian version now. Remove the reference altogether so we don't need to
update it here. The current version can be looked up in
docker-playground.git.
Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de
---
M jobs/ttcn3-testsuites.yml
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/08/28908/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I06c74830b0f6fe0baed44c300f9e1023fb0522de
Gerrit-Change-Number: 28908
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28917 )
Change subject: logging: add a new category DLCSN1 for libosmo-csn1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> You could simply set a dynamic value at runtime for it, but ok.
AFAIU, the idea behind these DLFOO categories is to avoid the need to create the same logging category in several projects. The CSN.1 codec is currently used in osmo-pcu.git and going to be used in osmocom-bb.git (several applications: trxcon, mobile) and probably in osmo-bsc.git (for Rest Octets and MS Classmark parsing).
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28917
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95
Gerrit-Change-Number: 28917
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 12:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment