August 2022 - gerrit-log - lists.osmocom.org

Change in gapk[master]: configure: fix warning: AC_OUTPUT should be used without arguments

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/28934 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/28934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 Gerrit-Change-Number: 28934 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 14:53:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Test ETWS msg over CBSP

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 ) Change subject: cbc: Test ETWS msg over CBSP ...................................................................... Patch Set 3: (2 comments) File cbc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/39211574_5fec… PS3, Line 101: var template (omit) uint8_t channel_ind := omit; > AFAIU, if msg.channel_ind is omitted, then channel_ind would also be equal to omit. […] I think I got problems there about the field being uninitialized, because as part of a record it's not a template, but an optional field, which is not exactly the same I think. For instance, I think one should use "ispresent()" there, not istemplatekind(). File cbc/CBC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/8b75260a_2bf2… PS3, Line 353: g_pars.exp_cbs_msg.channel_ind > Here I guess you're doing ispresent() because g_pars. […] no, because msg.channel_ind field is optional, since ETWS messages don't contain a channel_ind. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22a00120218a205db11a5622274dcc67435f5de Gerrit-Change-Number: 28912 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 14:52:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add osmo-bsc-nat, osmo-fl2k

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28931 ) Change subject: obs: add osmo-bsc-nat, osmo-fl2k ...................................................................... obs: add osmo-bsc-nat, osmo-fl2k Looks like I copied the list of packages from the old latest script, so these two that were only in nightly are missing. Once added, they will be built for nightly again and not for latest as there's no tag matching the patterin in the git repositories. Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 --- M scripts/obs/lib/config.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 22c9c05..a4a10c5 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -49,9 +49,11 @@ "libsmpp34", "libusrp", "osmo-bsc", + "osmo-bsc-nat", "osmo-bts", "osmo-cbc", "osmo-e1d", + "osmo-fl2k", "osmo-gbproxy", "osmo-ggsn", "osmo-gsm-manuals", @@ -86,6 +88,7 @@ "limesuite": "https://github.com/myriadrf/LimeSuite", "neocon": "https://github.com/laf0rge/neocon", "open5gs": "https://github.com/open5gs/open5gs", + "osmo-fl2k": "https://gitea.osmocom.org/sdr/osmo-fl2k", "rtl-sdr": "https://gitea.osmocom.org/sdr/rtl-sdr", } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 Gerrit-Change-Number: 28931 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs: add osmo-bsc-nat, osmo-fl2k

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28931 ) Change subject: obs: add osmo-bsc-nat, osmo-fl2k ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial patch, and having this is important so repo-install-test doesn't break. merging with one +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4b96f15e95c70f1dca12a292964e6f12b04e4a04 Gerrit-Change-Number: 28931 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 14:17:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs-mirror.sh: exclude dotfiles

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28927 ) Change subject: obs-mirror.sh: exclude dotfiles ...................................................................... obs-mirror.sh: exclude dotfiles There's a .~tmp~ file on the remote that currently causes the rsync command to fail. Ignore all files starting with a dot. Fix for: rsync: [sender] opendir "/opensuse/repositories/network:/osmocom:/nightly/Raspbian_11/.~tmp~" (in opensuse-full-really-everything-including-repositories) failed: Permission denied (13) It's time to update the script to sync the obs.osmocom.org packages instead of the ones from build.opensuse.org, I'll do that in the next patch. Nevertheless, I think it makes sense to add this exclude argument in case OBS (our instance) also creates temporary files like this. Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e --- M contrib/obs-mirror/obs-mirror.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 895afac..e970cab 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -25,7 +25,7 @@ cd "$BASE_DIR" RSYNC_ARGS="-av --delete" -RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" +RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive --exclude='.*'" DIR="$BASE_DIR/$DATE" TEMP_DIR="$BASE_DIR/.temp" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e Gerrit-Change-Number: 28927 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs-mirror.sh: exclude dotfiles

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28927 ) Change subject: obs-mirror.sh: exclude dotfiles ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iacee2ea4acada60d8de960592fb828911a55781e Gerrit-Change-Number: 28927 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in docker-playground[master]: debian-bullseye-obs-asan: new container

by osmith

Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28902 ) Change subject: debian-bullseye-obs-asan: new container ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). […] pespin wrote: > I'd probably change the osmo-*-master Dockerfiles to build all dependency libs from master with --enable-asan enabled, I have been doing that for ages in my local copy of docker-playground.git > This has the benefit that during development one can for instance, easily set LIBOSMO_NETIF_BRANCH=myownbranch when testing ie. osmo-stp-master. IMHO this is not a good reason to build everything from source in the docker containers. This approach is suboptimal for getting a short test cycle, one still has to push the changes to osmocom git servers, then have docker fetch them again and build the program completely from scratch instead of preserving objects for c files that were not modified. fixeria wrote: > We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). Currently most of the images in docker-playground are built upon debian-bullseye-build. With multi-stage builds we could build sanitized libosmocore in one image, and then simply use the products of `make install` for building other libraries like libosmo-abis, and finally for building sanitized osmo-apps. This approach would eliminate the need for building libosmo-* again and again for each osmo-*-master image. I'm not sure if this would actually make the logic in docker-playground more complicated. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic7d6e7cc401acadbae9156d3e7f3a6230c2fb198 Gerrit-Change-Number: 28902 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in gapk[master]: configure: fix warning: AC_OUTPUT should be used without arguments

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/28934 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... configure: fix warning: AC_OUTPUT should be used without arguments Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 --- M configure.ac 1 file changed, 10 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/34/28934/1 diff --git a/configure.ac b/configure.ac index b16acc8..ad659ca 100644 --- a/configure.ac +++ b/configure.ac @@ -15,16 +15,6 @@ AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_TESTDIR(tests) -AC_CONFIG_FILES([ - Makefile - src/Makefile - libgsmhr/Makefile - include/Makefile - include/gsmhr/Makefile - libosmogapk.pc - tests/atlocal - tests/Makefile -]) # Options AC_ARG_ENABLE(gsmhr, @@ -117,4 +107,13 @@ AC_FUNC_MALLOC AC_CHECK_FUNCS([memset]) -AC_OUTPUT([contrib/gapk.spec]) +AC_CONFIG_FILES([contrib/gapk.spec + Makefile + src/Makefile + libgsmhr/Makefile + include/Makefile + include/gsmhr/Makefile + libosmogapk.pc + tests/atlocal + tests/Makefile]) +AC_OUTPUT -- To view, visit https://gerrit.osmocom.org/c/gapk/+/28934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 Gerrit-Change-Number: 28934 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Added basic AFC as implemented by SQ5BPF into float_to_bits.c

by fixeria

Attention is currently required from: wbokslag, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28894 ) Change subject: Added basic AFC as implemented by SQ5BPF into float_to_bits.c ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 Gerrit-Change-Number: 28894 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:02:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs-mirror: use obs.osmocom.org packages as source

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28928 ) Change subject: obs-mirror: use obs.osmocom.org packages as source ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6be69530a7aa65b0cf3866fc7e65af79c9d9d45 Gerrit-Change-Number: 28928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Aug 2022 13:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022