lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2022

  • 3 participants
  • 2402 discussions
Change in osmo-bsc[master]: abis_om2000: update_op_state() does not send signal
by dexter 05 Aug '22

05 Aug '22
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28915 to look at the new patch set (#2). Change subject: abis_om2000: update_op_state() does not send signal ...................................................................... abis_om2000: update_op_state() does not send signal The function update_op_state() updates the OML MO, but it does not notify the update to other entities using S_NM_STATECHG Change-Id: Id19c6beb2bc79c4db0ec07ef593aacb57fff8b75 Related: OS#5634 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/28915/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id19c6beb2bc79c4db0ec07ef593aacb57fff8b75 Gerrit-Change-Number: 28915 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in osmo-bsc[master]: abis_om2000: move switch-case to function
by dexter 05 Aug '22

05 Aug '22
Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 ) Change subject: abis_om2000: move switch-case to function ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28914/comment/664466c9_adbb4105 PS1, Line 1016: enum abis_nm_op_state oml_opstate_from_om2k_opstate(uint8_t op_state) > Why do you say abis is one layer below? AFAIU OM2K is (part of) an implementation of the Abis interf […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 10:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bsc[master]: abis_om2000: constify mo in mo2obj
by dexter 05 Aug '22

05 Aug '22
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28937 ) Change subject: abis_om2000: constify mo in mo2obj ...................................................................... abis_om2000: constify mo in mo2obj The function mo2obj does only read only access to mo, so mo can be const. Change-Id: Ia09d0c96c8938e287fdbad343b9605cbfd6ff6a1 Related: OS#5101 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/28937/1 diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index a1a6c21..9531611 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -932,7 +932,7 @@ return nm_state; } -static void *mo2obj(struct gsm_bts *bts, struct abis_om2k_mo *mo) +static void *mo2obj(struct gsm_bts *bts, const struct abis_om2k_mo *mo) { struct gsm_bts_trx *trx; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia09d0c96c8938e287fdbad343b9605cbfd6ff6a1 Gerrit-Change-Number: 28937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-bsc[master]: abis_om2000: move switch-case to function
by dexter 05 Aug '22

05 Aug '22
Attention is currently required from: fixeria, dexter. Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 to look at the new patch set (#3). Change subject: abis_om2000: move switch-case to function ...................................................................... abis_om2000: move switch-case to function The switch-case in update_op_state() and update_mo_state() can be split off into functions. This makes to code better readable. Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Related: OS#5634 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 41 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/28914/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset
1 0
0 0
Change in osmo-ci[master]: obs-mirror: use obs.osmocom.org packages as source
by osmith 05 Aug '22

05 Aug '22
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28928 ) Change subject: obs-mirror: use obs.osmocom.org packages as source ...................................................................... obs-mirror: use obs.osmocom.org packages as source Change the rsync command to use the packages from /downloads/home/packages/web-files/osmocom: on the same server as source, which is where obs.osmocom.org is pushing the packages. Remove xUbuntu_19.04 from the directories to sync, as we don't build for it anymore. It's not an LTS release (unlike 18.04, 20.04) and it's EOL. Related: OS#5557 Change-Id: Id6be69530a7aa65b0cf3866fc7e65af79c9d9d45 --- M contrib/obs-mirror/obs-mirror-include.txt M contrib/obs-mirror/obs-mirror.sh 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 6427401..6510e74 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -5,7 +5,6 @@ latest/Raspbian_10 latest/Raspbian_11 latest/xUbuntu_18.04 -latest/xUbuntu_19.04 latest/xUbuntu_20.04 latest/xUbuntu_21.04 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index e970cab..03e307e 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -20,7 +20,7 @@ # base directory on the local side BASE_DIR="/downloads/obs-mirror/" # sync remote where to find the osmocom packages -REMOTE="rsync.opensuse.org::opensuse-full-really-everything-including-repositories/opensuse/repositories/network:/osmocom:" +REMOTE="/downloads/home/packages/web-files/osmocom:" cd "$BASE_DIR" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6be69530a7aa65b0cf3866fc7e65af79c9d9d45 Gerrit-Change-Number: 28928 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ci[master]: obs-mirror: use obs.osmocom.org packages as source
by osmith 05 Aug '22

05 Aug '22
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28928 ) Change subject: obs-mirror: use obs.osmocom.org packages as source ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id6be69530a7aa65b0cf3866fc7e65af79c9d9d45 Gerrit-Change-Number: 28928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 08:16:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-msc[master]: Introduce libsmpputil
by daniel 05 Aug '22

05 Aug '22
Attention is currently required from: pespin, msuraev. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 ) Change subject: Introduce libsmpputil ...................................................................... Patch Set 11: Code-Review-1 (3 comments) File tests/db_sms/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/6a6a35bd_e8974102 PS11, Line 40: $(top_builddir)/src/libsmpputil/libsmpputil.a \ You now only build libsmpputil if BUILD_SMPP, but db_sms_test is built unconditionally. make check now fails (if smpp is not enabled): make sms_queue_test make[4]: Entering directory '/home/daniel/scm/osmo/osmo-msc/tests/sms_queue' make[4]: *** No rule to make target '../../src/libsmpputil/libsmpputil.a', needed by 'sms_queue_test'. Stop. It seems like you don't need anything from libsmpputil, so just remove it. The test builds and passes here if I do that. File tests/msc_vlr/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/f8f46f77_fb1aff9f PS11, Line 35: $(top_builddir)/src/libsmpputil/libsmpputil.a \ Same File tests/sms_queue/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/a3bf8280_1404acdf PS11, Line 39: $(top_builddir)/src/libsmpputil/libsmpputil.a \ Same -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb Gerrit-Change-Number: 28844 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 07:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-tetra[master]: when traffic dump directory is specified, now prints error message an...
by daniel 05 Aug '22

05 Aug '22
Attention is currently required from: wbokslag. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28926 ) Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/28926/comment/1c6a1e32_447105bf PS3, Line 200: fprintf(stderr, "could not open dump file %s for writing\n", fname); You could use perror or a strerror variant to include the reason it failed. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88 Gerrit-Change-Number: 28926 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Fri, 05 Aug 2022 06:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in libosmocore[master]: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS
by daniel 05 Aug '22

05 Aug '22
Attention is currently required from: fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28918 ) Change subject: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3 Gerrit-Change-Number: 28918 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 06:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: add SpeechCodecList param to tr_BSSMAP_HandoverRequest
by daniel 05 Aug '22

05 Aug '22
Attention is currently required from: fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28919 ) Change subject: BSSMAP_Templates: add SpeechCodecList param to tr_BSSMAP_HandoverRequest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5ce0c03fd4198e26068ddd1f18f2e17b1ae533d Gerrit-Change-Number: 28919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 06:54:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 201
  • 202
  • 203
  • 204
  • 205
  • 206
  • 207
  • ...
  • 241
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.