August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28921 ) Change subject: libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS ...................................................................... libosmo{abis,trau}: add -no-undefined to *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: Ib03f939d532173d9e4fcfdf5476c458a21c2c665 --- M src/Makefile.am 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 1404982..cf8de47 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,7 +11,10 @@ lib_LTLIBRARIES = libosmoabis.la libosmotrau.la -libosmoabis_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(ABIS_LIBVERSION) +libosmoabis_la_LDFLAGS = $(AM_LDFLAGS) \ + -version-info $(ABIS_LIBVERSION) \ + -no-undefined \ + $(NULL) libosmoabis_la_LIBADD = $(COMMONLIBS) libosmoabis_la_SOURCES = init.c \ e1_input.c \ @@ -33,7 +36,10 @@ endif libosmotrau_la_CFLAGS = $(AM_CFLAGS) $(ORTP_CFLAGS) -libosmotrau_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(TRAU_LIBVERSION) +libosmotrau_la_LDFLAGS = $(AM_LDFLAGS) \ + -version-info $(TRAU_LIBVERSION) \ + -no-undefined \ + $(NULL) libosmotrau_la_LIBADD = $(COMMONLIBS) $(ORTP_LIBS) libosmotrau_la_SOURCES = trau/osmo_ortp.c \ trau/trau_frame.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib03f939d532173d9e4fcfdf5476c458a21c2c665 Gerrit-Change-Number: 28921 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28922 ) Change subject: libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS ...................................................................... libosmo-sbcap: add -no-undefined to libosmo_sbcap_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: Id08bbd5ba35ef3f507f60f31a0634f921ec1db65 --- M src/sbcap/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sbcap/Makefile.am b/src/sbcap/Makefile.am index b98bf42..4130a90 100644 --- a/src/sbcap/Makefile.am +++ b/src/sbcap/Makefile.am @@ -376,7 +376,7 @@ sbcap_LIBVERSION=0:0:0 lib_LTLIBRARIES = libosmo-sbcap.la -libosmo_sbcap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(sbcap_LIBVERSION) +libosmo_sbcap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(sbcap_LIBVERSION) -no-undefined libosmo_sbcap_la_LIBADD = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) \ $(ASN1C_LIBS) libosmo-asn1-sbcap.la libosmo_sbcap_la_SOURCES = sbcap_common.c -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id08bbd5ba35ef3f507f60f31a0634f921ec1db65 Gerrit-Change-Number: 28922 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-iuh[master]: libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28924 ) Change subject: libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS ...................................................................... libosmo-{hnbap,ranap,rua,sabp}: add -no-undefined to *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: I659d277049173e8fc86934140d552f6a494971a1 --- M src/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index 87f6837..9e447e6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -66,23 +66,23 @@ RUA_LIBVERSION=0:0:0 SABP_LIBVERSION=1:0:0 lib_LTLIBRARIES = libosmo-hnbap.la libosmo-ranap.la libosmo-rua.la libosmo-sabp.la -libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) +libosmo_hnbap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) -no-undefined libosmo_hnbap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) hnbap/libosmo-asn1-hnbap.la libosmo_hnbap_la_SOURCES = hnbap_common.c hnbap_encoder.c hnbap_decoder.c -libosmo_ranap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RANAP_LIBVERSION) +libosmo_ranap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RANAP_LIBVERSION) -no-undefined libosmo_ranap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) ranap/libosmo-asn1-ranap.la libosmo_ranap_la_SOURCES = ranap_common.c ranap_encoder.c ranap_decoder.c ranap_msg_factory.c iu_helpers.c \ ranap_common_cn.c ranap_common_ran.c iu_client.c iu_client_vty.c -libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) +libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) -no-undefined libosmo_rua_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) rua/libosmo-asn1-rua.la libosmo_rua_la_SOURCES = rua_common.c rua_encoder.c rua_decoder.c rua_msg_factory.c -libosmo_sabp_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(SABP_LIBVERSION) +libosmo_sabp_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(SABP_LIBVERSION) -no-undefined libosmo_sabp_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) sabp/libosmo-asn1-sabp.la libosmo_sabp_la_SOURCES = sabp_common.c sabp_encoder.c sabp_decoder.c -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I659d277049173e8fc86934140d552f6a494971a1 Gerrit-Change-Number: 28924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-iuh[master]: libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28923 ) Change subject: libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION ...................................................................... libosmo-rua: fix copy-pasted -version-info: {HNBAP->RUA}_LIBVERSION Change-Id: I71b859d3c9ecfaf9bffa6341291267ddef071448 --- M src/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved daniel: Looks good to me, approved diff --git a/src/Makefile.am b/src/Makefile.am index c2f9adf..87f6837 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -77,7 +77,7 @@ libosmo_ranap_la_SOURCES = ranap_common.c ranap_encoder.c ranap_decoder.c ranap_msg_factory.c iu_helpers.c \ ranap_common_cn.c ranap_common_ran.c iu_client.c iu_client_vty.c -libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(HNBAP_LIBVERSION) +libosmo_rua_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RUA_LIBVERSION) libosmo_rua_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) $(OSMOSIGTRAN_LIBS) \ $(ASN1C_LIBS) rua/libosmo-asn1-rua.la libosmo_rua_la_SOURCES = rua_common.c rua_encoder.c rua_decoder.c rua_msg_factory.c -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I71b859d3c9ecfaf9bffa6341291267ddef071448 Gerrit-Change-Number: 28923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-mgw[master]: libosmo-mgcp-client: add -no-undefined to *_la_LDFLAGS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28925 ) Change subject: libosmo-mgcp-client: add -no-undefined to *_la_LDFLAGS ...................................................................... libosmo-mgcp-client: add -no-undefined to *_la_LDFLAGS Make sure that there is no undefined references in shared libraries. Change-Id: If6aa8016026beb8bad735987f3ab6e0d114b86a5 --- M src/libosmo-mgcp-client/Makefile.am 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/Makefile.am b/src/libosmo-mgcp-client/Makefile.am index 2c5c653..fffb42a 100644 --- a/src/libosmo-mgcp-client/Makefile.am +++ b/src/libosmo-mgcp-client/Makefile.am @@ -35,4 +35,8 @@ mgcp_client_pool.c \ $(NULL) -libosmo_mgcp_client_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(MGCP_CLIENT_LIBVERSION) +libosmo_mgcp_client_la_LDFLAGS = \ + $(AM_LDFLAGS) \ + -version-info $(MGCP_CLIENT_LIBVERSION) \ + -no-undefined \ + $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If6aa8016026beb8bad735987f3ab6e0d114b86a5 Gerrit-Change-Number: 28925 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: logging: add a new category DLCSN1 for libosmo-csn1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28917 ) Change subject: logging: add a new category DLCSN1 for libosmo-csn1 ...................................................................... logging: add a new category DLCSN1 for libosmo-csn1 This new category is going to be used by CSN.1 codec in libosmo-csn1. Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95 --- M include/osmocom/core/logging.h M src/logging.c M tests/logging/logging_vty_test.vty 3 files changed, 11 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 0078425..f1304f5 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -151,7 +151,8 @@ #define DLNSSIGNAL -23 /*!< Osmocom NS layer signal pdus */ #define DLIUUP -24 /*!< Osmocom IuUP layer */ #define DLPFCP -25 /*!< Osmocom Packet Forwarding Control Protocol */ -#define OSMO_NUM_DLIB 25 /*!< Number of logging sub-systems in libraries */ +#define DLCSN1 -26 /*!< CSN.1 (Concrete Syntax Notation 1) codec */ +#define OSMO_NUM_DLIB 26 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/src/logging.c b/src/logging.c index 1a0abc2..ce42e4c 100644 --- a/src/logging.c +++ b/src/logging.c @@ -307,6 +307,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;51m", }, + [INT2IDX(DLCSN1)] = { + .name = "DLCSN1", + .description = "libosmo-csn1 Concrete Syntax Notation 1 codec", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;11m", + }, }; void assert_loginfo(const char *src) diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index 860f5c5..2cff62c 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -54,7 +54,7 @@ logging print level (0|1) logging print file (0|1|basename) [last] logging set-log-mask MASK - logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp) (debug|info|notice|error|fatal) + logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1) (debug|info|notice|error|fatal) logging level set-all (debug|info|notice|error|fatal) logging level force-all (debug|info|notice|error|fatal) no logging level force-all @@ -472,7 +472,7 @@ logging_vty_test# list ... - logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp) (debug|info|notice|error|fatal) .LOGMESSAGE + logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup|lpfcp|lcsn1) (debug|info|notice|error|fatal) .LOGMESSAGE ... logging_vty_test# logp? @@ -509,6 +509,7 @@ lnssignal GPRS NS layer signal PDU liuup Iu UP layer lpfcp libosmo-pfcp Packet Forwarding Control Protocol + lcsn1 libosmo-csn1 Concrete Syntax Notation 1 codec logging_vty_test# logp lglobal ? debug Log debug messages and higher levels -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95 Gerrit-Change-Number: 28917 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in gapk[master]: configure: fix warning: AC_OUTPUT should be used without arguments

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/28934 ) Change subject: configure: fix warning: AC_OUTPUT should be used without arguments ...................................................................... configure: fix warning: AC_OUTPUT should be used without arguments Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 --- M configure.ac 1 file changed, 10 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/configure.ac b/configure.ac index b16acc8..ad659ca 100644 --- a/configure.ac +++ b/configure.ac @@ -15,16 +15,6 @@ AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_TESTDIR(tests) -AC_CONFIG_FILES([ - Makefile - src/Makefile - libgsmhr/Makefile - include/Makefile - include/gsmhr/Makefile - libosmogapk.pc - tests/atlocal - tests/Makefile -]) # Options AC_ARG_ENABLE(gsmhr, @@ -117,4 +107,13 @@ AC_FUNC_MALLOC AC_CHECK_FUNCS([memset]) -AC_OUTPUT([contrib/gapk.spec]) +AC_CONFIG_FILES([contrib/gapk.spec + Makefile + src/Makefile + libgsmhr/Makefile + include/Makefile + include/gsmhr/Makefile + libosmogapk.pc + tests/atlocal + tests/Makefile]) +AC_OUTPUT -- To view, visit https://gerrit.osmocom.org/c/gapk/+/28934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I32b07f8f8c3f4092683fa6a25a7e895f188640b7 Gerrit-Change-Number: 28934 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: gitignore: ignore *.la objects: libosmo-{gtlv,pfcp}.la

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28936 ) Change subject: gitignore: ignore *.la objects: libosmo-{gtlv,pfcp}.la ...................................................................... gitignore: ignore *.la objects: libosmo-{gtlv,pfcp}.la Change-Id: I72b2b62cfa232accb4f8ae114be40058ccd512c7 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 3027037..2d26084 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ *.o *.lo *.a +*.la .deps Makefile Makefile.in -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I72b2b62cfa232accb4f8ae114be40058ccd512c7 Gerrit-Change-Number: 28936 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: gprs_ns2: add vty `nse <0-65535> restart sns`

by fixeria

Attention is currently required from: laforge, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 ) Change subject: gprs_ns2: add vty `nse <0-65535> restart sns` ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb55d8449908d348ab10572eebcf971737fba00d Gerrit-Change-Number: 23184 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 05 Aug 2022 11:43:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bsc-nat[master]: bssap_conn: fix missing length check

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 ) Change subject: bssap_conn: fix missing length check ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/d03238c6_6c54670b PS3, Line 56: enc_err = gsm0808_enc_aoip_trasp_addr(msg_new, ss) == 0; Better add paraenthesis it's clearer: enc_err = (gsm0808_enc_aoip_trasp_addr(msg_new, ss) == 0); https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/8389d2c5_33481adb PS3, Line 61: enc_err = tlv_encode_one(msg_new, def->def[tag].type, tag, len_v, val) < 0; Same, paranthesis, otherwise it's easy tonot see the comparision at the end (it happened to me). https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582/comment/63be6e8f_e55a28d4 PS3, Line 64: if (enc_err) { BTW, this looks to me a like a good candidate for goto. at the end of function: """ enc_err: LOGP(DMAIN, LOGL_ERROR, "Failed to encode tag %d into copy of bssmap msg\n", tag); msgb_free(msg_new); return -EINVAL; """ Then in all those places above, simply do "goto enc_err;", paths will become a lot simplet and cleaner imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1fc4c81e139bab3d7d977ef9467f62d8088884db Gerrit-Change-Number: 28582 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 11:25:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022