Attention is currently required from: wbokslag. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28926 ) Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/lower_mac/tetra_lower_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/28926/comment/1c6a1e32_447105bf PS3, Line 200: fprintf(stderr, "could not open dump file %s for writing\n", fname); You could use perror or a strerror variant to include the reason it failed. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88 Gerrit-Change-Number: 28926 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Comment-Date: Fri, 05 Aug 2022 06:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment