Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 )
Change subject: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest
......................................................................
Patch Set 1:
(1 comment)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920/comment/e23a8de7_0a68…
PS1, Line 5806: kC128, codecList := ?);
why not setting codecList := ? as default if it should always be present? And changing the type to template (present)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2e0ecbcced9f94d2b44d981db353007cad3ae959
Gerrit-Change-Number: 28920
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 09:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28918 )
Change subject: {gb,sim,usb}: ensure -no-undefined is present in *_la_LDFLAGS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28918
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7ddd6c75935b0f25d78a948f1577656d77a204e3
Gerrit-Change-Number: 28918
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 09:35:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28917 )
Change subject: logging: add a new category DLCSN1 for libosmo-csn1
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
You could simply set a dynamic value at runtime for it, but ok.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28917
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie8c0effb764547a0f9cc8c6825e11a6617501e95
Gerrit-Change-Number: 28917
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Aug 2022 09:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment