Attention is currently required from: msuraev.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28992 )
Change subject: Add osmo_sockaddr_strs_to_str()
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
Gerrit-Change-Number: 28992
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:45:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/28995
to look at the new patch set (#5).
Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky
......................................................................
Make osmo_sockaddr_str_from_sockaddr() less picky
Attempt to guess the AF_INET* type in 'struct sockaddr_storage'
before converting it.
Related: OS#5581
Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
---
M src/sockaddr_str.c
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/28995/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str_from_sockaddr2()
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
I'll update existing function instead in the next version.
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/70fe1509_5c875e31
PS4, Line 380: {
> as far as I can see the guess is the only difference. Maybe the api doc can reflect that. […]
Ack
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/b485c13f_e36e958e
PS4, Line 385:
> the guess above dereferences src, in the case where src == NULL, the function would have crashed alr […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29021 )
Change subject: pkgconf: require libosmocore
......................................................................
pkgconf: require libosmocore
osmocom/abis/e1_input.h includes osmocom/core/linuxlist.h, therefore
the .pc file(s) need a dependency on libosmocore so that the Cflags
from libosmocore.pc make an appearance on the compiler command line
when using `pkg-config libosmoabis --cflags`.
Committed-by: Max <msuraev(a)sysmocom.de>
Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
---
M libosmoabis.pc.in
M libosmotrau.pc.in
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/libosmoabis.pc.in b/libosmoabis.pc.in
index 751149d..da113fc 100644
--- a/libosmoabis.pc.in
+++ b/libosmoabis.pc.in
@@ -8,4 +8,4 @@
Version: @VERSION@
Libs: -L${libdir} -losmoabis
Cflags: -I${includedir}/
-
+Requires: libosmocore
diff --git a/libosmotrau.pc.in b/libosmotrau.pc.in
index d15c5fa..50ab9d0 100644
--- a/libosmotrau.pc.in
+++ b/libosmotrau.pc.in
@@ -8,3 +8,4 @@
Version: @VERSION@
Libs: -L${libdir} -losmotrau
Cflags: -I${includedir}/
+Requires: libosmocore
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iacf4ccdb1c2a0e64ac997bda11161b8fe2548725
Gerrit-Change-Number: 29021
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 )
Change subject: msc: f_tc_mt_t310: allow CRCX in either order
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea
Gerrit-Change-Number: 29024
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:37:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment