August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SA...

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 ) Change subject: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SACCH L1H ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35 Gerrit-Change-Number: 29023 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:35:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 ) Change subject: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1 Gerrit-Change-Number: 29022 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:34:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

by neels

Attention is currently required from: osmith, laforge, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 ) Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp ...................................................................... Patch Set 2: (3 comments) File debian/control: https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/0b8e3e49_3066d766 PS1, Line 13: python3-minimal > i thought the same, but figured for vty tests, […] Done https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/2d09e5ad_7c3a5270 PS1, Line 18: Vcs > please use https://gitea.osmocom.org/osmocom/libosmo-pfcp for Vcs-git and Vcs-browser these days. Done File debian/copyright: https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/77430b30_0c47070f PS1, Line 3: Source: git://git.osmocom.org/libosmo-pfcp > same here, please use https://gitea.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53 Gerrit-Change-Number: 29005 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:33:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

by neels

Attention is currently required from: osmith, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 ) Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: BTW, I checked that the browsing URL https://gitea.osmocom.org/osmocom/libosmo-pfcp also serves as a clone URL without having to append ".git" File debian/control: https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005/comment/1ba077d4_69b6c40e PS1, Line 13: python3-minimal > Do we really need python, btw? i thought the same, but figured for vty tests, but now i notice that this library-only repos has no programs with vty tests. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53 Gerrit-Change-Number: 29005 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:32:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: README.md: tweak clone URL

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 ) Change subject: README.md: tweak clone URL ...................................................................... README.md: tweak clone URL Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/26/29026/1 diff --git a/README.md b/README.md index de85ca1..9dd12c0 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ You can clone from the official libosmo-pfcp.git repository using - git clone git://git.osmocom.org/libosmo-pfcp.git + git clone https://gitea.osmocom.org/osmocom/libosmo-pfcp To submit patches, see "Contributing" below. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Idcfd4421189c711f95926f7e66da3402c059dfff Gerrit-Change-Number: 29026 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: debian packaging of libosmo-gtlv and libosmo-pfcp

by neels

Attention is currently required from: osmith, neels. Hello osmith, Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 to look at the new patch set (#2). Change subject: debian packaging of libosmo-gtlv and libosmo-pfcp ...................................................................... debian packaging of libosmo-gtlv and libosmo-pfcp Fix debian packaging, so far a copy-paste from osmo-upf.git crept in here by accident. Related: SYS#5895 Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53 --- M debian/changelog M debian/compat M debian/control M debian/copyright A debian/libosmo-gtlv0.install R debian/libosmo-pfcp0.install M debian/rules M tests/libosmo-pfcp/Makefile.am 8 files changed, 96 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/05/29005/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id7169fc67b4f8f77dfbeff9f199e6557ced67a53 Gerrit-Change-Number: 29005 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: vty doc tweaks

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29020 ) Change subject: vty doc tweaks ...................................................................... vty doc tweaks Clarify "Add" and "Delete" of GTP devices. Clarify GTP device in config vs. real GTP device. Clarify s/kernel/Linux kernel Related: SYS#5599 Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6 --- M src/osmo-upf/upf_vty.c M tests/upf.vty 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c index 386aa2f..5227dba 100644 --- a/src/osmo-upf/upf_vty.c +++ b/src/osmo-upf/upf_vty.c @@ -86,7 +86,7 @@ DEFUN(cfg_gtp, cfg_gtp_cmd, "gtp", - "Enter the 'gtp' node to configure GTP kernel module usage\n") + "Enter the 'gtp' node to configure Linux GTP kernel module usage\n") { vty->node = GTP_NODE; return CMD_SUCCESS; @@ -135,7 +135,8 @@ DEFUN(cfg_gtp_dev_create, cfg_gtp_dev_create_cmd, "dev create DEVNAME [LISTEN_ADDR]", DEV_STR - "create a new GTP device. Will listen on GTPv1 port " OSMO_STRINGIFY_VAL(PORT_GTP1_U) + "Add GTP device, creating a new Linux kernel GTP device. Will listen on GTPv1 port " + OSMO_STRINGIFY_VAL(PORT_GTP1_U) " and GTPv0 port " OSMO_STRINGIFY_VAL(PORT_GTP0_U) " on the specified interface, or on ANY if LISTEN_ADDR is" " omitted.\n" "device name, e.g. 'apn0'\n" @@ -154,7 +155,7 @@ DEFUN(cfg_gtp_dev_use, cfg_gtp_dev_use_cmd, "dev use DEVNAME", DEV_STR - "use an existing GTP device, e.g. created by 'gtp-link'\n" + "Add GTP device, using an existing Linux kernel GTP device, e.g. created by 'gtp-link'\n" "device name, e.g. 'apn0'\n") { struct gtp_vty_cfg_dev *d = talloc_zero(g_upf, struct gtp_vty_cfg_dev); @@ -168,7 +169,7 @@ DEFUN(cfg_gtp_dev_del, cfg_gtp_dev_del_cmd, "dev delete DEVNAME", DEV_STR - "Remove a GTP device from the configuration, and delete the device if it was created here.\n" + "Remove a GTP device from the configuration, and delete the Linux kernel GTP device if it was created here.\n" "device name, e.g. 'apn0'\n") { const char *dev_name = argv[0]; diff --git a/tests/upf.vty b/tests/upf.vty index 107909b..d1cebe5 100644 --- a/tests/upf.vty +++ b/tests/upf.vty @@ -23,9 +23,9 @@ OsmoUPF(config-gtp)# dev? dev Configure the GTP device to use for encaps/decaps. OsmoUPF(config-gtp)# dev ? - create create a new GTP device. Will listen on GTPv1 port 2152 and GTPv0 port 3386 on the specified interface, or on ANY if LISTEN_ADDR is omitted. - use use an existing GTP device, e.g. created by 'gtp-link' - delete Remove a GTP device from the configuration, and delete the device if it was created here. + create Add GTP device, creating a new Linux kernel GTP device. Will listen on GTPv1 port 2152 and GTPv0 port 3386 on the specified interface, or on ANY if LISTEN_ADDR is omitted. + use Add GTP device, using an existing Linux kernel GTP device, e.g. created by 'gtp-link' + delete Remove a GTP device from the configuration, and delete the Linux kernel GTP device if it was created here. OsmoUPF(config-gtp)# dev create ? DEVNAME device name, e.g. 'apn0' OsmoUPF(config-gtp)# dev create foo ? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6 Gerrit-Change-Number: 29020 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: main: show just a brief talloc report for vty

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28984 ) Change subject: main: show just a brief talloc report for vty ...................................................................... main: show just a brief talloc report for vty Upon ^C, do not barf a huge amount of full talloc report for the entire VTY config tree. Show a brief report on VTY instead. Related: SYS#5599 Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 --- M src/osmo-upf/osmo_upf_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/osmo-upf/osmo_upf_main.c b/src/osmo-upf/osmo_upf_main.c index 81102dd..b4888af 100644 --- a/src/osmo-upf/osmo_upf_main.c +++ b/src/osmo-upf/osmo_upf_main.c @@ -377,7 +377,7 @@ talloc_report_full(tall_infra_ctx, stderr); talloc_free(tall_infra_ctx); - talloc_report_full(tall_vty_ctx, stderr); + talloc_report(tall_vty_ctx, stderr); talloc_free(tall_vty_ctx); talloc_report_full(NULL, stderr); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 Gerrit-Change-Number: 28984 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: add comment about fd cleanup

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28985 ) Change subject: add comment about fd cleanup ...................................................................... add comment about fd cleanup Clarify that calling osmo_fd_close() is fine if no fd is open. Related: SYS#5599 Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 --- M src/osmo-upf/upf_gtp.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 4a430cb..6280e45 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -449,6 +449,7 @@ while ((t = llist_first_entry_or_null(&dev->tunnels, struct upf_gtp_tun, entry))) talloc_free(t); llist_del(&dev->entry); + /* osmo_fd_close() is a noop if ofd.fd == -1 */ osmo_fd_close(&dev->gtpv0.ofd); osmo_fd_close(&dev->gtpv1.ofd); if (dev->created) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 Gerrit-Change-Number: 28985 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: log: fix/tweak log msg about nft/mockup

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28983 ) Change subject: log: fix/tweak log msg about nft/mockup ...................................................................... log: fix/tweak log msg about nft/mockup There is no cmdline option --mockup-nft, that was an earlier stage of the nftables mockup patch. Related: SYS#5599 Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 --- M src/osmo-upf/upf_nft.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-upf/upf_nft.c b/src/osmo-upf/upf_nft.c index c035016..bcb6a70 100644 --- a/src/osmo-upf/upf_nft.c +++ b/src/osmo-upf/upf_nft.c @@ -40,7 +40,7 @@ int rc; if (g_upf->nft.mockup) { - LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not running nft ruleset: '%s'\n", ruleset); + LOGP(DNFT, LOGL_NOTICE, "nft/mockup active: not running nft ruleset: '%s'\n", ruleset); return 0; } @@ -63,7 +63,8 @@ { int rc; if (g_upf->nft.mockup) { - LOGP(DNFT, LOGL_NOTICE, "--mockup-gtp active, not allocating libnftables nft_ctx\n"); + LOGP(DNFT, LOGL_NOTICE, + "nft/mockup active: not allocating libnftables nft_ctx. FOR TESTING PURPOSES ONLY.\n"); return 0; } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 Gerrit-Change-Number: 28983 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022