August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: vty doc tweaks

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29020 ) Change subject: vty doc tweaks ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial change, let's spare you guys the review -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I918e0a9a332e4dd4b71965614c19481eb41004d6 Gerrit-Change-Number: 29020 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 ) Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: re-adding previous +2 after trivial change -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 Gerrit-Change-Number: 28971 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_e1: fix apidoc

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29025 ) Change subject: mgcp_e1: fix apidoc ...................................................................... mgcp_e1: fix apidoc Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5 --- M src/libosmo-mgcp/mgcp_e1.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/29025/1 diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 9a6efe2..7f30c1d 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -496,7 +496,7 @@ } } -/* !Equip E1 endpoint with I.460 mux resources. +/*! Equip E1 endpoint with I.460 mux resources. * \param[in] endp endpoint to equip * \param[in] ts E1 timeslot number. * \param[in] ss E1 subslot number. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaccb9b67e72d113483160e61f660ea9c4c2f53a5 Gerrit-Change-Number: 29025 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: my s/ rule missed quite a few of them in the last patch set, i've put all possible modifiers for templates now, afaict. In other news, i already find it annoying as hell that my ctags jumps no longer work for PFCP templates :/ guess i need to do universal-ctags hacking -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 to look at the new patch set (#5). Change subject: add library/PFCP_*, deps/PFCP ...................................................................... add library/PFCP_*, deps/PFCP Will soon be used by new subdir 'upf' (test osmo-upf), and by 'hnbgw' (test GTP mapping via UPF). Related: SYS#5599 Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f --- M deps/Makefile M library/General_Types.ttcn A library/PFCP_CodecPort.ttcn A library/PFCP_CodecPort_CtrlFunct.ttcn A library/PFCP_CodecPort_CtrlFunctDef.cc A library/PFCP_Emulation.ttcn A library/PFCP_Templates.ttcn 7 files changed, 926 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/28817/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: allow CRCX in either order

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 ) Change subject: msc: f_tc_mt_t310: allow CRCX in either order ...................................................................... msc: f_tc_mt_t310: allow CRCX in either order continued from Id0c98bc267daff352fc7db7712f967111970fd4d Upcoming changes to osmo-msc move the CN side CRCX to an earlier point in time, reversing that order. Introduce an 'interleave' to not care about the ordering of MGCP and BSSAP messages. Related: SYS#5066 Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc) Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea --- M msc/MSC_Tests.ttcn 1 file changed, 18 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/29024/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 79221d7..d6e0aba 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1771,25 +1771,31 @@ /* NOTE: MSC is expected to start T310 here */ + interleave { /* MSC->MGW: CRCX (first) */ - MGCP.receive(tr_CRCX) -> value mgcp_cmd; - f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { + f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + } /* BSC->BSC: BSSMAP ASSIGNMENT REQ */ - BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap; - BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, - aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port), - speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR }))); + [] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, ?)) -> value bssap { + BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, + aoip := f_ts_BSSMAP_IE_AoIP_TLA(cpars.bss_rtp_ip, cpars.bss_rtp_port), + speechCodec := ts_BSSMAP_IE_SpeechCodec({ ts_CodecFR }))); + } /* MSC->MGW: MDCX */ - MGCP.receive(tr_MDCX) -> value mgcp_cmd; - MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_1.mgcp_connection_id, - sdp := omit)); + [] MGCP.receive(tr_MDCX) -> value mgcp_cmd { + MGCP.send(ts_MDCX_ACK(mgcp_cmd.line.trans_id, cpars.mgw_conn_1.mgcp_connection_id, + sdp := omit)); + } /* MSC->MGW: CRCX (second) */ - MGCP.receive(tr_CRCX) -> value mgcp_cmd; - f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ - MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); + [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { + f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ + MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); + } + } /* Reschedule the guard timeout */ g_Tguard.start(30.0 + 10.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0ec348df08aa49ed58b3465de51b259fb74c0aea Gerrit-Change-Number: 29024 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc: f_tc_mt_t310: detect MNCC failure explicitly

by neels

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 to look at the new patch set (#3). Change subject: msc: f_tc_mt_t310: detect MNCC failure explicitly ...................................................................... msc: f_tc_mt_t310: detect MNCC failure explicitly Helped me find a failure cause: instead of T_guard timeout, immediately show an unexpected MNCC event. Related: SYS#5066 Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 --- M msc/MSC_Tests.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/28971/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49a15142a4b6c51ca767a884c0574f96e01d7cb1 Gerrit-Change-Number: 28971 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28996 ) Change subject: Diversify osmo_sockaddr_str_*() error codes ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm sorry but I see the previous errors make a lot more sense than the one you are setting now, so I […] Which error code would you suggest to make those different? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10 Gerrit-Change-Number: 28996 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Aug 2022 12:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SA...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 ) Change subject: BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SACCH L1H ...................................................................... BTS_Tests: fix TC_rsl_ms_pwr_dyn_{up,ass_down,max}: reply received SACCH L1H As was explained in [1], until recently we relied on trxcon sendig dummy RR Measurement Reports with patched L1 SACCH Header values. Now trxcon does not patch it for us, so we need to send Uplink SACCH blocks with the correct L1H ourselves. Revision 2 of [1] was successfully tested and proved to fix the above-mentioned testcases. However during code review I was asked to make the statements sending Uplink SACCH blocks self-explanatory. In revision 3 of [1] I modified the code to call f_send_meas_rep(), which was introduced in [2], which as stated in the commit message is using g_pars.l1_pars.{ms_power_level,ms_actual_ta} instead of the values from received L1H. Of course this does not work. Add and use f_send_meas_rep_l1h(), which allows to send the given L1H. Take a chance to add a log() statement, so that we can see what we Tx. Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35 Fixes: [1] I31dd6b9026d04403092256176f67785a0a6486ad Related: [2] Ia5d0315e053702df5fa8dad8c6c66c11c9f3edcb Related: OS#5635 --- M bts/BTS_Tests.ttcn 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/29023/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 9f2e366..b2d6383 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -782,6 +782,15 @@ friend function f_send_meas_rep(template (value) MeasurementResults meas_res) runs on ConnHdlr { var template (value) SacchL1Header l1h; + + l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, g_pars.l1_pars.ms_actual_ta); + f_send_meas_rep_l1h(meas_res, l1h); +} + +/* Send the given measurement results and L1H to the IUT over the Um interface */ +friend function f_send_meas_rep_l1h(template (value) MeasurementResults meas_res, + template (value) SacchL1Header l1h) +runs on ConnHdlr { var octetstring l2; /* RR Measurement Report to be sent */ @@ -792,7 +801,8 @@ /* TITAN has weird (and often unusable) padding model, so we pad here manaully */ l2 := f_pad_oct(enc_LapdmFrameAB(valueof(ts_LAPDm_AB(0, meas_rep))), 21, '00'O); - l1h := ts_SacchL1Header(g_pars.l1_pars.ms_power_level, g_pars.l1_pars.ms_actual_ta); + + log(%definitionId, "(): Tx SACCH L1 header: ", l1h); /* Send RR Measurement Report over the Um interface */ L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); @@ -2979,7 +2989,7 @@ T2.start; alt { [] as_l1_sacch_l1h(l1h) { - f_send_meas_rep(ts_MeasurementResults); + f_send_meas_rep_l1h(ts_MeasurementResults, l1h); if (l1h.ms_power_lvl < (pwr_var + 6)) { repeat; @@ -3000,7 +3010,7 @@ T4.start; alt { [] as_l1_sacch_l1h(l1h) { - f_send_meas_rep(ts_MeasurementResults); + f_send_meas_rep_l1h(ts_MeasurementResults, l1h); if (l1h.ms_power_lvl > pwr_var) { repeat; @@ -3045,7 +3055,7 @@ T1.start; alt { [] as_l1_sacch_l1h(l1h) { - f_send_meas_rep(ts_MeasurementResults); + f_send_meas_rep_l1h(ts_MeasurementResults, l1h); repeat; } [] L1CTL.receive { repeat; } @@ -3094,7 +3104,7 @@ T1.start; alt { [] as_l1_sacch_l1h(l1h) { - f_send_meas_rep(ts_MeasurementResults); + f_send_meas_rep_l1h(ts_MeasurementResults, l1h); repeat; } [] L1CTL.receive { repeat; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia79a0a7b06394bd34d0f40226cf40e6e8bd2ba35 Gerrit-Change-Number: 29023 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 ) Change subject: BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma} ...................................................................... BTS_Tests: use f_send_meas_rep() in f_TC_ms_pwr_ctrl_{constant,pf_ewma} Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/29022/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index cbbb297..9f2e366 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -7877,10 +7877,7 @@ f_trxc_fake_rssi(mp_uplink_power_target); /* Populate SACCH cache with a Measurement Report */ - L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), - ts_SacchL1Header(g_pars.l1_pars.ms_power_level, - g_pars.l1_pars.ms_actual_ta), - f_pad_oct('010349'O & '0615004001C0'O, 21, '00'O))); + f_send_meas_rep(ts_MeasurementResults); /* Establish a dedicated channel */ f_est_dchan(more_ies := valueof(ies)); @@ -7944,10 +7941,7 @@ f_trxc_fake_rssi(mp_uplink_power_target); /* Populate SACCH cache with a Measurement Report */ - L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), - ts_SacchL1Header(g_pars.l1_pars.ms_power_level, - g_pars.l1_pars.ms_actual_ta), - f_pad_oct('010349'O & '0615004001C0'O, 21, '00'O))); + f_send_meas_rep(ts_MeasurementResults); /* Establish a dedicated channel */ f_est_dchan(more_ies := valueof(ies)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id80317d1e9de3873ab2d26470a3552b4f2b539b1 Gerrit-Change-Number: 29022 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022