August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Aug 2022 19:28:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits

by msuraev

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 to look at the new patch set (#3). Change subject: SCCP: enforce optional data length limits ...................................................................... SCCP: enforce optional data length limits Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 Related: OS#5579 Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd --- M src/sccp.c 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: log more data on CR and N-CONNECT

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 to look at the new patch set (#6). Change subject: SCCP: log more data on CR and N-CONNECT ...................................................................... SCCP: log more data on CR and N-CONNECT Log more details about optional Data sent with CR/N-CONNECT messages. Related: OS#5579 Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a --- M src/sccp.c M src/sccp_helpers.c 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/85/29085/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code

by msuraev

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 to look at the new patch set (#8). Change subject: cosmetic: improve usage help of example code ...................................................................... cosmetic: improve usage help of example code * document -C option for example server * move misplaced comma * drop empty #define from example code Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 --- M examples/sccp_demo_user.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/86/29086/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: add function to check connection existence

by msuraev

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 to look at the new patch set (#4). Change subject: SCCP: add function to check connection existence ...................................................................... SCCP: add function to check connection existence Add convenience helper to check if particular connection ID exists and use it to properly report errors when attempting to send messages over non-existent connections. Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c M src/sccp_scoc.c 4 files changed, 48 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: add function to check connection existence

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SCCP: add function to check connection existence ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 14 Aug 2022 16:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: log more data on CR and N-CONNECT

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 to look at the new patch set (#5). Change subject: SCCP: log more data on CR and N-CONNECT ...................................................................... SCCP: log more data on CR and N-CONNECT Log more details about optional Data sent with CR/N-CONNECT messages. Related: OS#5579 Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a --- M src/sccp.c M src/sccp_helpers.c 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/85/29085/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Enforce optional data length limits

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: Enforce optional data length limits ...................................................................... Patch Set 2: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/aec2c4a7_d70b6f8c PS1, Line 230: 130 > Might be a good idea to #define this value somewhere: either in this file, or in a header. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Aug 2022 15:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: log more data on CR and N-CONNECT

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 to look at the new patch set (#4). Change subject: SCCP: log more data on CR and N-CONNECT ...................................................................... SCCP: log more data on CR and N-CONNECT Log more details about optional Data sent with CR/N-CONNECT messages. Related: OS#5579 Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a --- M src/sccp.c M src/sccp_helpers.c 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/85/29085/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Enforce optional data length limits

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 to look at the new patch set (#2). Change subject: Enforce optional data length limits ...................................................................... Enforce optional data length limits Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 Related: OS#5579 Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd --- M src/sccp.c 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022