August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence

by msuraev

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 7: (2 comments) This change is ready for review. File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/310a2908_4033cfc1 PS4, Line 48: > We usually align arguments to the opening parenthesis. Ack File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/718acf67_ce1e5dcf PS4, Line 70: exist > 'conn_id' is a singular, so I guess it should be 'exists'? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Aug 2022 14:32:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 to look at the new patch set (#4). Change subject: SCCP: enforce optional data length limits ...................................................................... SCCP: enforce optional data length limits Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while receiving SCCP messages. Related: OS#5579 Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd --- M include/osmocom/sccp/sccp_types.h M src/sccp.c 2 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT

by msuraev

Attention is currently required from: msuraev. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 to look at the new patch set (#7). Change subject: Log more data on CR and N-CONNECT ...................................................................... Log more data on CR and N-CONNECT Log more details about optional Data sent with CR/N-CONNECT messages. Related: OS#5579 Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a --- M src/sccp.c M src/sccp_helpers.c 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/85/29085/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: use --long params for target 'regen'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/29090 ) Change subject: gen_makefile.py: use --long params for target 'regen' ...................................................................... gen_makefile.py: use --long params for target 'regen' This way the resulting Makefile is easier to read and understand, no need to lookup short params in help of gen_makefile.py. Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 --- M gen_makefile.py 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/90/29090/1 diff --git a/gen_makefile.py b/gen_makefile.py index 6459846..05bf9ff 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -391,11 +391,11 @@ regen: {script} \ {configure_opts} \ - -m {make_dir} \ - -o {makefile} \ - -s {src_dir} \ - -b {build_dir} \ - -u "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} + --output {makefile} \ + --src-dir {src_dir} \ + --make-dir {make_dir} \ + --build-dir {build_dir} \ + --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( script=os.path.relpath(sys.argv[0], make_dir), @@ -405,9 +405,9 @@ src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), url=args.url, - push_url=(" \\\n\t\t-p '%s'"%args.push_url) if args.push_url else '', - sudo_make_install=' \\\n\t\t-I' if args.sudo_make_install else '', - no_ldconfig=' \\\n\t\t-L' if args.no_ldconfig else '', + push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', + sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', + no_ldconfig=' \\\n\t\t--no-ldconfig' if args.no_ldconfig else '', ldconfig_without_sudo=' \\\n\t\t--ldconfig-without-sudo' if args.ldconfig_without_sudo else '', make_check='' if args.make_check else " \\\n\t\t--no-make-check", docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 Gerrit-Change-Number: 29090 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: add missing --jobs to target 'regen'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/29091 ) Change subject: gen_makefile.py: add missing --jobs to target 'regen' ...................................................................... gen_makefile.py: add missing --jobs to target 'regen' Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 --- M gen_makefile.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/91/29091/1 diff --git a/gen_makefile.py b/gen_makefile.py index 05bf9ff..b859112 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -395,6 +395,7 @@ --src-dir {src_dir} \ --make-dir {make_dir} \ --build-dir {build_dir} \ + --jobs {jobs} \ --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( @@ -404,6 +405,7 @@ makefile=args.output, src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), + jobs=args.jobs, url=args.url, push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 Gerrit-Change-Number: 29091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/29089 ) Change subject: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs ...................................................................... all.deps, {sanitize,werror}.opts: add project - libosmo-gprs Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/89/29089/1 diff --git a/all.deps b/all.deps index 7e099cf..5cb4811 100644 --- a/all.deps +++ b/all.deps @@ -1,6 +1,7 @@ # project build these first libosmocore libosmo-abis libosmocore +libosmo-gprs libosmocore libosmo-netif libosmo-abis libosmo-sccp libosmo-netif libsmpp34 @@ -19,7 +20,7 @@ # When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail. # So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries. osmo-trx libosmocore -osmo-pcu libosmocore +osmo-pcu libosmocore libosmo-gprs asn1c libasn1c osmo-gbproxy libosmocore osmo-pcap libosmocore diff --git a/sanitize.opts b/sanitize.opts index 51721bc..7abb8c6 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -1,6 +1,7 @@ libasn1c --enable-sanitize libosmo-abis --enable-sanitize libosmocore --enable-sanitize +libosmo-gprs --enable-sanitize libosmo-netif --enable-sanitize libosmo-sccp --enable-sanitize libosmo-pfcp --enable-sanitize diff --git a/werror.opts b/werror.opts index af7c8dd..1e7079a 100644 --- a/werror.opts +++ b/werror.opts @@ -1,6 +1,7 @@ libasn1c --enable-werror libosmo-abis --enable-werror libosmocore --enable-werror +libosmo-gprs --enable-werror libosmo-netif --enable-werror libosmo-sccp --enable-werror libosmo-pfcp --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 Gerrit-Change-Number: 29089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: use s#git://#https://# in git clone base URL

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/29088 ) Change subject: gen_makefile.py: use s#git://#https://# in git clone base URL ...................................................................... gen_makefile.py: use s#git://#https://# in git clone base URL Unencrypted git:// protocol offers no integrity or authentication, making it subject to tampering. Use https:// instead. https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-m… https://blog.readthedocs.com/github-git-protocol-deprecation/ Using https:// is also required for some new repositories (like libosmo-gprs.git), which are intentionally unavailable over git://. Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb --- M gen_makefile.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/88/29088/1 diff --git a/gen_makefile.py b/gen_makefile.py index 0e0df10..6459846 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -70,8 +70,8 @@ help='''Parent dir for all build trees (default: directly in the make-dir).''') -parser.add_argument('-u', '--url', dest='url', default='git://git.osmocom.org', - help='''git clone base URL. Default is 'git://git.osmocom.org'. +parser.add_argument('-u', '--url', dest='url', default='https://git.osmocom.org', + help='''git clone base URL. Default is 'https://git.osmocom.org'. e.g. with a config like this in your ~/.ssh/config: host go hostname gerrit.osmocom.org -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb Gerrit-Change-Number: 29088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: add function to check connection existence

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SCCP: add function to check connection existence ...................................................................... Patch Set 4: (2 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/19cbd30a_1232468e PS4, Line 48: We usually align arguments to the opening parenthesis. File include/osmocom/sigtran/sccp_helpers.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/318f3b5d_87fc8d04 PS4, Line 70: exist 'conn_id' is a singular, so I guess it should be 'exists'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Aug 2022 19:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Aug 2022 19:30:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SCCP: log more data on CR and N-CONNECT

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: SCCP: log more data on CR and N-CONNECT ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Aug 2022 19:29:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022