Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042
to look at the new patch set (#2).
Change subject: gtlv: fix repeated IEIs to several struct members
......................................................................
gtlv: fix repeated IEIs to several struct members
Coverity Scan has brought my attention to a problem with decoding
repeated IEIs, where there are multiple struct members in the decoded
struct that these are decoded to.
Before this patch, gtlv aborts with an error as soon as the first struct
member for a given tag is full, not parsing following IEIs into
subsequent struct members.
After this patch, gtlv continues to look whether subsequent entries in
the message coding also decode the same tag, but to a different struct
member.
First commit without changing the gtlv regression test, to show that all
current tests still succeed. The test for this particular issue follow
in I994d0fb1f1435d2c27a8630a43fe106652ac6e41
Related: CID#275415
Related: SYS#5599
Change-Id: Ie37585178ff27306d425b75d8e407b71f92f1cdc
---
M src/libosmo-gtlv/gtlv_dec_enc.c
1 file changed, 70 insertions(+), 20 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/42/29042/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29042
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie37585178ff27306d425b75d8e407b71f92f1cdc
Gerrit-Change-Number: 29042
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041
to look at the new patch set (#2).
Change subject: gtlv: check memory bounds 3/3: encoding to str
......................................................................
gtlv: check memory bounds 3/3: encoding to str
See Id8d997c9d5e655ff1842ec69eab6c073875c6330
Related: CID#275417
Related: SYS#5599
Change-Id: I63d52a4f5dba32d3a3887dd9c5e42e1695fb2aa3
---
M include/osmocom/gtlv/gtlv_dec_enc.h
M src/libosmo-gtlv/gtlv_dec_enc.c
M src/libosmo-gtlv/gtlv_gen.c
M tests/libosmo-gtlv/gtlv_dec_enc_test.c
M tests/libosmo-gtlv/test_gtlv_gen/gtlv_gen_test.c
M tests/libosmo-gtlv/test_tliv/tliv_test.c
6 files changed, 30 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/41/29041/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29041
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I63d52a4f5dba32d3a3887dd9c5e42e1695fb2aa3
Gerrit-Change-Number: 29041
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29094 )
Change subject: jobs/master-builds: archive core, testsuite.log
......................................................................
jobs/master-builds: archive core, testsuite.log
In case one of the master-buils is segfaulting or has an error in the
testsuite, collect the relevant files and store them as artifacts.
It was asked in the related issue to do this only on error, however
while there's an option to archive only artifacts when a build is
successful, there is not an option to do it only on failure. So just do
it always, the testsuite.log file is typically just a few kb in size.
core files should only get generated on error.
Closes: OS#5642
Change-Id: I91d4b995b16c8e028a5dff19b0e0f09c01d8c8c6
---
M jobs/master-builds.yml
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/94/29094/1
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index abeb4d6..eb1bf38 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -478,6 +478,9 @@
- shell: '{obj:cmd}'
publishers:
+ - archive:
+ allow-empty: true
+ artifacts: '**/core, **/testsuite.log'
- warnings:
console-log-parsers:
- 'GNU C Compiler 4 (gcc)'
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29094
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I91d4b995b16c8e028a5dff19b0e0f09c01d8c8c6
Gerrit-Change-Number: 29094
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: neels.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076
to look at the new patch set (#3).
Change subject: manual: update overview chart with PFCP
......................................................................
manual: update overview chart with PFCP
Change from ascii art to the dotty chart, taken from the osmocom.org
wiki. No need to keep a separate representation here.
Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b
---
M doc/manuals/chapters/overview.adoc
1 file changed, 51 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/76/29076/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b
Gerrit-Change-Number: 29076
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )
Change subject: add library/PFCP_*, deps/PFCP
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS5:
> you appear to have fixed ctags meanwhile. […]
https://github.com/universal-ctags/ctags/pull/3456
I wouldn't say "never" and see a tradeoff between effort and benefit. So far i didn't see the benefit of template restrictions, but after you made it clear that the restrictions are important the tradeoff shifted to submitting a PR.
It was easier than I thought and I'm very glad that u-ctags now tags all of the restricted templates everywhere, so happy end =)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f
Gerrit-Change-Number: 28817
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Aug 2022 13:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment