August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-sgsn[master]: configure.ac: do not require unused dlsym/dlopen

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 ) Change subject: configure.ac: do not require unused dlsym/dlopen ...................................................................... configure.ac: do not require unused dlsym/dlopen Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d --- M configure.ac 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/02/29102/1 diff --git a/configure.ac b/configure.ac index caa66d3..64b74e3 100644 --- a/configure.ac +++ b/configure.ac @@ -38,13 +38,6 @@ CFLAGS="$CFLAGS -std=gnu11" dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - -AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DLSYM) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d Gerrit-Change-Number: 29102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: configure.ac: do not search for dlopen, it's not used nor needed

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29101 ) Change subject: configure.ac: do not search for dlopen, it's not used nor needed ...................................................................... configure.ac: do not search for dlopen, it's not used nor needed Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 --- M configure.ac 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/29101/1 diff --git a/configure.ac b/configure.ac index 07a9757..9ecd66d 100644 --- a/configure.ac +++ b/configure.ac @@ -36,16 +36,13 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - # Enable/disable ipaccess-utils (src/ipacces/)? AC_ARG_ENABLE([ipaccess-utils], [AS_HELP_STRING([--enable-ipaccess-utils], [Build ipaccess utils: abisip-find, ipaccess-config, ...])], [osmo_ac_ipa_utils="$enableval"],[osmo_ac_ipa_utils="yes"]) AM_CONDITIONAL(BUILD_IPA_UTILS, test "x$osmo_ac_ipa_utils" = "xyes") AC_SUBST(osmo_ac_ipa_utils) +dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 Gerrit-Change-Number: 29101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: configure.ac: do not search for dlopen, it's not used nor needed

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 ) Change subject: configure.ac: do not search for dlopen, it's not used nor needed ...................................................................... configure.ac: do not search for dlopen, it's not used nor needed Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 --- M configure.ac 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/00/29100/1 diff --git a/configure.ac b/configure.ac index 15974ee..a3570a9 100644 --- a/configure.ac +++ b/configure.ac @@ -31,9 +31,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) dnl checks for header files -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 Gerrit-Change-Number: 29100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29099 ) Change subject: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST ...................................................................... tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae --- M tests/rlcmac/Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/99/29099/1 diff --git a/tests/rlcmac/Makefile.am b/tests/rlcmac/Makefile.am index a7193c2..633f090 100644 --- a/tests/rlcmac/Makefile.am +++ b/tests/rlcmac/Makefile.am @@ -13,8 +13,8 @@ $(NULL) EXTRA_DIST = \ - rlcmac/RLCMACTest.ok \ - rlcmac/RLCMACTest.err \ + RLCMACTest.ok \ + RLCMACTest.err \ $(NULL) RLCMACTest_SOURCES = RLCMACTest.c -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae Gerrit-Change-Number: 29099 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: tests/testsuite.at: remove $OSMO_QEMU, it's not used

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 ) Change subject: tests/testsuite.at: remove $OSMO_QEMU, it's not used ...................................................................... tests/testsuite.at: remove $OSMO_QEMU, it's not used Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 --- M tests/testsuite.at 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/98/29098/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 47a3e36..4669a00 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -5,5 +5,5 @@ AT_KEYWORDS([rlcmac]) cat $abs_srcdir/rlcmac/RLCMACTest.ok > expout cat $abs_srcdir/rlcmac/RLCMACTest.err > experr -AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) +AT_CHECK([$abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 Gerrit-Change-Number: 29098 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29089 ) Change subject: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs ...................................................................... all.deps, {sanitize,werror}.opts: add project - libosmo-gprs Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 4 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/all.deps b/all.deps index 7e099cf..5cb4811 100644 --- a/all.deps +++ b/all.deps @@ -1,6 +1,7 @@ # project build these first libosmocore libosmo-abis libosmocore +libosmo-gprs libosmocore libosmo-netif libosmo-abis libosmo-sccp libosmo-netif libsmpp34 @@ -19,7 +20,7 @@ # When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail. # So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries. osmo-trx libosmocore -osmo-pcu libosmocore +osmo-pcu libosmocore libosmo-gprs asn1c libasn1c osmo-gbproxy libosmocore osmo-pcap libosmocore diff --git a/sanitize.opts b/sanitize.opts index 51721bc..7abb8c6 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -1,6 +1,7 @@ libasn1c --enable-sanitize libosmo-abis --enable-sanitize libosmocore --enable-sanitize +libosmo-gprs --enable-sanitize libosmo-netif --enable-sanitize libosmo-sccp --enable-sanitize libosmo-pfcp --enable-sanitize diff --git a/werror.opts b/werror.opts index af7c8dd..1e7079a 100644 --- a/werror.opts +++ b/werror.opts @@ -1,6 +1,7 @@ libasn1c --enable-werror libosmo-abis --enable-werror libosmocore --enable-werror +libosmo-gprs --enable-werror libosmo-netif --enable-werror libosmo-sccp --enable-werror libosmo-pfcp --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 Gerrit-Change-Number: 29089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: add missing --jobs to target 'regen'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29091 ) Change subject: gen_makefile.py: add missing --jobs to target 'regen' ...................................................................... gen_makefile.py: add missing --jobs to target 'regen' Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 --- M gen_makefile.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 05bf9ff..b859112 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -395,6 +395,7 @@ --src-dir {src_dir} \ --make-dir {make_dir} \ --build-dir {build_dir} \ + --jobs {jobs} \ --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( @@ -404,6 +405,7 @@ makefile=args.output, src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), + jobs=args.jobs, url=args.url, push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 Gerrit-Change-Number: 29091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: use --long params for target 'regen'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29090 ) Change subject: gen_makefile.py: use --long params for target 'regen' ...................................................................... gen_makefile.py: use --long params for target 'regen' This way the resulting Makefile is easier to read and understand, no need to lookup short params in help of gen_makefile.py. Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 --- M gen_makefile.py 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 6459846..05bf9ff 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -391,11 +391,11 @@ regen: {script} \ {configure_opts} \ - -m {make_dir} \ - -o {makefile} \ - -s {src_dir} \ - -b {build_dir} \ - -u "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} + --output {makefile} \ + --src-dir {src_dir} \ + --make-dir {make_dir} \ + --build-dir {build_dir} \ + --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( script=os.path.relpath(sys.argv[0], make_dir), @@ -405,9 +405,9 @@ src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), url=args.url, - push_url=(" \\\n\t\t-p '%s'"%args.push_url) if args.push_url else '', - sudo_make_install=' \\\n\t\t-I' if args.sudo_make_install else '', - no_ldconfig=' \\\n\t\t-L' if args.no_ldconfig else '', + push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', + sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', + no_ldconfig=' \\\n\t\t--no-ldconfig' if args.no_ldconfig else '', ldconfig_without_sudo=' \\\n\t\t--ldconfig-without-sudo' if args.ldconfig_without_sudo else '', make_check='' if args.make_check else " \\\n\t\t--no-make-check", docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 Gerrit-Change-Number: 29090 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: use s#git://#https://# in git clone base URL

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29088 ) Change subject: gen_makefile.py: use s#git://#https://# in git clone base URL ...................................................................... gen_makefile.py: use s#git://#https://# in git clone base URL Unencrypted git:// protocol offers no integrity or authentication, making it subject to tampering. Use https:// instead. https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-m… https://blog.readthedocs.com/github-git-protocol-deprecation/ Using https:// is also required for some new repositories (like libosmo-gprs.git), which are intentionally unavailable over git://. Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb --- M gen_makefile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/gen_makefile.py b/gen_makefile.py index 0e0df10..6459846 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -70,8 +70,8 @@ help='''Parent dir for all build trees (default: directly in the make-dir).''') -parser.add_argument('-u', '--url', dest='url', default='git://git.osmocom.org', - help='''git clone base URL. Default is 'git://git.osmocom.org'. +parser.add_argument('-u', '--url', dest='url', default='https://git.osmocom.org', + help='''git clone base URL. Default is 'https://git.osmocom.org'. e.g. with a config like this in your ~/.ssh/config: host go hostname gerrit.osmocom.org -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb Gerrit-Change-Number: 29088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-dev[master]: gen_makefile.py: add missing --jobs to target 'regen'

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29091 ) Change subject: gen_makefile.py: add missing --jobs to target 'regen' ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 Gerrit-Change-Number: 29091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 15:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022