August 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Make osmo_sockaddr_str_from_sockaddr() less picky

by msuraev

Attention is currently required from: pespin, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 ) Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky ...................................................................... Patch Set 7: (1 comment) File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/befb4ad9_399120e4 PS7, Line 389: guess = (src->ss_family == AF_UNSPEC) ? osmo_sockaddr_guess_unspec((const struct sockaddr *)src) : src->ss_family; > This all looks wrong to me, or I'm missing soemthing. […] Not "random stuff" but the content withdots or colons which passed through osmo_sockaddr_guess_unspec(). The random stuff would still likely get AF_UNSPEC and won't be converted/printed. As the comment says: we relax restrictions, we do not remove them completely. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Aug 2022 09:14:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: update overview chart with PFCP

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 ) Change subject: manual: update overview chart with PFCP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b Gerrit-Change-Number: 29076 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Aug 2022 06:46:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: explain the PFCP port

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 ) Change subject: manual: explain the PFCP port ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 Gerrit-Change-Number: 29075 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Aug 2022 06:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: add missing bit on the MGCP port

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 ) Change subject: manual: add missing bit on the MGCP port ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f Gerrit-Change-Number: 29074 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Aug 2022 06:44:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 13 Aug 2022 06:44:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: pfcp_cp_peer: check use count correctness

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038 ) Change subject: pfcp_cp_peer: check use count correctness ...................................................................... pfcp_cp_peer: check use count correctness Related: CID#275418 Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf --- M src/libosmo-pfcp/pfcp_cp_peer.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libosmo-pfcp/pfcp_cp_peer.c b/src/libosmo-pfcp/pfcp_cp_peer.c index 959206a..d900370 100644 --- a/src/libosmo-pfcp/pfcp_cp_peer.c +++ b/src/libosmo-pfcp/pfcp_cp_peer.c @@ -388,7 +388,7 @@ m->ctx.peer_use_count = &cp_peer->use_count; m->ctx.peer_use_token = (m->rx ? "PFCPrx" : "PFCPtx"); - osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1); + OSMO_ASSERT(osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1) == 0); } /* Allocate a new PFCP request message to be sent to cp_peer->remote_addr. */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29038 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id79a84312b3ff8d562e26a525866b8bb09f9d0bf Gerrit-Change-Number: 29038 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in libosmo-pfcp[master]: doc: minor fix in pfcp_cp_peer_fsm.dot

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037 ) Change subject: doc: minor fix in pfcp_cp_peer_fsm.dot ...................................................................... doc: minor fix in pfcp_cp_peer_fsm.dot Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f --- M doc/charts/pfcp_cp_peer_fsm.dot 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/charts/pfcp_cp_peer_fsm.dot b/doc/charts/pfcp_cp_peer_fsm.dot index 101fe07..ec0d1fd 100644 --- a/doc/charts/pfcp_cp_peer_fsm.dot +++ b/doc/charts/pfcp_cp_peer_fsm.dot @@ -4,6 +4,7 @@ cp [label="CP function",shape="box"] +cp -> DISABLED [label="cp_peer_alloc()"] cp -> WAIT_ASSOC_SETUP_RESP [label="cp_peer_associate()"] txrx [label="PFCP socket",shape="box"] -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I0de10d5331df128081d6b875e3ba9c0c3c32bd9f Gerrit-Change-Number: 29037 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: add missing bit on the MGCP port

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 ) Change subject: manual: add missing bit on the MGCP port ...................................................................... manual: add missing bit on the MGCP port Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f --- M doc/manuals/chapters/running.adoc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/74/29074/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 6ad59a5..0bcca70 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -69,6 +69,7 @@ running on the same interface: - The SCCP/M3UA links are established by OsmoHNBGW contacting an STP. +- The MGCP link is established by OsmoHNBGW contacting an MGW. To run multiple OsmoHNBGW instances on the same SCCP routing, each HNBGW has to configure a distinct point-code, see <<configure_iucs_iups>>. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f Gerrit-Change-Number: 29074 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: explain the PFCP port

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 ) Change subject: manual: explain the PFCP port ...................................................................... manual: explain the PFCP port Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 --- M doc/manuals/chapters/running.adoc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/75/29075/1 diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 0bcca70..8074643 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -70,6 +70,7 @@ - The SCCP/M3UA links are established by OsmoHNBGW contacting an STP. - The MGCP link is established by OsmoHNBGW contacting an MGW. +- The PFCP link is established by OsmoHNBGW contacting a UPF. To run multiple OsmoHNBGW instances on the same SCCP routing, each HNBGW has to configure a distinct point-code, see <<configure_iucs_iups>>. @@ -140,3 +141,17 @@ mgw remote-port 2427 mgw reset-endpoint rtpbridge/* ---- + +==== Configure co-located User Plane Function + +OsmoHNBGW optionally supports relaying the GTP user plane via a co-located UPF, +which is controlled by the PFCP protocol. + +The following example configures OsmoHNBGW to associate via PFCP with a UPF, +ready to setup GTP tunnel relays. + +---- +hnbgw + pfcp + remote-addr 127.0.0.1 +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 Gerrit-Change-Number: 29075 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: manual: update overview chart with PFCP

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 ) Change subject: manual: update overview chart with PFCP ...................................................................... manual: update overview chart with PFCP Change from ascii art to the dotty chart, taken from the osmocom.org wiki. No need to keep a separate representation here. Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b --- M doc/manuals/chapters/overview.adoc 1 file changed, 64 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/76/29076/1 diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index aecb21a..65150d7 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -9,44 +9,82 @@ as a gateway between the classic 3G core network (CN) domain with its IuCS and IuPS interface and the femtocell based RAN. -A typical 3G network consisting of Osmocom components will look as illustrated in the following +A typical 3G network consisting of Osmocom components is illustrated in the following diagram: [[fig-3g]] .Typical 3G network architecture used with OsmoHNBGW +[graphviz] ---- - +------------+ +----------+ +---------+ +---------+ - UE <-->| hNodeB |<----Iuh----->| HNB-GW |<--IuCS-->| OsmoMSC |<--GSUP-->| OsmoHLR | - UE <-->| femto cell | | | | | | | - | | | | +---------+ +---------+ - | |<---IuUP--\ | | - | |<-------. | | | +---------+ +------+ - +------------+ | | | |<--IuPS-->| SGSN |<--GTP-C-->| GGSN | - | | +----------+ | | .------>| | - | | +---------+ | +------+ - | | +----------+ +---------+ | - | \-->| MGW |<--IuUP-->| MGW | | - | | (HNB-GW) | | (MSC) | | - | +----------+ +---------+ | - `--------------------GTP-U----------------' +digraph G { + rankdir = LR; + + UE [label="UE\n(3G phone)"] + PBX [label="PBX\nAsterisk, FreeSwitch,\nKamailio, Yate, ..."] + + subgraph cluster_msc_mgw { + style=dotted + MSC + MGW1 [label="MGW"] + MSC -> MGW1 [label="MGCP",constraint=false] + } + + subgraph cluster_hnbgw_mgw_upf { + style=dotted + MGW3 [label="MGW"] + UPF + HNBGW [label=HNBGW,style=bold] + HNBGW -> MGW3 [label="MGCP",constraint=false] + HNBGW -> UPF [label="PFCP",constraint=false] + } + + hNodeB [shape="box",label="hNodeB\n(3G femto cell)"] + + MSC -> HLR [label="\nGSUP",style=bold] + SGSN -> HLR [label="GSUP",style="dashed,bold"] + UE -> hNodeB [label="Uu",style=bold] + UE -> hNodeB [style="dashed,bold"] + hNodeB -> HNBGW [label="Iuh",style="bold"] + STP2 [label="STP\n(SCCP/M3UA)"] + HNBGW -> STP2 -> SGSN [label="IuPS",style="dashed,bold"] + HNBGW -> STP2 -> MSC [label="IuCS",style="bold"] + SGSN -> GGSN [label="GTP-C",style="dashed,bold"] + hNodeB -> UPF -> GGSN [label="GTP-U(3G)",style="dashed"] + GGSN -> internet [label="tun",style="dashed"] + + hNodeB -> MGW3 [label="IuUP/RTP",constraint=false] + MGW3 -> MGW1 [label="IuUP/RTP"] + + MSC -> SIPConnector [label="MNCC socket",style=bold] + + SIPConnector -> PBX [label="SIP",style=bold] + MGW1 -> PBX [label="RTP"] + + A, B, C, D [style="invisible"] + A -> B [label="data (PS)",style="dashed"] + C -> D [label="voice/SMS/USSD (CS)"] + +} ---- + The HNB-GW performs a translation interface between the IuCS/IuPS interfaces on the one hand side, and the Iuh interface on the or ther hand: ---- Iuh IuCS/IuPS - -NAS +----+----+ +----+----+ -Non-Access Stratum | CC | MM | | CC | MM | -- - - - - - - - - - - +----+----+-------+ +----+----+ - | RANAP | | H | RANAP | -Access Stratum +---------+ HNBAP | N +---------+ - - SCCP USER SAP - | RUA | | B | SUA | \ - +---------+-------+ - +---------+ | - | SCTP | G | SCTP | } SIGTRAN - +-----------------+ W +---------+ | - | IP | | IP | / + +----+----+ + | CC | MM | +NAS +----+----+ . . +----+----+ +Non-Access Stratum | CC | MM | . | RANAP | +- - - - - - - - - - - +----+----+-------+ +---------+ + | RANAP | | H | SCCP | +Access Stratum +---------+ HNBAP | N +---------+ + | RUA | | B | M3UA | + +---------+-------+ - +---------+ + | SCTP | G | SCTP | + +-----------------+ W +---------+ + | IP | | IP | +-----------------+ +---------+ ---- -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b Gerrit-Change-Number: 29076 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022