August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: ps_rab_fsm: check use cb success

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 ) Change subject: ps_rab_fsm: check use cb success ...................................................................... ps_rab_fsm: check use cb success Related: CID#275413 CID#275410 CID#275409 Related: SYS#5895 Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac --- M src/osmo-hnbgw/ps_rab_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/72/29072/1 diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c index 8578561..dcc18ca 100644 --- a/src/osmo-hnbgw/ps_rab_fsm.c +++ b/src/osmo-hnbgw/ps_rab_fsm.c @@ -106,7 +106,7 @@ }; fi->priv = rab; - osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1); + OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, 1) == 0); llist_add_tail(&rab->entry, &map->ps_rabs); return rab; @@ -139,7 +139,7 @@ m->ctx.session_fi = rab->fi; m->ctx.session_use_count = &rab->use_count; m->ctx.session_use_token = "PFCP_MSG"; - osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1); + OSMO_ASSERT(osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1) == 0); } static struct osmo_pfcp_msg *ps_rab_new_pfcp_msg_req(struct ps_rab *rab, enum osmo_pfcp_message_type msg_type) @@ -663,7 +663,7 @@ static void ps_rab_fsm_wait_use_count_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct ps_rab *rab = fi->priv; - osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1); + OSMO_ASSERT(osmo_use_count_get_put(&rab->use_count, PS_RAB_USE_ACTIVE, -1) == 0); } static void ps_rab_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac Gerrit-Change-Number: 29072 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp ...................................................................... osmo-hnbgw.cfg example: add pfcp Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 --- M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/73/29073/1 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index 53b5508..a39ea7b 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -28,4 +28,6 @@ mgw local-port 2729 mgw remote-port 2427 mgw reset-endpoint rtpbridge/* - + pfcp + # Remove the line below to disable GTP relay via UPF + remote-addr 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: OSMUX_Emulation: Add special error case for port events

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29069 ) Change subject: OSMUX_Emulation: Add special error case for port events ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I962bf4837a9e359576c42a51a9919891186c7100 Gerrit-Change-Number: 29069 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Aug 2022 21:50:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: OSMUX_Emulation: Use Misc_Helpers.f_shutdown() everywhere

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29068 ) Change subject: OSMUX_Emulation: Use Misc_Helpers.f_shutdown() everywhere ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id8f104a4123fcfbc96ab07f2e9343369946e3334 Gerrit-Change-Number: 29068 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Aug 2022 21:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)

by fixeria

Attention is currently required from: osmith, laforge. fixeria has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/28349 ) Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... update git URLs (git -> https; gitea/gerrit) Unencrypted git:// protocol offers no integrity or authentication, making it subject to tampering. Use https:// instead. https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-m… https://blog.readthedocs.com/github-git-protocol-deprecation/ Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b --- M README.adoc M ansible/roles/gsm-tester/tasks/main.yml M ansible/roles/osmocom-workstation/tasks/git-repos.yml M contrib/jenkins.sh M coverity/prepare_source_Osmocom.sh M jobs/coverity.yml M jobs/master-builds.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmo-gsm-manuals-trigger.yml M jobs/osmo-gsm-tester-builder.yml M jobs/osmo-gsm-tester-runner.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs.yml M jobs/osmocom-release-tarballs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-rebuild-upload-titan.yml M jobs/registry-triggers.yml M jobs/repo-install-test.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-osmo-ci-on-slaves.yml M qemu-kvm/ggsn-kernel-gtp/postinst.sh M scripts/osmo-build.sh M scripts/osmo-depcheck/config.py M scripts/osmo-depcheck/dependencies.py M scripts/osmo-deps.sh M scripts/osmo-layer1-headers.sh 29 files changed, 41 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/28349/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)

by fixeria

Attention is currently required from: osmith, laforge. fixeria has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/28349 ) Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... update git URLs (git -> https; gitea/gerrit) Unencrypted git:// protocol offers no integrity or authentication, making it subject to tampering. Use https:// instead. https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-m… https://blog.readthedocs.com/github-git-protocol-deprecation/ Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b --- M ansible/roles/gsm-tester/tasks/main.yml M ansible/roles/osmocom-workstation/tasks/git-repos.yml M contrib/jenkins.sh M coverity/prepare_source_Osmocom.sh M jobs/coverity.yml M jobs/master-builds.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmo-gsm-manuals-trigger.yml M jobs/osmo-gsm-tester-builder.yml M jobs/osmo-gsm-tester-runner.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-depcheck.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs.yml M jobs/osmocom-release-tarballs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-rebuild-upload-titan.yml M jobs/registry-triggers.yml M jobs/repo-install-test.yml M jobs/ttcn3-testsuites-kernel-git.yml M jobs/ttcn3-testsuites.yml M jobs/update-osmo-ci-on-slaves.yml M qemu-kvm/ggsn-kernel-gtp/postinst.sh M scripts/osmo-build.sh M scripts/osmo-depcheck/config.py M scripts/osmo-depcheck/dependencies.py M scripts/osmo-deps.sh M scripts/osmo-layer1-headers.sh 28 files changed, 39 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/28349/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28349 ) Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... Patch Set 3: (1 comment) File jobs/osmo-gsm-tester-runner.yml: https://gerrit.osmocom.org/c/osmo-ci/+/28349/comment/d26381f6_fe46a1bf PS3, Line 35: url: https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-tester > I also find this inconsistency weird and confusing. […] I might guess the idea is to use: * https://git.osmocom.org in scripts processing a list of projects, * Gerrit whenever possible, because it's the main repository, * Gitea for projects not present in Gerrit. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 12 Aug 2022 20:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: update git URLs (git -> https; gitea/gerrit)

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28349 ) Change subject: update git URLs (git -> https; gitea/gerrit) ...................................................................... Patch Set 3: (3 comments) File ansible/roles/osmocom-workstation/tasks/git-repos.yml: https://gerrit.osmocom.org/c/osmo-ci/+/28349/comment/1f3e682e_7e62646e PS3, Line 7: repo: https://git.osmocom.org/{{ item }}.git > Need to remove ".git" at the end: […] Done in the next patchset. File jobs/osmo-gsm-tester-runner.yml: https://gerrit.osmocom.org/c/osmo-ci/+/28349/comment/d98969b4_df37791c PS3, Line 35: url: https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-tester > it seems these are randomly used? […] I also find this inconsistency weird and confusing. Why not simply use https://git.osmocom.org everywhere? File scripts/osmo-depcheck/dependencies.py: https://gerrit.osmocom.org/c/osmo-ci/+/28349/comment/9cfd340b_51ed998e PS3, Line 17: httts > https Done in the next patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia44e4127ff87a3d4d747225d3258188a0a891f1b Gerrit-Change-Number: 28349 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 12 Aug 2022 20:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-netif[master]: osmux.h: Define default Osmux port

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29029 ) Change subject: osmux.h: Define default Osmux port ...................................................................... Patch Set 1: (1 comment) File include/osmocom/netif/osmux.h: https://gerrit.osmocom.org/c/libosmo-netif/+/29029/comment/31133b4b_c3bafa0f PS1, Line 16: #define OSMUX_DEFAULT_PORT 1984 > might make sense to add it to https://osmocom. […] https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29065 I also updated https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibfd058bceeeaa1384a00d8fcd6d6268b445e19bd Gerrit-Change-Number: 29029 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Aug 2022 19:11:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmo-gprs[master]: debian: clarify license/copyright for CSN.1 codec by ST-Ericsson

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29071 ) Change subject: debian: clarify license/copyright for CSN.1 codec by ST-Ericsson ...................................................................... debian: clarify license/copyright for CSN.1 codec by ST-Ericsson Change-Id: Ia76edccdfc14b06297fe7a306bc19ca52c7db3bd --- M debian/copyright 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/71/29071/1 diff --git a/debian/copyright b/debian/copyright index 670cede..718bd5a 100644 --- a/debian/copyright +++ b/debian/copyright @@ -5,6 +5,18 @@ Files: * Copyright: 2022 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> License: GPL-2.0+ + +Files: src/csn1/csn1.c + src/csn1/csn1_enc.c + src/csn1/csn1_dec.c + src/rlcmac/gprs_rlcmac.c + include/osmocom/csn1/csn1.h + include/osmocom/gprs/rlcmac/gprs_rlcmac.h +Copyright: 2011 Vincent Helfre + 2011 ST-Ericsson (Jari Sassi) +License: GPL-2.0+ + +License: GPL-2.0+ This program is free software; you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation; either version 3 of the License, or -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia76edccdfc14b06297fe7a306bc19ca52c7db3bd Gerrit-Change-Number: 29071 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022