July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: ignore symlinks (no newline at end of file)

by fixeria

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28503 to look at the new patch set (#2). Change subject: lint: ignore symlinks (no newline at end of file) ...................................................................... lint: ignore symlinks (no newline at end of file) Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/28503/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 Gerrit-Change-Number: 28503 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: lint: ignore symlinks (no newline at end of file)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28503 ) Change subject: lint: ignore symlinks (no newline at end of file) ...................................................................... lint: ignore symlinks (no newline at end of file) Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/28503/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 2194caa..e21ac21 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -10,6 +10,8 @@ echo '--exclude ^debian/changelog$' # Patch files echo '--exclude \.patch$' + # Symlinks (no newline at end of file) + find -type l -exec echo '--exclude ^{}$' \; } exclude_paths_common_asn1c() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 Gerrit-Change-Number: 28503 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: fix make {dist,distcheck} targets

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28501 ) Change subject: trxcon: Makefile.am: fix make {dist,distcheck} targets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I65f7c505f5a231bab114c45f5fdd7421601dfbc0 Gerrit-Change-Number: 28501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Jul 2022 17:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: move versioning magic to the bottom

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28500 ) Change subject: trxcon: Makefile.am: move versioning magic to the bottom ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: not sure there is a general rule/practice, but if you want to move it... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I69892f8689fd7062ca26b6f1337c972b11b1906e Gerrit-Change-Number: 28500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Jul 2022 17:54:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbsp_server: Exit process gracefully if binding socket fails

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28499 ) Change subject: cbsp_server: Exit process gracefully if binding socket fails ...................................................................... cbsp_server: Exit process gracefully if binding socket fails Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08 --- M src/cbsp_server.c 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/cbsp_server.c b/src/cbsp_server.c index b265b53..c6312dc 100644 --- a/src/cbsp_server.c +++ b/src/cbsp_server.c @@ -227,7 +227,11 @@ osmo_stream_srv_link_set_addr(cbc->link, bind_ip); osmo_stream_srv_link_set_accept_cb(cbc->link, cbsp_cbc_accept_cb); rc = osmo_stream_srv_link_open(cbc->link); - OSMO_ASSERT(rc == 0); + if (rc < 0) { + osmo_stream_srv_link_destroy(cbc->link); + talloc_free(cbc); + return NULL; + } LOGP(DCBSP, LOGL_NOTICE, "Listening for CBSP at %s\n", osmo_stream_srv_link_get_sockname(cbc->link)); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08 Gerrit-Change-Number: 28499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbsp_server: Exit process gracefully if binding socket fails

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28499 ) Change subject: cbsp_server: Exit process gracefully if binding socket fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08 Gerrit-Change-Number: 28499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Jul 2022 17:53:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: group header files into 'include/osmocom/bb/trxcon'

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28502 ) Change subject: trxcon: group header files into 'include/osmocom/bb/trxcon' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifa6137c239c215a3d323213ee74d34b419622be4 Gerrit-Change-Number: 28502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Jul 2022 15:16:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: fix make {dist,distcheck} targets

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28501 ) Change subject: trxcon: Makefile.am: fix make {dist,distcheck} targets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I65f7c505f5a231bab114c45f5fdd7421601dfbc0 Gerrit-Change-Number: 28501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Jul 2022 15:15:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Fix typos in error messages

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28497 ) Change subject: Fix typos in error messages ...................................................................... Fix typos in error messages Change-Id: I42b201127535ae9fc61adbdc37e1d23897fd81d8 --- M src/cbc_main.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/cbc_main.c b/src/cbc_main.c index 4b64c91..868a28e 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -246,13 +246,13 @@ } if (cbsp_cbc_create(tall_cbc_ctx) == NULL) { - perror("Error binidng CBSP port\n"); + perror("Error binding CBSP port\n"); exit(1); } rc = rest_api_init(tall_rest_ctx, g_cbc->config.ecbe.local_host, g_cbc->config.ecbe.local_port); if (rc < 0) { - perror("Error binidng ECBE port\n"); + perror("Error binding ECBE port\n"); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I42b201127535ae9fc61adbdc37e1d23897fd81d8 Gerrit-Change-Number: 28497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: main: remove newline char in perror() call

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28498 ) Change subject: main: remove newline char in perror() call ...................................................................... main: remove newline char in perror() call perror() appends ":" immediatelly afterwards in order to append the error string, so having a newline breaks the format. Change-Id: I14874c2c86495c83030fa40c7060706e9dfe1968 --- M src/cbc_main.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/cbc_main.c b/src/cbc_main.c index 868a28e..2ce5287 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -241,18 +241,18 @@ rc = telnet_init_dynif(tall_cbc_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_CBC); if (rc < 0) { - perror("Error binding VTY port\n"); + perror("Error binding VTY port"); exit(1); } if (cbsp_cbc_create(tall_cbc_ctx) == NULL) { - perror("Error binding CBSP port\n"); + perror("Error binding CBSP port"); exit(1); } rc = rest_api_init(tall_rest_ctx, g_cbc->config.ecbe.local_host, g_cbc->config.ecbe.local_port); if (rc < 0) { - perror("Error binding ECBE port\n"); + perror("Error binding ECBE port"); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I14874c2c86495c83030fa40c7060706e9dfe1968 Gerrit-Change-Number: 28498 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022