July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Fix typos in error messages

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28497 ) Change subject: Fix typos in error messages ...................................................................... Fix typos in error messages Change-Id: I42b201127535ae9fc61adbdc37e1d23897fd81d8 --- M src/cbc_main.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/97/28497/1 diff --git a/src/cbc_main.c b/src/cbc_main.c index 4b64c91..868a28e 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -246,13 +246,13 @@ } if (cbsp_cbc_create(tall_cbc_ctx) == NULL) { - perror("Error binidng CBSP port\n"); + perror("Error binding CBSP port\n"); exit(1); } rc = rest_api_init(tall_rest_ctx, g_cbc->config.ecbe.local_host, g_cbc->config.ecbe.local_port); if (rc < 0) { - perror("Error binidng ECBE port\n"); + perror("Error binding ECBE port\n"); exit(1); } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I42b201127535ae9fc61adbdc37e1d23897fd81d8 Gerrit-Change-Number: 28497 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-release-tarballs: move to dp

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28477 ) Change subject: jobs/osmocom-release-tarballs: move to dp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I15f6c08b807f1462f91e95b624cdc1aad0592dd6 Gerrit-Change-Number: 28477 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Jul 2022 15:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-release-tarballs: move to dp

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28477 ) Change subject: jobs/osmocom-release-tarballs: move to dp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I15f6c08b807f1462f91e95b624cdc1aad0592dd6 Gerrit-Change-Number: 28477 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Jul 2022 14:25:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' aft...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28487 ) Change subject: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases ...................................................................... jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases These two projects have been released recently as part of Osmocom CNI 202206. Let's enable testing them since version in latest is good enough for testing. Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8 --- M jobs/ttcn3-testsuites.yml 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index d4b4ec7..d3eba00 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -210,16 +210,19 @@ - ttcn3-stp-test-latest: blocking: "^(ttcn3|TTCN3-.*)-stp-test.*" timer: 30 09 * * * - #- ttcn3-sccp-test-latest: - # blocking: "^(ttcn3|TTCN3-.*)-sccp-test.*" - # timer: 00 10 * * * + - ttcn3-sccp-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-sccp-test.*" + timer: 00 10 * * * - ttcn3-smlc-test-latest: blocking: "^(ttcn3|TTCN3-.*)-smlc-test.*" timer: 10 10 * * * - # disabled until we have a stable release that supports IP-SNS in SGSN role - #- ttcn3-gbproxy-test-latest: - #blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" - #timer: 20 10 * * * + - ttcn3-gbproxy-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" + timer: 20 10 * * * + - ttcn3-gbproxy-test-fr-latest: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test-fr.*" + timer: 30 10 * * * + node: hdlc - ttcn3-cbc-test-latest: blocking: "^(ttcn3|TTCN3-.*)-cbc-test.*" timer: 40 10 * * * @@ -229,7 +232,6 @@ - ttcn3-hnodeb-test-latest: blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*" timer: 40 12 * * * - disabled: true - ttcn3-upf-test-latest: blocking: "^(ttcn3|TTCN3-.*)-upf-test.*" timer: 00 13 * * * @@ -237,8 +239,6 @@ - ttcn3-hnbgw-test-latest: blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*" timer: 40 13 * * * - disabled: true - # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs @@ -344,12 +344,12 @@ - TTCN3-centos-smlc-test-latest: blocking: "^(ttcn3|TTCN3-.*)-smlc-test.*" timer: 10 10 * * * - #- TTCN3-centos-sccp-test-latest: - # blocking: "^(ttcn3|TTCN3-.*)-sccp-test.*" - # timer: 00 10 * * * - #- TTCN3-centos-gbproxy-test-latest: - #blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" - #timer: 20 10 * * * + - TTCN3-centos-sccp-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-sccp-test.*" + timer: 00 10 * * * + - TTCN3-centos-gbproxy-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" + timer: 20 10 * * * - TTCN3-centos-cbc-test-latest: blocking: "^(ttcn3|TTCN3-.*)-cbc-test.*" timer: 40 10 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8 Gerrit-Change-Number: 28487 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' aft...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28487 ) Change subject: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8 Gerrit-Change-Number: 28487 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Jul 2022 14:24:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Remove impossible code path

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28482 ) Change subject: mgcp-client: Remove impossible code path ...................................................................... mgcp-client: Remove impossible code path read(4096 - 128) cannot return > 4096 - 128. Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 3711f24..77de23f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -726,10 +726,6 @@ msgb_free(msg); return -1; - } else if (ret > 4096 - 128) { - LOGPMGW(mgcp, LOGL_ERROR, "Too much data: %s: %d\n", osmo_sock_get_name2(fd->fd), ret); - msgb_free(msg); - return -1; } msg->l2h = msgb_put(msg, ret); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 Gerrit-Change-Number: 28482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Remove impossible code path

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28482 ) Change subject: mgcp-client: Remove impossible code path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I352c3b28c8de6482277cb84cd0f51893494dc929 Gerrit-Change-Number: 28482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Jul 2022 14:23:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmo-sccp[master]: xua_snm: assert to guard against NULL ptr

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 ) Change subject: xua_snm: assert to guard against NULL ptr ...................................................................... xua_snm: assert to guard against NULL ptr This is similarly done for same IE in other functions, so let's do it here too in order to make coverity happy, and avoid random access ptr probably ending up in obscure crash. Fixes: Coverity CID#272994 Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 --- M src/xua_snm.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/xua_snm.c b/src/xua_snm.c index 1212162..c7d0d2e 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -464,6 +464,8 @@ const uint32_t *cong_level = xua_msg_get_u32p(xua, M3UA_IEI_CONG_IND, &_cong_level); int log_ss = osmo_ss7_asp_get_log_subsys(asp); + OSMO_ASSERT(ie_aff_pc); + LOGPASP(asp, log_ss, LOGL_NOTICE, "RX SCON(%s) for %s level=%u\n", info_str ? info_str : "", format_affected_pcs_c(xua, asp->inst, ie_aff_pc), cong_level ? *cong_level : 0); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 Gerrit-Change-Number: 28481 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmo-sccp[master]: xua_snm: assert to guard against NULL ptr

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 ) Change subject: xua_snm: assert to guard against NULL ptr ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: note that we can only do this here because we have previous codee which will reject (gracefully, at protocol level) if messages without mandatory IEs are received. Otherwise we of course don't want to ASSERT in case of a missing IE. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 Gerrit-Change-Number: 28481 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Jul 2022 14:23:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: cbsp: avoid potential msgb write overflow in osmo_cbsp_recv_buffered

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28478 ) Change subject: cbsp: avoid potential msgb write overflow in osmo_cbsp_recv_buffered ...................................................................... cbsp: avoid potential msgb write overflow in osmo_cbsp_recv_buffered >>> CID 273001: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted expression "needed" to "recv", which uses it as an offset. 1444 rc = recv(fd, msg->tail, needed, 0); Fixes: Coverity CID#273001 Change-Id: I17c558254f9c7907b56d61c53c2f597e8e4566cf --- M src/gsm/cbsp.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 2095003..a31517b 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -1441,6 +1441,10 @@ needed = len - msgb_l2len(msg); if (needed > 0) { + if (needed > msgb_tailroom(msg)) { + rc = -ENOMEM; + goto discard_msg; + } rc = recv(fd, msg->tail, needed, 0); if (rc == 0) goto discard_msg; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17c558254f9c7907b56d61c53c2f597e8e4566cf Gerrit-Change-Number: 28478 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022