July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: simplify find command in exclude_paths_common_asn1c()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28504 ) Change subject: lint: simplify find command in exclude_paths_common_asn1c() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Nice, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iae3fc5c8842df6926e6ff16a41be5663f1dedd1b Gerrit-Change-Number: 28504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: lint: ignore symlinks (no newline at end of file)

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28503 ) Change subject: lint: ignore symlinks (no newline at end of file) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 Gerrit-Change-Number: 28503 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-msc[master]: Change CC_CAUSE returned on unanswered MT Call

by keith

Attention is currently required from: neels, laforge, pespin, fixeria, dexter. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28509 ) Change subject: Change CC_CAUSE returned on unanswered MT Call ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > If I understand you / the situation correctly, then: […] I could not find any configurable timeout for MT not responding. That can be configured at the freeswitch PBX of course, so one could set timer mgw X2 60 and then have the switch allow ringing for 45 seconds or some such. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4a9cfc388ec9ecb743d154a114a6db638eac4701 Gerrit-Change-Number: 28509 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 03 Jul 2022 18:53:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: don't do check for all"

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28510 ) Change subject: Revert "coverity/build_Osmocom.sh: don't do check for all" ...................................................................... Revert "coverity/build_Osmocom.sh: don't do check for all" This reverts commit ae41942214ef43bbb6aeb257bad2985765035ad7. Change-Id: I5018e0da020f32e3a46a2772e79794e5a3a686ca --- M coverity/build_Osmocom.sh 1 file changed, 3 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/28510/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index ec764be..fe9806c 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -5,7 +5,6 @@ base_dir="$PWD" src_dir="$base_dir/source-Osmocom" prefix="$base_dir/install-Osmocom" -check="check" install -d "$prefix" @@ -19,16 +18,10 @@ --disable-doxygen \ $* - make $PARALLEL_MAKE $check + make $PARALLEL_MAKE check make install } -do_build_no_check() { - check="" - do_build "$@" - check="check" -} - build_default() { pushd $1 shift @@ -36,13 +29,6 @@ popd } -build_no_check() { - pushd $1 - shift - do_build_no_check $* - popd -} - build_layer1api() { pushd layer1-api install -d "$prefix/include/sysmocom/femtobts/" @@ -83,10 +69,10 @@ rm -rf "$prefix" build_layer1api -build_no_check asn1c +build_default asn1c build_default libosmocore build_libasn1c -build_no_check libusrp +build_libusrp build_default libosmo-abis build_default libosmo-netif build_default libosmo-sccp -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5018e0da020f32e3a46a2772e79794e5a3a686ca Gerrit-Change-Number: 28510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()"

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28511 ) Change subject: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()" ...................................................................... Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()" This reverts commit bf84ba9f69a0a2125bfd4327519b0e6fa212d664. Change-Id: I722f8cbb1934a4f5ce2969e243f223019f123777 --- M coverity/build_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/11/28511/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index fe9806c..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -18,7 +18,7 @@ --disable-doxygen \ $* - make $PARALLEL_MAKE check + make $PARALLEL_MAKE make install } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I722f8cbb1934a4f5ce2969e243f223019f123777 Gerrit-Change-Number: 28511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28512 ) Change subject: coverity: compile tests, but not execute them ...................................................................... coverity: compile tests, but not execute them Compiling unit tests would allow Coverity to analyze them too and thus find more bugs. The problem is that binaries listed in check_PROGRAMS are not compiled during 'make all', but only during 'make check'. One approach [1] is to run 'make check' in do_build(), however it breaks 'Coverity-Upload' job because some unit tests are failing. This is why I had to revert bf84ba9f69a0a2125bfd4327519b0e6fa212d664 together with ae41942214ef43bbb6aeb257bad2985765035ad7 that was supposed to fix it. Even if all unit tests were passing, we still don't want to execute them because running tests is beyond the scope of 'Coverity-Upload' job. Another approach is to patch Makefile.am files replacing check_PROGRAMS with noinst_PROGRAMS, so that the test binaries are compiled during 'make all' but not executed. Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Related: [1] I3f3149a61df96646798c72d0ad31c41b97e6b81f --- M coverity/prepare_source_Osmocom.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/28512/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 452af3e..e63436b 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -47,6 +47,13 @@ else git clone git://git.osmocom.org/$proj fi + + # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' + # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. + files="$(git -C $proj grep -l check_PROGRAMS)" + if [ ! -z "$files" ]; then + sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files + fi done if ! [ -d layer1-api ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 03 Jul 2022 09:07:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm48_ie: fix parsing of Bearer capability IE without octet 3a

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28508 ) Change subject: gsm48_ie: fix parsing of Bearer capability IE without octet 3a ...................................................................... gsm48_ie: fix parsing of Bearer capability IE without octet 3a The testcase in gsm0408_test is still failing because the encoder produces a different result (with octet 3a present). There is no way to tell the encoder to use the implicit coding, and in general this is not that critical, so we can live with that. Change-Id: I722c168f01bffa915cb155eac234a796549d3762 --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.err 2 files changed, 20 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 4fa4924..bbaec3d 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -203,6 +203,23 @@ case GSM_MNCC_BCAP_SPEECH: i = 1; s = 0; + if ((lv[1] & 0x80) != 0) { /* octet 3a is absent */ + switch (bcap->radio) { + case GSM48_BCAP_RRQ_FR_ONLY: + bcap->speech_ver[s++] = GSM48_BCAP_SV_FR; + break; + case GSM48_BCAP_RRQ_DUAL_HR: + bcap->speech_ver[s++] = GSM48_BCAP_SV_HR; + bcap->speech_ver[s++] = GSM48_BCAP_SV_FR; + break; + case GSM48_BCAP_RRQ_DUAL_FR: + bcap->speech_ver[s++] = GSM48_BCAP_SV_FR; + bcap->speech_ver[s++] = GSM48_BCAP_SV_HR; + break; + } + bcap->speech_ver[s] = -1; /* end of list */ + return 0; + } while (!(lv[i] & 0x80)) { i++; /* octet 3a etc */ if (in_len < i) diff --git a/tests/gsm0408/gsm0408_test.err b/tests/gsm0408/gsm0408_test.err index 1f0236c..8aeda3e 100644 --- a/tests/gsm0408/gsm0408_test.err +++ b/tests/gsm0408/gsm0408_test.err @@ -1,3 +1,3 @@ -Incorrect decoded result of Speech, without octet 3a: - should: 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 - is: 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +Incorrect encoded result of Speech, without octet 3a: + should: 01 a0 + is: 02 20 80 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I722c168f01bffa915cb155eac234a796549d3762 Gerrit-Change-Number: 28508 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm48_ie: fix parsing of Bearer capability IE without octet 3a

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28508 ) Change subject: gsm48_ie: fix parsing of Bearer capability IE without octet 3a ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I722c168f01bffa915cb155eac234a796549d3762 Gerrit-Change-Number: 28508 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 03 Jul 2022 09:06:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmocore[master]: gsm48_ie: fix coding style: while is not a function

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28507 ) Change subject: gsm48_ie: fix coding style: while is not a function ...................................................................... gsm48_ie: fix coding style: while is not a function Change-Id: Id28bf61c5e1dfb6da1c89a5502eb869b67fed6c6 --- M src/gsm/gsm48_ie.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 6d40bec..4fa4924 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -203,7 +203,7 @@ case GSM_MNCC_BCAP_SPEECH: i = 1; s = 0; - while(!(lv[i] & 0x80)) { + while (!(lv[i] & 0x80)) { i++; /* octet 3a etc */ if (in_len < i) return 0; @@ -218,7 +218,7 @@ case GSM_MNCC_BCAP_UNR_DIG: case GSM_MNCC_BCAP_FAX_G3: i = 1; - while(!(lv[i] & 0x80)) { + while (!(lv[i] & 0x80)) { i++; /* octet 3a etc */ if (in_len < i) return 0; @@ -232,7 +232,7 @@ return 0; bcap->data.rate_adaption = (lv[i] >> 3) & 3; bcap->data.sig_access = lv[i] & 7; - while(!(lv[i] & 0x80)) { + while (!(lv[i] & 0x80)) { i++; /* octet 5a etc */ if (in_len < i) return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id28bf61c5e1dfb6da1c89a5502eb869b67fed6c6 Gerrit-Change-Number: 28507 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022