June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh reso...

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 to look at the new patch set (#2). Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd ...................................................................... nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd Fixes: Coverity CID#272987 Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 --- M src/nacc_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/85/28485/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168 Gerrit-Change-Number: 28485 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Avoid string not null terminated access

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 ) Change subject: mgcp-client: Avoid string not null terminated access ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685 Gerrit-Change-Number: 28483 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

3 years

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Avoid string not null terminated access

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 ) Change subject: mgcp-client: Avoid string not null terminated access ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/ac8acadf_02d28504 PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */ > mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls mgcp_msg_terminate_nul(). […] Good point, I didn't see that, and coverity neither. Abandoning the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685 Gerrit-Change-Number: 28483 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 06:55:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years

1
0
0 0

Change in libosmocore[master]: iuup: Explicitly mark default case as unexpected with assert

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 ) Change subject: iuup: Explicitly mark default case as unexpected with assert ...................................................................... iuup: Explicitly mark default case as unexpected with assert That code path should not happen since this function is only called for data frames coming with IUUP_FSM_EVT_IUUP_DATA_IND. Control frames should come with specific events like IUUP_FSM_EVT_IUUP_CONFIG_REQ. Hence, let's add an assert to make sure we early exit if that ever happens (it shouldn't), instead of carrying on reading uninitialized var "dt". Fixes: Coverity CID#272996 Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d --- M src/gsm/iuup.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index ca7eb2b..c6a575e 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -476,6 +476,8 @@ dt.frame_nr = h1->frame_nr; dt.fqc = h1->fqc; break; + default: + OSMO_ASSERT(0); } /* pull up to the IuUP payload and push a new primitive header in front */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d Gerrit-Change-Number: 28480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/6fcac618_d82eb223 PS1, Line 9: Make coverity happy > Coverity could be made happy by marking CID#273000 as "False positive". […] It still makes more sense to do it this way from procedural/logical point of view, so I don't see why it shouldn't be merged. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jun 2022 06:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-hnbgw[master]: hnbgw_cn.c: Guard against null ss7 ptr during init

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28484 ) Change subject: hnbgw_cn.c: Guard against null ss7 ptr during init ...................................................................... hnbgw_cn.c: Guard against null ss7 ptr during init Fixes: Coverity CID#272989 Change-Id: Ic787d52a3c2e73ac272735a33b20bb94e29fad95 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 5499e5d..7c1dc9d 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -541,6 +541,8 @@ LOGP(DRANAP, LOGL_NOTICE, "No cs7 instance configured for IuCS nor IuPS," " creating default instance\n"); ss7 = osmo_ss7_instance_find_or_create(gw, 0); + if (!ss7) + return -1; ss7->cfg.primary_pc = (23 << 3) + 5; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic787d52a3c2e73ac272735a33b20bb94e29fad95 Gerrit-Change-Number: 28484 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/46085819_1dbae3d6 PS1, Line 9: Make coverity happy Coverity could be made happy by marking CID#273000 as "False positive". I don't think it makes sense to merge this patch, because AFAICS it does not really change the logic nor fix anything. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 22:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in libosmocore[master]: iuup: Explicitly mark default case as unexpected with assert

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 ) Change subject: iuup: Explicitly mark default case as unexpected with assert ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d Gerrit-Change-Number: 28480 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 22:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in libosmo-sccp[master]: xua_snm: assert to guard against NULL ptr

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 ) Change subject: xua_snm: assert to guard against NULL ptr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0 Gerrit-Change-Number: 28481 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 22:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Avoid string not null terminated access

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 ) Change subject: mgcp-client: Avoid string not null terminated access ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/15c4b51a_190325bb PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */ mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls mgcp_msg_terminate_nul(). Are you sure adding '\0' is really needed here? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685 Gerrit-Change-Number: 28483 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jun 2022 22:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022