osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28491 )
Change subject: coverity/prepare_source: clean existing git dirs
......................................................................
coverity/prepare_source: clean existing git dirs
Clean git dirs if they exist already instead of fetching and reset to
master. It is faster and more useful during development. Jenkins doesn't
run this code path, it deletes all source directories before running
this script.
Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca
---
M coverity/prepare_source_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/28491/1
diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh
index 09608eb..d017989 100755
--- a/coverity/prepare_source_Osmocom.sh
+++ b/coverity/prepare_source_Osmocom.sh
@@ -38,7 +38,7 @@
; do
if [ -d $proj ]; then
- (cd $proj && git fetch && git checkout -f -B master origin/master)
+ git -C "$proj" clean -ffxd
else
git clone git://git.osmocom.org/$proj
fi
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28491
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id6d3cdabb776435df36c0145d93e514693062fca
Gerrit-Change-Number: 28491
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28492 )
Change subject: coverity/local_test.sh: new file
......................................................................
coverity/local_test.sh: new file
Add the script I've used to locally reproduce the build failure and fix
it.
Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70
---
M coverity/jenkins.sh
A coverity/local_test.sh
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/28492/1
diff --git a/coverity/jenkins.sh b/coverity/jenkins.sh
index 0ae7fd7..b02b82e 100755
--- a/coverity/jenkins.sh
+++ b/coverity/jenkins.sh
@@ -1,4 +1,5 @@
#!/usr/bin/env bash
+# Use 'local_test.sh' during development
set -e -x
diff --git a/coverity/local_test.sh b/coverity/local_test.sh
new file mode 100755
index 0000000..10b4583
--- /dev/null
+++ b/coverity/local_test.sh
@@ -0,0 +1,11 @@
+#!/bin/sh -ex
+# Use this script for local testing of the prepare source and build scripts
+SCRIPT_DIR="$(dirname "$(realpath "$0")")"
+
+mkdir -p /tmp/coverity
+cp "$SCRIPT_DIR"/* /tmp/coverity
+
+cd /tmp/coverity
+
+./prepare_source_Osmocom.sh
+./build_Osmocom.sh
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28492
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I12241499a0669559bc40eb3e76f967a7c6a2dc70
Gerrit-Change-Number: 28492
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28489 )
Change subject: coverity/build_Osmocom.sh: don't do check for all
......................................................................
coverity/build_Osmocom.sh: don't do check for all
'make check' does not pass for asn1c, it fails with the following. I
looked into it and the cause is not obvious to me, so in order to make
the jenkins job pass again I've changed it back to just run 'make'
instead.
Fix for:
...
fatal: making test-suite.log: failed to create ../tests/98-attribute-class-OK.asn1.log
fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.trs
fatal: making test-suite.log: failed to create ../tests/99-class-sample-OK.asn1.log
Makefile:735: recipe for target 'test-suite.log' failed
make[3]: *** [test-suite.log] Error 1
make[3]: Leaving directory '/home/osmocom-build/osmo-ci/coverity/source-Osmocom/asn1c/libasn1fix'
Makefile:841: recipe for target 'check-TESTS' failed
Disable 'make check' for libusrp too as it also didn't pass:
Making check in usrp2
make[4]: Entering directory '/tmp/coverity/source-Osmocom/libusrp/firmware/src/usrp2'
test -f `basename 'eeprom_boot.a51'` || ln -s 'eeprom_boot.a51' .
test -f ../common/`basename 'eeprom_boot.a51'` -o \
\! -f `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` \
|| ln -s `dirname 'eeprom_boot.a51'`/../common/`basename 'eeprom_boot.a51'` ../common/`basename 'eeprom_boot.a51'`
sdas8051 -plosgff `basename 'eeprom_boot.a51'`
sdcc -mmcs51 --no-xinit-opt -I../../../firmware/include -I../../../firmware/src/usrp2 -I../../../firmware/src/common -I../../../firmware/src/common -DHAVE_USRP2 \
-c -o eeprom_init.rel `test -f 'eeprom_init.c' || echo './'`eeprom_init.c
test -f `basename '_startup.a51'` || ln -s '_startup.a51' .
test -f ../common/`basename '_startup.a51'` -o \
\! -f `dirname '_startup.a51'`/../common/`basename '_startup.a51'` \
|| ln -s `dirname '_startup.a51'`/../common/`basename '_startup.a51'` ../common/`basename '_startup.a51'`
sdas8051 -plosgff `basename '_startup.a51'`
make[4]: *** No rule to make target '../../lib/libfx2.lib', needed by 'eeprom_boot.ihx'. Stop.
All other 'make check' calls do work as expected, the build script runs
through again with this patch.
Fixes: bf84ba9f ("coverity/build_Osmocom.sh: run 'make check' in do_build()")
Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270
---
M coverity/build_Osmocom.sh
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/28489/1
diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh
index fe9806c..ec764be 100755
--- a/coverity/build_Osmocom.sh
+++ b/coverity/build_Osmocom.sh
@@ -5,6 +5,7 @@
base_dir="$PWD"
src_dir="$base_dir/source-Osmocom"
prefix="$base_dir/install-Osmocom"
+check="check"
install -d "$prefix"
@@ -18,10 +19,16 @@
--disable-doxygen \
$*
- make $PARALLEL_MAKE check
+ make $PARALLEL_MAKE $check
make install
}
+do_build_no_check() {
+ check=""
+ do_build "$@"
+ check="check"
+}
+
build_default() {
pushd $1
shift
@@ -29,6 +36,13 @@
popd
}
+build_no_check() {
+ pushd $1
+ shift
+ do_build_no_check $*
+ popd
+}
+
build_layer1api() {
pushd layer1-api
install -d "$prefix/include/sysmocom/femtobts/"
@@ -69,10 +83,10 @@
rm -rf "$prefix"
build_layer1api
-build_default asn1c
+build_no_check asn1c
build_default libosmocore
build_libasn1c
-build_libusrp
+build_no_check libusrp
build_default libosmo-abis
build_default libosmo-netif
build_default libosmo-sccp
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6b9eb8e73c51d925897579fb51bc0a1e86e77270
Gerrit-Change-Number: 28489
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28490 )
Change subject: coverity/prepare_source: fix running twice
......................................................................
coverity/prepare_source: fix running twice
Don't attempt to clone layer1-api if it exists already. Jenkins deletes
the sources for every run, but for development it is useful to be able
to run this script multiple times without getting errors.
Change-Id: I17bd76a5ff6abafd4bd0189073930f45de20afe8
---
M coverity/prepare_source_Osmocom.sh
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/28490/1
diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh
index ab8b2bd..09608eb 100755
--- a/coverity/prepare_source_Osmocom.sh
+++ b/coverity/prepare_source_Osmocom.sh
@@ -44,4 +44,6 @@
fi
done
-git clone https://git.sysmocom.de/sysmo-bts/layer1-api
+if ! [ -d layer1-api ]; then
+ git clone https://git.sysmocom.de/sysmo-bts/layer1-api
+fi
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28490
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I17bd76a5ff6abafd4bd0189073930f45de20afe8
Gerrit-Change-Number: 28490
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/28487
to look at the new patch set (#2).
Change subject: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases
......................................................................
jobs: ttcn3-testsuites: Enable hnodeb,hnbgw,sccp,gbproxy 'latest' after new project releases
These two projects have been released recently as part of Osmocom CNI
202206. Let's enable testing them since version in latest is good enough
for testing.
Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8
---
M jobs/ttcn3-testsuites.yml
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/28487/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8
Gerrit-Change-Number: 28487
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28487 )
Change subject: jobs: ttcn3-testsuites: Enable hnodeb,hnbgw 'latest' after new project releases
......................................................................
jobs: ttcn3-testsuites: Enable hnodeb,hnbgw 'latest' after new project releases
These two projects have been released recently as part of Osmocom CNI
202206. Let's enable testing them since version in latest is good enough
for testing.
Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8
---
M jobs/ttcn3-testsuites.yml
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/28487/1
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index d4b4ec7..1110403 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -229,7 +229,6 @@
- ttcn3-hnodeb-test-latest:
blocking: "^(ttcn3|TTCN3-.*)-hnodeb-test.*"
timer: 40 12 * * *
- disabled: true
- ttcn3-upf-test-latest:
blocking: "^(ttcn3|TTCN3-.*)-upf-test.*"
timer: 00 13 * * *
@@ -237,8 +236,6 @@
- ttcn3-hnbgw-test-latest:
blocking: "^(ttcn3|TTCN3-.*)-hnbgw-test.*"
timer: 40 13 * * *
- disabled: true
-
# Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1587e8400eff2d8b1ec26ab2fff1fbfa772fe8f8
Gerrit-Change-Number: 28487
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28486 )
Change subject: tlv_parser: initialize output values
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I am not sure if this make sense at all, what I am trying to fix here is:
*** CID 273004: (TAINTED_SCALAR)
/source-Osmocom/osmo-bsc-nat/src/osmo-bsc-nat/bssap_conn.c: 56 in bssmap_replace_ie_aoip_transp_addr()
50 return rv;
51 }
52
53 if (tag == GSM0808_IE_AOIP_TRASP_ADDR)
54 rc = gsm0808_enc_aoip_trasp_addr(msg_new, ss);
55 else
>>> CID 273004: (TAINTED_SCALAR)
>>> Passing tainted expression "len" to "tlv_encode_one", which uses it as an offset.
56 rc = tlv_encode_one(msg_new, def->def[tag].type, tag, len, val);
57
58 if (rc < 0) {
59 LOGP(DMAIN, LOGL_ERROR, "Failed to encode tag %d into copy of bssmap msg\n", tag);
60 msgb_free(msg_new);
61 return rc;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I87570ece10fbf64f3a57b34d84f8c843871f0db1
Gerrit-Change-Number: 28486
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 30 Jun 2022 08:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28486 )
Change subject: tlv_parser: initialize output values
......................................................................
tlv_parser: initialize output values
When the function tlv_parse_one exits early, the output parameters may
not be initialized. This is no problem since the return code will inform
the caller that the parsing of the TLV IE failed. However, coverity
seems to report a TAINTED_SCALAR problem anyway.
Change-Id: I87570ece10fbf64f3a57b34d84f8c843871f0db1
Related: CID#273004
---
M src/gsm/tlv_parser.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/28486/1
diff --git a/src/gsm/tlv_parser.c b/src/gsm/tlv_parser.c
index c5aac97..069f1a0 100644
--- a/src/gsm/tlv_parser.c
+++ b/src/gsm/tlv_parser.c
@@ -234,6 +234,12 @@
uint8_t tag;
int len; /* number of bytes consumed by TLV entry */
+ /* Make output variables are initialized
+ * (fixes CID 273004, false positive) */
+ *o_tag = 0x00;
+ *o_len = 0;
+ *o_val = NULL;
+
if (buf_len < 1)
return OSMO_TLVP_ERR_OFS_BEYOND_BUFFER;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28486
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I87570ece10fbf64f3a57b34d84f8c843871f0db1
Gerrit-Change-Number: 28486
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
