Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 )
Change subject: mgcp-client: Avoid string not null terminated access
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/ac8acadf_02d28504
PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */
> mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls mgcp_msg_terminate_nul(). […]
Good point, I didn't see that, and coverity neither. Abandoning the patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685
Gerrit-Change-Number: 28483
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jun 2022 06:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 )
Change subject: iuup: Explicitly mark default case as unexpected with assert
......................................................................
iuup: Explicitly mark default case as unexpected with assert
That code path should not happen since this function is only called for
data frames coming with IUUP_FSM_EVT_IUUP_DATA_IND.
Control frames should come with specific events like
IUUP_FSM_EVT_IUUP_CONFIG_REQ.
Hence, let's add an assert to make sure we early exit if that ever
happens (it shouldn't), instead of carrying on reading uninitialized var
"dt".
Fixes: Coverity CID#272996
Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d
---
M src/gsm/iuup.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c
index ca7eb2b..c6a575e 100644
--- a/src/gsm/iuup.c
+++ b/src/gsm/iuup.c
@@ -476,6 +476,8 @@
dt.frame_nr = h1->frame_nr;
dt.fqc = h1->fqc;
break;
+ default:
+ OSMO_ASSERT(0);
}
/* pull up to the IuUP payload and push a new primitive header in front */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d
Gerrit-Change-Number: 28480
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 )
Change subject: rtp: Delay rtph ptr assign after validating length
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/6fcac618_d82eb223
PS1, Line 9: Make coverity happy
> Coverity could be made happy by marking CID#273000 as "False positive". […]
It still makes more sense to do it this way from procedural/logical point of view, so I don't see why it shouldn't be merged.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d
Gerrit-Change-Number: 28479
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jun 2022 06:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 )
Change subject: rtp: Delay rtph ptr assign after validating length
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/46085819_1dbae3d6
PS1, Line 9: Make coverity happy
Coverity could be made happy by marking CID#273000 as "False positive". I don't think it makes sense to merge this patch, because AFAICS it does not really change the logic nor fix anything.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d
Gerrit-Change-Number: 28479
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 22:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 )
Change subject: iuup: Explicitly mark default case as unexpected with assert
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d
Gerrit-Change-Number: 28480
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 22:44:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 )
Change subject: xua_snm: assert to guard against NULL ptr
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0
Gerrit-Change-Number: 28481
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 22:44:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483 )
Change subject: mgcp-client: Avoid string not null terminated access
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/15c4b51a_190325bb
PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */
mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls mgcp_msg_terminate_nul(). Are you sure adding '\0' is really needed here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685
Gerrit-Change-Number: 28483
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 22:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 )
Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure about this one is the proper way to check for 3digit. […]
There can be 3-digit MNCs starting with 0. MNC=099 is *not* equal to MNC=99, so I think using strlen() here is better, because "cgi_ps.rai.lac.plmn.mnc > 99" does not distinguish between MNC=099 and MNC=99.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168
Gerrit-Change-Number: 28485
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 17:07:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28485 )
Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I'm not sure about this one is the proper way to check for 3digit. Should I instead check with "strlen(tok) > 2"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28485
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168
Gerrit-Change-Number: 28485
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 16:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/28481 )
Change subject: xua_snm: assert to guard against NULL ptr
......................................................................
xua_snm: assert to guard against NULL ptr
This is similarly done for same IE in other functions, so let's do it
here too in order to make coverity happy, and avoid random access ptr
probably ending up in obscure crash.
Fixes: Coverity CID#272994
Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0
---
M src/xua_snm.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/81/28481/1
diff --git a/src/xua_snm.c b/src/xua_snm.c
index 1212162..c7d0d2e 100644
--- a/src/xua_snm.c
+++ b/src/xua_snm.c
@@ -464,6 +464,8 @@
const uint32_t *cong_level = xua_msg_get_u32p(xua, M3UA_IEI_CONG_IND, &_cong_level);
int log_ss = osmo_ss7_asp_get_log_subsys(asp);
+ OSMO_ASSERT(ie_aff_pc);
+
LOGPASP(asp, log_ss, LOGL_NOTICE, "RX SCON(%s) for %s level=%u\n", info_str ? info_str : "",
format_affected_pcs_c(xua, asp->inst, ie_aff_pc), cong_level ? *cong_level : 0);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/28481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I72059ffaa608bb4f5c4bd274645878e0b31ed6e0
Gerrit-Change-Number: 28481
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28480 )
Change subject: iuup: Explicitly mark default case as unexpected with assert
......................................................................
iuup: Explicitly mark default case as unexpected with assert
That code path should not happen since this function is only called for
data frames coming with IUUP_FSM_EVT_IUUP_DATA_IND.
Control frames should come with specific events like
IUUP_FSM_EVT_IUUP_CONFIG_REQ.
Hence, let's add an assert to make sure we early exit if that ever
happens (it shouldn't), instead of carrying on reading uninitialized var
"dt".
Fixes: Coverity CID#272996
Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d
---
M src/gsm/iuup.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/28480/1
diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c
index ca7eb2b..c6a575e 100644
--- a/src/gsm/iuup.c
+++ b/src/gsm/iuup.c
@@ -476,6 +476,8 @@
dt.frame_nr = h1->frame_nr;
dt.fqc = h1->fqc;
break;
+ default:
+ OSMO_ASSERT(0);
}
/* pull up to the IuUP payload and push a new primitive header in front */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iaeba59bc9ebfe817dbb7528572dc669c010ef14d
Gerrit-Change-Number: 28480
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28429 )
Change subject: cbsp: Change log level ERROR->INFO on CBSP tx and link down
......................................................................
cbsp: Change log level ERROR->INFO on CBSP tx and link down
Let's decrease the logging since it's fine simply discarding the message
if the link is down. This way all code sending messages doesn't need to
care about the link state.
Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc
---
M src/osmo-bsc/cbsp_link.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c
index d8c32ec..849b802 100644
--- a/src/osmo-bsc/cbsp_link.c
+++ b/src/osmo-bsc/cbsp_link.c
@@ -301,7 +301,7 @@
struct msgb *msg;
if (!cbc->client.cli && !cbc->server.srv) {
- LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n",
+ LOGP(DCBS, LOGL_INFO, "Discarding Tx CBSP Message Type %s, link is down\n",
get_value_string(cbsp_msg_type_names, cbsp->msg_type));
talloc_free(cbsp);
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc
Gerrit-Change-Number: 28429
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28451 )
Change subject: coverity/build_Osmocom.sh: run 'make check' in do_build()
......................................................................
coverity/build_Osmocom.sh: run 'make check' in do_build()
This enables building and running tests (check_PROGRAMS), so that
Coverity will be able to find bugs in their code too.
Change-Id: I3f3149a61df96646798c72d0ad31c41b97e6b81f
---
M coverity/build_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh
index a7f8cdd..fe9806c 100755
--- a/coverity/build_Osmocom.sh
+++ b/coverity/build_Osmocom.sh
@@ -18,7 +18,7 @@
--disable-doxygen \
$*
- make $PARALLEL_MAKE
+ make $PARALLEL_MAKE check
make install
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28451
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I3f3149a61df96646798c72d0ad31c41b97e6b81f
Gerrit-Change-Number: 28451
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28461 )
Change subject: release-tarball-build-dist: upgrade from debian 9
......................................................................
release-tarball-build-dist: upgrade from debian 9
Let it use debian bullseye and rename the directory once, so we don't
need to rename it in the future when switching the debian version
again.
The reason I'm doing this now is that building with debian 9 failed
due to obs.osmocom.org related changes. It would be trivial to fix that,
but I decided to rather upgrade to the latest debian version.
Change-Id: Ib6039724a7200abce5252f95407047296b72cd51
---
R release-tarball-build-dist/Dockerfile
R release-tarball-build-dist/Makefile
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/debian-stretch-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile
similarity index 94%
rename from debian-stretch-build-dist/Dockerfile
rename to release-tarball-build-dist/Dockerfile
index e444ed5..bc0215e 100644
--- a/debian-stretch-build-dist/Dockerfile
+++ b/release-tarball-build-dist/Dockerfile
@@ -1,5 +1,5 @@
ARG USER
-FROM $USER/debian-stretch-obs-latest
+FROM $USER/debian-bullseye-obs-latest
# Arguments used after FROM must be specified again
RUN apt-get update && \
@@ -66,8 +66,6 @@
libzmq3-dev \
make \
mscgen \
- python-nwdiag \
- python-pychart \
python3-nwdiag \
xsltproc \
&& \
diff --git a/debian-stretch-build-dist/Makefile b/release-tarball-build-dist/Makefile
similarity index 100%
rename from debian-stretch-build-dist/Makefile
rename to release-tarball-build-dist/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28461
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ib6039724a7200abce5252f95407047296b72cd51
Gerrit-Change-Number: 28461
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28467 )
Change subject: configure.ac: Set libosmo-e1d dependency version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28467
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I2c6e50f73090a2134485d68a189036bc0aa00266
Gerrit-Change-Number: 28467
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 13:22:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 )
Change subject: encoding: fix an uninitialized field in gen_freq_params()
......................................................................
encoding: fix an uninitialized field in gen_freq_params()
This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0.
But still, let's ensure that all fields are initialized.
Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Fixes: CID#272999
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 4737137..f552111 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -573,6 +573,8 @@
fh_params.MAIO = pdch->fh.maio;
fh_params.GPRS_Mobile_Allocation.HSN = pdch->fh.hsn;
fh_params.GPRS_Mobile_Allocation.ElementsOf_RFL_NUMBER = 0;
+ memset(&fh_params.GPRS_Mobile_Allocation.RFL_NUMBER[0], 0x00,
+ sizeof(fh_params.GPRS_Mobile_Allocation.RFL_NUMBER));
/* Mobile Allocation bitmap */
fh_params.GPRS_Mobile_Allocation.UnionType = 0; /* MA bitmap */
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Gerrit-Change-Number: 28423
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged