dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28486 )
Change subject: tlv_parser: initialize output values
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I am not sure if this make sense at all, what I am trying to fix here is:
*** CID 273004: (TAINTED_SCALAR)
/source-Osmocom/osmo-bsc-nat/src/osmo-bsc-nat/bssap_conn.c: 56 in
bssmap_replace_ie_aoip_transp_addr()
50 return rv;
51 }
52
53 if (tag == GSM0808_IE_AOIP_TRASP_ADDR)
54 rc = gsm0808_enc_aoip_trasp_addr(msg_new, ss);
55 else
>> CID 273004: (TAINTED_SCALAR)
>> Passing tainted expression "len" to "tlv_encode_one",
which uses it as an offset.
56 rc = tlv_encode_one(msg_new,
def->def[tag].type, tag, len, val);
57
58 if (rc < 0) {
59 LOGP(DMAIN, LOGL_ERROR, "Failed to encode tag %d into copy of bssmap
msg\n", tag);
60 msgb_free(msg_new);
61 return rc;
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28486
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I87570ece10fbf64f3a57b34d84f8c843871f0db1
Gerrit-Change-Number: 28486
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 30 Jun 2022 08:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment