laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28461 )
Change subject: release-tarball-build-dist: upgrade from debian 9
......................................................................
release-tarball-build-dist: upgrade from debian 9
Let it use debian bullseye and rename the directory once, so we don't
need to rename it in the future when switching the debian version
again.
The reason I'm doing this now is that building with debian 9 failed
due to obs.osmocom.org related changes. It would be trivial to fix that,
but I decided to rather upgrade to the latest debian version.
Change-Id: Ib6039724a7200abce5252f95407047296b72cd51
---
R release-tarball-build-dist/Dockerfile
R release-tarball-build-dist/Makefile
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/debian-stretch-build-dist/Dockerfile b/release-tarball-build-dist/Dockerfile
similarity index 94%
rename from debian-stretch-build-dist/Dockerfile
rename to release-tarball-build-dist/Dockerfile
index e444ed5..bc0215e 100644
--- a/debian-stretch-build-dist/Dockerfile
+++ b/release-tarball-build-dist/Dockerfile
@@ -1,5 +1,5 @@
ARG USER
-FROM $USER/debian-stretch-obs-latest
+FROM $USER/debian-bullseye-obs-latest
# Arguments used after FROM must be specified again
RUN apt-get update && \
@@ -66,8 +66,6 @@
libzmq3-dev \
make \
mscgen \
- python-nwdiag \
- python-pychart \
python3-nwdiag \
xsltproc \
&& \
diff --git a/debian-stretch-build-dist/Makefile b/release-tarball-build-dist/Makefile
similarity index 100%
rename from debian-stretch-build-dist/Makefile
rename to release-tarball-build-dist/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28461
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ib6039724a7200abce5252f95407047296b72cd51
Gerrit-Change-Number: 28461
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28467 )
Change subject: configure.ac: Set libosmo-e1d dependency version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28467
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I2c6e50f73090a2134485d68a189036bc0aa00266
Gerrit-Change-Number: 28467
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 13:22:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 )
Change subject: encoding: fix an uninitialized field in gen_freq_params()
......................................................................
encoding: fix an uninitialized field in gen_freq_params()
This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0.
But still, let's ensure that all fields are initialized.
Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Fixes: CID#272999
---
M src/encoding.cpp
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/encoding.cpp b/src/encoding.cpp
index 4737137..f552111 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -573,6 +573,8 @@
fh_params.MAIO = pdch->fh.maio;
fh_params.GPRS_Mobile_Allocation.HSN = pdch->fh.hsn;
fh_params.GPRS_Mobile_Allocation.ElementsOf_RFL_NUMBER = 0;
+ memset(&fh_params.GPRS_Mobile_Allocation.RFL_NUMBER[0], 0x00,
+ sizeof(fh_params.GPRS_Mobile_Allocation.RFL_NUMBER));
/* Mobile Allocation bitmap */
fh_params.GPRS_Mobile_Allocation.UnionType = 0; /* MA bitmap */
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c
Gerrit-Change-Number: 28423
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged