Change in osmo-mgw[master]: mgcp-client: Avoid string not null terminated access - gerrit-log

30 Jun 2022

Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/28483
)

Change subject: mgcp-client: Avoid string not null terminated access
......................................................................

Patch Set 1:

(1 comment)

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/ac8acadf_02d28504 
PS1, Line 732: 	/* EOS char to avoid out-of-buf str access, not part of the msg: */
...
  mgcp_client_rx() calls mgcp_response_parse_head(),
which in its turn calls mgcp_msg_terminate_nul(). […] Good point, I didn't see
that, and coverity neither. Abandoning the patch.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/28483
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685
Gerrit-Change-Number: 28483
Gerrit-PatchSet: 1
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 30 Jun 2022 06:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment