Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/28483 )
Change subject: mgcp-client: Avoid string not null terminated access
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/28483/comment/15c4b51a_190325bb
PS1, Line 732: /* EOS char to avoid out-of-buf str access, not part of the msg: */
mgcp_client_rx() calls mgcp_response_parse_head(), which in its turn calls
mgcp_msg_terminate_nul(). Are you sure adding '\0' is really needed here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/28483
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icb61a22f6dfd6267e469dc3e607e7d634b7d4685
Gerrit-Change-Number: 28483
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Jun 2022 22:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment