Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/27638
to look at the new patch set (#7).
Change subject: add pfcp msg test
......................................................................
add pfcp msg test
Related: SYS#5599
Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
---
M configure.ac
M tests/Makefile.am
A tests/libosmo-pfcp/Makefile.am
A tests/libosmo-pfcp/pfcp_test.c
A tests/libosmo-pfcp/pfcp_test.ok
M tests/testsuite.at
6 files changed, 706 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
Gerrit-Change-Number: 27638
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28224
to look at the new patch set (#2).
Change subject: pfcp/Makefile.am: add missing pfcp_ies_auto.h entry
......................................................................
pfcp/Makefile.am: add missing pfcp_ies_auto.h entry
Even though it is a generated header, it must still be listed in
pfcp_HEADERS.
Related: SYS#5599
Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f
---
M include/osmocom/pfcp/Makefile.am
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/24/28224/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I6fbfe1fcd084f2d16334bb3e44d9891d9485d59f
Gerrit-Change-Number: 28224
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28225
to look at the new patch set (#2).
Change subject: pfcp ie: tweak CP Function Features
......................................................................
pfcp ie: tweak CP Function Features
The spec indicates three bytes of CP Function Features, but both
wireshark and ttcn3 expect only one byte. This makes sense because only
eight CP F.F. flags are defined.
Drop those two always-zero bytes, hence pass the wireshark dissector and
ttcn3 parsing without warnings.
Related: SYS#5599
Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5
---
M include/osmocom/pfcp/pfcp_ies_custom.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/25/28225/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28225
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5
Gerrit-Change-Number: 28225
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/28226
to look at the new patch set (#2).
Change subject: api: osmo_pfcp_ie_node_id_to_str_c
......................................................................
api: osmo_pfcp_ie_node_id_to_str_c
Related: SYS#5599
Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae
---
M include/osmocom/pfcp/pfcp_ies_custom.h
M src/libosmo-pfcp/pfcp_ies_custom.c
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/26/28226/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I5c580bc510afce58a03dea0861db9630b063b2ae
Gerrit-Change-Number: 28226
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/27631
to look at the new patch set (#5).
Change subject: libosmo-pfcp: implement PFCP header and msg handling
......................................................................
libosmo-pfcp: implement PFCP header and msg handling
Related: SYS#5599
Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e
---
M include/osmocom/pfcp/Makefile.am
A include/osmocom/pfcp/pfcp_msg.h
M src/libosmo-pfcp/Makefile.am
M src/libosmo-pfcp/pfcp_ies_custom.c
A src/libosmo-pfcp/pfcp_msg.c
5 files changed, 726 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/31/27631/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e
Gerrit-Change-Number: 27631
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/27638
to look at the new patch set (#6).
Change subject: add pfcp msg test
......................................................................
add pfcp msg test
Related: SYS#5599
Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
---
M configure.ac
M tests/Makefile.am
A tests/libosmo-pfcp/Makefile.am
A tests/libosmo-pfcp/pfcp_test.c
A tests/libosmo-pfcp/pfcp_test.ok
M tests/testsuite.at
6 files changed, 706 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
Gerrit-Change-Number: 27638
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/27638
to look at the new patch set (#5).
Change subject: add pfcp msg test
......................................................................
add pfcp msg test
Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
---
M configure.ac
M tests/Makefile.am
A tests/libosmo-pfcp/Makefile.am
A tests/libosmo-pfcp/pfcp_test.c
A tests/libosmo-pfcp/pfcp_test.ok
M tests/testsuite.at
6 files changed, 706 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
Gerrit-Change-Number: 27638
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27638 )
Change subject: add pfcp msg test
......................................................................
Patch Set 4:
(1 comment)
File tests/libosmo-pfcp/pfcp_test.c:
https://gerrit.osmocom.org/c/osmo-upf/+/27638/comment/46a051af_487b3833
PS4, Line 42: const struct osmo_sockaddr v4_gtp = {
I have a problem now. You can see v4_gtp is const. (also tried with static const)
At home with gcc (Debian 8.3.0-6) 8.3.0 it compiles fine.
Jenkins however says:
pfcp_test.c:61:10: error: initializer element is not constant
.v4 = v4_gtp,
^~~~~~
Same for a couple more similar cases below.
stackoverflow suggests these should be #defines instead.
any better idea anyone?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
Gerrit-Change-Number: 27638
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 06 Jun 2022 23:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/27638
to look at the new patch set (#4).
Change subject: add pfcp msg test
......................................................................
add pfcp msg test
Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
---
M configure.ac
M tests/Makefile.am
A tests/libosmo-pfcp/Makefile.am
A tests/libosmo-pfcp/pfcp_test.c
A tests/libosmo-pfcp/pfcp_test.ok
M tests/testsuite.at
6 files changed, 699 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/38/27638/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I30bdfc66a8f96c0639513ef406e9b66525dced6d
Gerrit-Change-Number: 27638
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
